Title: [249800] trunk/Source/WebInspectorUI
- Revision
- 249800
- Author
- pecor...@apple.com
- Date
- 2019-09-12 00:50:18 -0700 (Thu, 12 Sep 2019)
Log Message
Uncaught Exception: TypeError: null is not an object (evaluating 'selectedTreeElement.representedObject')
https://bugs.webkit.org/show_bug.cgi?id=201716
<rdar://problem/55292615>
Reviewed by Devin Rousso.
* UserInterface/Views/DebuggerSidebarPanel.js:
(WI.DebuggerSidebarPanel.prototype._handleBreakpointElementAddedOrRemoved):
* UserInterface/Views/SourcesNavigationSidebarPanel.js:
(WI.SourcesNavigationSidebarPanel.prototype._handleBreakpointElementAddedOrRemoved):
If a breakpoint was removed without a selection in the breakpoint tree outline
then there may be no selected tree element.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (249799 => 249800)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-09-12 06:55:26 UTC (rev 249799)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-09-12 07:50:18 UTC (rev 249800)
@@ -1,3 +1,18 @@
+2019-09-12 Joseph Pecoraro <pecor...@apple.com>
+
+ Uncaught Exception: TypeError: null is not an object (evaluating 'selectedTreeElement.representedObject')
+ https://bugs.webkit.org/show_bug.cgi?id=201716
+ <rdar://problem/55292615>
+
+ Reviewed by Devin Rousso.
+
+ * UserInterface/Views/DebuggerSidebarPanel.js:
+ (WI.DebuggerSidebarPanel.prototype._handleBreakpointElementAddedOrRemoved):
+ * UserInterface/Views/SourcesNavigationSidebarPanel.js:
+ (WI.SourcesNavigationSidebarPanel.prototype._handleBreakpointElementAddedOrRemoved):
+ If a breakpoint was removed without a selection in the breakpoint tree outline
+ then there may be no selected tree element.
+
2019-09-11 Joseph Pecoraro <pecor...@apple.com>
Web Inspector: REGRESSION: Inspector Timeline always starts at about 500ms mark on a reload
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js (249799 => 249800)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js 2019-09-12 06:55:26 UTC (rev 249799)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js 2019-09-12 07:50:18 UTC (rev 249800)
@@ -1595,16 +1595,17 @@
if (event.type === WI.TreeOutline.Event.ElementRemoved) {
let selectedTreeElement = this._breakpointsContentTreeOutline.selectedTreeElement;
- console.assert(selectedTreeElement);
- if (selectedTreeElement.representedObject === WI.debuggerManager.assertionFailuresBreakpoint || !WI.debuggerManager.isBreakpointRemovable(selectedTreeElement.representedObject)) {
- const skipUnrevealed = true;
- const dontPopulate = true;
- let treeElementToSelect = selectedTreeElement.traverseNextTreeElement(skipUnrevealed, dontPopulate);
- if (treeElementToSelect) {
- const omitFocus = true;
- const selectedByUser = true;
- treeElementToSelect.select(omitFocus, selectedByUser);
- }
+ if (selectedTreeElement) {
+ if (selectedTreeElement.representedObject === WI.debuggerManager.assertionFailuresBreakpoint || !WI.debuggerManager.isBreakpointRemovable(selectedTreeElement.representedObject)) {
+ const skipUnrevealed = true;
+ const dontPopulate = true;
+ let treeElementToSelect = selectedTreeElement.traverseNextTreeElement(skipUnrevealed, dontPopulate);
+ if (treeElementToSelect) {
+ const omitFocus = true;
+ const selectedByUser = true;
+ treeElementToSelect.select(omitFocus, selectedByUser);
+ }
+ }
}
}
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js (249799 => 249800)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js 2019-09-12 06:55:26 UTC (rev 249799)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js 2019-09-12 07:50:18 UTC (rev 249800)
@@ -1759,15 +1759,16 @@
if (event.type === WI.TreeOutline.Event.ElementRemoved) {
let selectedTreeElement = this._breakpointsTreeOutline.selectedTreeElement;
- console.assert(selectedTreeElement);
- if (selectedTreeElement.representedObject === WI.debuggerManager.assertionFailuresBreakpoint || !WI.debuggerManager.isBreakpointRemovable(selectedTreeElement.representedObject)) {
- const skipUnrevealed = true;
- const dontPopulate = true;
- let treeElementToSelect = selectedTreeElement.traverseNextTreeElement(skipUnrevealed, dontPopulate);
- if (treeElementToSelect) {
- const omitFocus = true;
- const selectedByUser = true;
- treeElementToSelect.select(omitFocus, selectedByUser);
+ if (selectedTreeElement) {
+ if (selectedTreeElement.representedObject === WI.debuggerManager.assertionFailuresBreakpoint || !WI.debuggerManager.isBreakpointRemovable(selectedTreeElement.representedObject)) {
+ const skipUnrevealed = true;
+ const dontPopulate = true;
+ let treeElementToSelect = selectedTreeElement.traverseNextTreeElement(skipUnrevealed, dontPopulate);
+ if (treeElementToSelect) {
+ const omitFocus = true;
+ const selectedByUser = true;
+ treeElementToSelect.select(omitFocus, selectedByUser);
+ }
}
}
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
