Title: [249802] trunk/Source/WebKit
- Revision
- 249802
- Author
- ctur...@igalia.com
- Date
- 2019-09-12 01:44:09 -0700 (Thu, 12 Sep 2019)
Log Message
[GTK] Allow CacheStore::destroyEngine to destroy default engine for soup.
https://bugs.webkit.org/show_bug.cgi?id=201690
Reviewed by Carlos Garcia Campos.
* NetworkProcess/cache/CacheStorageEngine.cpp:
(WebKit::CacheStorage::Engine::destroyEngine): As we do for
NetworkProcess::destroySession, also allow destroying the engine
for the default session for the same reason.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (249801 => 249802)
--- trunk/Source/WebKit/ChangeLog 2019-09-12 08:18:15 UTC (rev 249801)
+++ trunk/Source/WebKit/ChangeLog 2019-09-12 08:44:09 UTC (rev 249802)
@@ -1,3 +1,15 @@
+2019-09-12 Charlie Turner <ctur...@igalia.com>
+
+ [GTK] Allow CacheStore::destroyEngine to destroy default engine for soup.
+ https://bugs.webkit.org/show_bug.cgi?id=201690
+
+ Reviewed by Carlos Garcia Campos.
+
+ * NetworkProcess/cache/CacheStorageEngine.cpp:
+ (WebKit::CacheStorage::Engine::destroyEngine): As we do for
+ NetworkProcess::destroySession, also allow destroying the engine
+ for the default session for the same reason.
+
2019-09-12 Youenn Fablet <you...@apple.com>
Use WebProcess processIdentifier to identify Service Worker connections
Modified: trunk/Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp (249801 => 249802)
--- trunk/Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp 2019-09-12 08:18:15 UTC (rev 249801)
+++ trunk/Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp 2019-09-12 08:44:09 UTC (rev 249802)
@@ -89,7 +89,12 @@
void Engine::destroyEngine(NetworkProcess& networkProcess, PAL::SessionID sessionID)
{
+#if !USE(SOUP)
+ // Soup based ports destroy the default session right before the process exits to avoid leaking
+ // network resources like the cookies database.
ASSERT(sessionID != PAL::SessionID::defaultSessionID());
+#endif
+
networkProcess.removeCacheEngine(sessionID);
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
