Title: [249847] trunk/Source/WebInspectorUI
- Revision
- 249847
- Author
- pecor...@apple.com
- Date
- 2019-09-13 12:02:59 -0700 (Fri, 13 Sep 2019)
Log Message
REGRESSION: Web Inspector: Layout Timeline View does not show popover for initiator data
https://bugs.webkit.org/show_bug.cgi?id=201732
<rdar://problem/55312339>
Reviewed by Devin Rousso.
* UserInterface/Views/LayoutTimelineDataGrid.js:
(WI.LayoutTimelineDataGrid.prototype.callFramePopoverAnchorElement):
(WI.LayoutTimelineDataGrid.prototype.shouldShowCallFramePopover):
The column name was incorrect.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (249846 => 249847)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-09-13 18:58:30 UTC (rev 249846)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-09-13 19:02:59 UTC (rev 249847)
@@ -1,5 +1,18 @@
2019-09-13 Joseph Pecoraro <pecor...@apple.com>
+ REGRESSION: Web Inspector: Layout Timeline View does not show popover for initiator data
+ https://bugs.webkit.org/show_bug.cgi?id=201732
+ <rdar://problem/55312339>
+
+ Reviewed by Devin Rousso.
+
+ * UserInterface/Views/LayoutTimelineDataGrid.js:
+ (WI.LayoutTimelineDataGrid.prototype.callFramePopoverAnchorElement):
+ (WI.LayoutTimelineDataGrid.prototype.shouldShowCallFramePopover):
+ The column name was incorrect.
+
+2019-09-13 Joseph Pecoraro <pecor...@apple.com>
+
Uncaught Exception: null is not an object (evaluating 'Object.keys(propertyNames)') (at _javascript_RuntimeCompletionProvider.js:244:57)
https://bugs.webkit.org/show_bug.cgi?id=201729
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/LayoutTimelineDataGrid.js (249846 => 249847)
--- trunk/Source/WebInspectorUI/UserInterface/Views/LayoutTimelineDataGrid.js 2019-09-13 18:58:30 UTC (rev 249846)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/LayoutTimelineDataGrid.js 2019-09-13 19:02:59 UTC (rev 249847)
@@ -29,11 +29,11 @@
callFramePopoverAnchorElement()
{
- return this.selectedNode.elementWithColumnIdentifier("location");
+ return this.selectedNode.elementWithColumnIdentifier("initiator");
}
shouldShowCallFramePopover()
{
- return this.isColumnVisible("location");
+ return this.isColumnVisible("initiator");
}
};
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
