Title: [249868] trunk/Source/_javascript_Core
Revision
249868
Author
mark....@apple.com
Date
2019-09-13 19:22:49 -0700 (Fri, 13 Sep 2019)

Log Message

jsc -d stopped working.
https://bugs.webkit.org/show_bug.cgi?id=201787

Reviewed by Joseph Pecoraro.

The reason is because, in this case, the jsc shell is trying to set an option
after the VM has been instantiated.  The fix is simply to move all options
initialization before the VM is instantiated.

* jsc.cpp:
(runWithOptions):
(jscmain):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (249867 => 249868)


--- trunk/Source/_javascript_Core/ChangeLog	2019-09-14 02:16:00 UTC (rev 249867)
+++ trunk/Source/_javascript_Core/ChangeLog	2019-09-14 02:22:49 UTC (rev 249868)
@@ -1,5 +1,20 @@
 2019-09-13  Mark Lam  <mark....@apple.com>
 
+        jsc -d stopped working.
+        https://bugs.webkit.org/show_bug.cgi?id=201787
+
+        Reviewed by Joseph Pecoraro.
+
+        The reason is because, in this case, the jsc shell is trying to set an option
+        after the VM has been instantiated.  The fix is simply to move all options
+        initialization before the VM is instantiated.
+
+        * jsc.cpp:
+        (runWithOptions):
+        (jscmain):
+
+2019-09-13  Mark Lam  <mark....@apple.com>
+
         watchOS requires PageSize alignment of 16K for JSC::Config.
         https://bugs.webkit.org/show_bug.cgi?id=201786
         <rdar://problem/55357890>

Modified: trunk/Source/_javascript_Core/jsc.cpp (249867 => 249868)


--- trunk/Source/_javascript_Core/jsc.cpp	2019-09-14 02:16:00 UTC (rev 249867)
+++ trunk/Source/_javascript_Core/jsc.cpp	2019-09-14 02:22:49 UTC (rev 249868)
@@ -2621,9 +2621,6 @@
     String fileName;
     Vector<char> scriptBuffer;
 
-    if (options.m_dump)
-        JSC::Options::dumpGeneratedBytecodes() = true;
-
     VM& vm = globalObject->vm();
     auto scope = DECLARE_CATCH_SCOPE(vm);
 
@@ -3097,6 +3094,8 @@
     CommandLine options(argc, argv);
 
     processConfigFile(Options::configFile(), "jsc");
+    if (options.m_dump)
+        JSC::Options::dumpGeneratedBytecodes() = true;
 
     // Initialize JSC before getting VM.
     JSC::initializeThreading();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to