Title: [249887] trunk/Source/WebCore
- Revision
- 249887
- Author
- [email protected]
- Date
- 2019-09-15 14:43:27 -0700 (Sun, 15 Sep 2019)
Log Message
Missing call to [self init] in -[WebScrollbarPartAnimation initWithScrollbar:featureToAnimate:animateFrom:animateTo:duration:]
<https://webkit.org/b/201806>
Reviewed by Simon Fraser.
* platform/mac/ScrollAnimatorMac.mm:
(-[WebScrollbarPartAnimation initWithScrollbar:featureToAnimate:animateFrom:animateTo:duration:]):
Call [self init] and return early if the result is nil.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (249886 => 249887)
--- trunk/Source/WebCore/ChangeLog 2019-09-15 19:25:50 UTC (rev 249886)
+++ trunk/Source/WebCore/ChangeLog 2019-09-15 21:43:27 UTC (rev 249887)
@@ -1,3 +1,14 @@
+2019-09-15 David Kilzer <[email protected]>
+
+ Missing call to [self init] in -[WebScrollbarPartAnimation initWithScrollbar:featureToAnimate:animateFrom:animateTo:duration:]
+ <https://webkit.org/b/201806>
+
+ Reviewed by Simon Fraser.
+
+ * platform/mac/ScrollAnimatorMac.mm:
+ (-[WebScrollbarPartAnimation initWithScrollbar:featureToAnimate:animateFrom:animateTo:duration:]):
+ Call [self init] and return early if the result is nil.
+
2019-09-14 Justin Fan <[email protected]>
[WebGPU] Make WebGPURenderPipeline and WebGPUComputePipeline inherit from GPUObjectBase
Modified: trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm (249886 => 249887)
--- trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm 2019-09-15 19:25:50 UTC (rev 249886)
+++ trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm 2019-09-15 21:43:27 UTC (rev 249887)
@@ -321,6 +321,10 @@
if (!self)
return nil;
#else
+ self = [super init];
+ if (!self)
+ return nil;
+
const NSTimeInterval timeInterval = 0.01;
_timer = adoptNS([[NSTimer alloc] initWithFireDate:[NSDate dateWithTimeIntervalSinceNow:0] interval:timeInterval target:self selector:@selector(setCurrentProgress:) userInfo:nil repeats:YES]);
_duration = duration;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
