Title: [249902] trunk/Source/WebKit
- Revision
- 249902
- Author
- [email protected]
- Date
- 2019-09-16 09:41:46 -0700 (Mon, 16 Sep 2019)
Log Message
REGRESSION (r243113): Leak of multiple instance variable blocks when deallocating _WKAttributedStringNavigationDelegate
<https://webkit.org/b/201812>
Reviewed by Timothy Hatcher.
* UIProcess/API/Cocoa/NSAttributedString.mm:
(-[_WKAttributedStringNavigationDelegate dealloc]): Add method
to release instance variable blocks to fix potential leaks.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (249901 => 249902)
--- trunk/Source/WebKit/ChangeLog 2019-09-16 16:26:53 UTC (rev 249901)
+++ trunk/Source/WebKit/ChangeLog 2019-09-16 16:41:46 UTC (rev 249902)
@@ -1,3 +1,14 @@
+2019-09-16 David Kilzer <[email protected]>
+
+ REGRESSION (r243113): Leak of multiple instance variable blocks when deallocating _WKAttributedStringNavigationDelegate
+ <https://webkit.org/b/201812>
+
+ Reviewed by Timothy Hatcher.
+
+ * UIProcess/API/Cocoa/NSAttributedString.mm:
+ (-[_WKAttributedStringNavigationDelegate dealloc]): Add method
+ to release instance variable blocks to fix potential leaks.
+
2019-09-16 Adrian Perez de Castro <[email protected]>
Unreviewed build fix.
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/NSAttributedString.mm (249901 => 249902)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/NSAttributedString.mm 2019-09-16 16:26:53 UTC (rev 249901)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/NSAttributedString.mm 2019-09-16 16:41:46 UTC (rev 249902)
@@ -63,6 +63,22 @@
@implementation _WKAttributedStringNavigationDelegate
+- (void)dealloc
+{
+ [_webContentProcessDidTerminate release];
+ _webContentProcessDidTerminate = nil;
+ [_decidePolicyForNavigationAction release];
+ _decidePolicyForNavigationAction = nil;
+ [_didFailProvisionalNavigation release];
+ _didFailProvisionalNavigation = nil;
+ [_didFailNavigation release];
+ _didFailNavigation = nil;
+ [_didFinishNavigation release];
+ _didFinishNavigation = nil;
+
+ [super dealloc];
+}
+
- (void)webViewWebContentProcessDidTerminate:(WKWebView *)webView
{
if (_webContentProcessDidTerminate)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
