Title: [249948] trunk/Source/WebKit
- Revision
- 249948
- Author
- carlo...@webkit.org
- Date
- 2019-09-17 01:14:29 -0700 (Tue, 17 Sep 2019)
Log Message
Keeps running obsolete WebProcess-es for too long
https://bugs.webkit.org/show_bug.cgi?id=201492
Reviewed by Chris Dumez.
That's how the web process cache is expected to work, but it's true that it probably only makes sense to use it
when cache model is primary web browser.
* UIProcess/WebProcessCache.cpp:
(WebKit::WebProcessCache::updateCapacity): Disable the web process cache when cache model is not primary web browser.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (249947 => 249948)
--- trunk/Source/WebKit/ChangeLog 2019-09-17 08:05:30 UTC (rev 249947)
+++ trunk/Source/WebKit/ChangeLog 2019-09-17 08:14:29 UTC (rev 249948)
@@ -1,5 +1,18 @@
2019-09-17 Carlos Garcia Campos <cgar...@igalia.com>
+ Keeps running obsolete WebProcess-es for too long
+ https://bugs.webkit.org/show_bug.cgi?id=201492
+
+ Reviewed by Chris Dumez.
+
+ That's how the web process cache is expected to work, but it's true that it probably only makes sense to use it
+ when cache model is primary web browser.
+
+ * UIProcess/WebProcessCache.cpp:
+ (WebKit::WebProcessCache::updateCapacity): Disable the web process cache when cache model is not primary web browser.
+
+2019-09-17 Carlos Garcia Campos <cgar...@igalia.com>
+
[GTK] Crash closing web view while hardware acceleration is enabled
https://bugs.webkit.org/show_bug.cgi?id=200856
Modified: trunk/Source/WebKit/UIProcess/WebProcessCache.cpp (249947 => 249948)
--- trunk/Source/WebKit/UIProcess/WebProcessCache.cpp 2019-09-17 08:05:30 UTC (rev 249947)
+++ trunk/Source/WebKit/UIProcess/WebProcessCache.cpp 2019-09-17 08:14:29 UTC (rev 249948)
@@ -150,11 +150,13 @@
void WebProcessCache::updateCapacity(WebProcessPool& processPool)
{
- if (!processPool.configuration().processSwapsOnNavigation() || !processPool.configuration().usesWebProcessCache()) {
+ if (!processPool.configuration().processSwapsOnNavigation() || !processPool.configuration().usesWebProcessCache() || processPool.cacheModel() != CacheModel::PrimaryWebBrowser) {
if (!processPool.configuration().processSwapsOnNavigation())
RELEASE_LOG(ProcessSwapping, "%p - WebProcessCache::updateCapacity: Cache is disabled because process swap on navigation is disabled", this);
+ else if (!processPool.configuration().usesWebProcessCache())
+ RELEASE_LOG(ProcessSwapping, "%p - WebProcessCache::updateCapacity: Cache is disabled by client", this);
else
- RELEASE_LOG(ProcessSwapping, "%p - WebProcessCache::updateCapacity: Cache is disabled by client", this);
+ RELEASE_LOG(ProcessSwapping, "%p - WebProcessCache::updateCapacity: Cache is disabled because cache model is not PrimaryWebBrowser", this);
m_capacity = 0;
} else {
size_t memorySize = ramSize() / GB;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
