Title: [250147] trunk/Source/WebCore
- Revision
- 250147
- Author
- [email protected]
- Date
- 2019-09-20 13:30:33 -0700 (Fri, 20 Sep 2019)
Log Message
[SVG2]: Add auto behavior for rx and ry to the SVG <ellipse> and <rect> elements (Addressing review comments)
https://bugs.webkit.org/show_bug.cgi?id=199843
Patch by Said Abou-Hallawa <[email protected]> on 2019-09-20
Reviewed by Darin Adler.
Make RenderSVGEllipse calculate of the ellipse's rx and ry more efficiently.
* rendering/svg/RenderSVGEllipse.cpp:
(WebCore::RenderSVGEllipse::calculateRadiiAndCenter):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (250146 => 250147)
--- trunk/Source/WebCore/ChangeLog 2019-09-20 20:29:24 UTC (rev 250146)
+++ trunk/Source/WebCore/ChangeLog 2019-09-20 20:30:33 UTC (rev 250147)
@@ -1,3 +1,15 @@
+2019-09-20 Said Abou-Hallawa <[email protected]>
+
+ [SVG2]: Add auto behavior for rx and ry to the SVG <ellipse> and <rect> elements (Addressing review comments)
+ https://bugs.webkit.org/show_bug.cgi?id=199843
+
+ Reviewed by Darin Adler.
+
+ Make RenderSVGEllipse calculate of the ellipse's rx and ry more efficiently.
+
+ * rendering/svg/RenderSVGEllipse.cpp:
+ (WebCore::RenderSVGEllipse::calculateRadiiAndCenter):
+
2019-09-20 Keith Rollin <[email protected]>
Remove some support for < iOS 13
Modified: trunk/Source/WebCore/rendering/svg/RenderSVGEllipse.cpp (250146 => 250147)
--- trunk/Source/WebCore/rendering/svg/RenderSVGEllipse.cpp 2019-09-20 20:29:24 UTC (rev 250146)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGEllipse.cpp 2019-09-20 20:30:33 UTC (rev 250147)
@@ -90,16 +90,10 @@
ASSERT(is<SVGEllipseElement>(graphicsElement()));
Length rx = style().svgStyle().rx();
- if (rx.isAuto())
- rx = style().svgStyle().ry();
-
Length ry = style().svgStyle().ry();
- if (ry.isAuto())
- ry = style().svgStyle().rx();
-
m_radii = FloatSize(
- lengthContext.valueForLength(rx, SVGLengthMode::Width),
- lengthContext.valueForLength(ry, SVGLengthMode::Height));
+ lengthContext.valueForLength(rx.isAuto() ? ry : rx, SVGLengthMode::Width),
+ lengthContext.valueForLength(ry.isAuto() ? rx : ry, SVGLengthMode::Height));
}
void RenderSVGEllipse::fillShape(GraphicsContext& context) const
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
