Title: [250326] trunk/Source/WebCore
- Revision
- 250326
- Author
- wenson_hs...@apple.com
- Date
- 2019-09-24 17:14:23 -0700 (Tue, 24 Sep 2019)
Log Message
Remove a content change observation quirk on united.com
https://bugs.webkit.org/show_bug.cgi?id=202175
Reviewed by Tim Horton.
Remove a site-specific quirk that is no longer necessary.
* page/Quirks.cpp:
(WebCore::Quirks::shouldIgnoreContentChange const): Deleted.
* page/Quirks.h:
* page/ios/ContentChangeObserver.cpp:
(WebCore::ContentChangeObserver::shouldObserveVisibilityChangeForElement):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (250325 => 250326)
--- trunk/Source/WebCore/ChangeLog 2019-09-25 00:13:59 UTC (rev 250325)
+++ trunk/Source/WebCore/ChangeLog 2019-09-25 00:14:23 UTC (rev 250326)
@@ -1,3 +1,18 @@
+2019-09-24 Wenson Hsieh <wenson_hs...@apple.com>
+
+ Remove a content change observation quirk on united.com
+ https://bugs.webkit.org/show_bug.cgi?id=202175
+
+ Reviewed by Tim Horton.
+
+ Remove a site-specific quirk that is no longer necessary.
+
+ * page/Quirks.cpp:
+ (WebCore::Quirks::shouldIgnoreContentChange const): Deleted.
+ * page/Quirks.h:
+ * page/ios/ContentChangeObserver.cpp:
+ (WebCore::ContentChangeObserver::shouldObserveVisibilityChangeForElement):
+
2019-09-24 Kate Cheney <katherine_che...@apple.com>
Enable LayoutTests using ResourceLoadStatistics SQLite backend (195420)
Modified: trunk/Source/WebCore/page/Quirks.cpp (250325 => 250326)
--- trunk/Source/WebCore/page/Quirks.cpp 2019-09-25 00:13:59 UTC (rev 250325)
+++ trunk/Source/WebCore/page/Quirks.cpp 2019-09-25 00:14:23 UTC (rev 250326)
@@ -473,30 +473,6 @@
#endif
}
-bool Quirks::shouldIgnoreContentChange(const Element& element) const
-{
-#if PLATFORM(IOS_FAMILY)
- if (!needsQuirks())
- return false;
-
- auto* parentElement = element.parentElement();
- if (!parentElement || !parentElement->hasClass())
- return false;
-
- DOMTokenList& classList = parentElement->classList();
- if (!classList.contains("feedback") || !classList.contains("feedback-mid"))
- return false;
-
- if (!equalLettersIgnoringASCIICase(topPrivatelyControlledDomain(m_document->url().host().toString()), "united.com"))
- return false;
-
- return true;
-#else
- UNUSED_PARAM(element);
- return false;
-#endif
-}
-
// FIXME(<rdar://problem/50394969>): Remove after desmos.com adopts inputmode="none".
bool Quirks::needsInputModeNoneImplicitly(const HTMLElement& element) const
{
Modified: trunk/Source/WebCore/page/Quirks.h (250325 => 250326)
--- trunk/Source/WebCore/page/Quirks.h 2019-09-25 00:13:59 UTC (rev 250325)
+++ trunk/Source/WebCore/page/Quirks.h 2019-09-25 00:14:23 UTC (rev 250326)
@@ -57,7 +57,6 @@
bool shouldMakeTouchEventNonCancelableForTarget(EventTarget*) const;
#endif
bool shouldDisablePointerEventsQuirk() const;
- bool shouldIgnoreContentChange(const Element&) const;
bool needsInputModeNoneImplicitly(const HTMLElement&) const;
bool needsDeferKeyDownAndKeyPressTimersUntilNextEditingCommand() const;
bool shouldLightenJapaneseBoldSansSerif() const;
Modified: trunk/Source/WebCore/page/ios/ContentChangeObserver.cpp (250325 => 250326)
--- trunk/Source/WebCore/page/ios/ContentChangeObserver.cpp 2019-09-25 00:13:59 UTC (rev 250325)
+++ trunk/Source/WebCore/page/ios/ContentChangeObserver.cpp 2019-09-25 00:14:23 UTC (rev 250326)
@@ -630,7 +630,7 @@
bool ContentChangeObserver::shouldObserveVisibilityChangeForElement(const Element& element)
{
- return isObservingContentChanges() && !visibleRendererWasDestroyed(element) && !element.document().quirks().shouldIgnoreContentChange(element);
+ return isObservingContentChanges() && !visibleRendererWasDestroyed(element);
}
ContentChangeObserver::StyleChangeScope::StyleChangeScope(Document& document, const Element& element)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
