Title: [250376] trunk/Source/WebInspectorUI
- Revision
- 250376
- Author
- pecor...@apple.com
- Date
- 2019-09-25 21:19:11 -0700 (Wed, 25 Sep 2019)
Log Message
Web Inspector: REGRESSION: Elements detail sidebar sometimes starts collapsed
https://bugs.webkit.org/show_bug.cgi?id=202057
<rdar://problem/55572345>
Reviewed by Devin Rousso.
* UserInterface/Views/ElementsTabContentView.js:
(WI.ElementsTabContentView.prototype.get detailsSidebarExpandedByDefault):
Default the Elements tab detail sidebar to be shown, not collapsed.
* UserInterface/Views/TabContentView.js:
(WI.TabContentView):
(WI.TabContentView.prototype.get detailsSidebarExpandedByDefault):
Allow classes to specify whether or not their detail sidebar should
be expanded by default.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (250375 => 250376)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-09-26 02:01:53 UTC (rev 250375)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-09-26 04:19:11 UTC (rev 250376)
@@ -1,3 +1,21 @@
+2019-09-25 Joseph Pecoraro <pecor...@apple.com>
+
+ Web Inspector: REGRESSION: Elements detail sidebar sometimes starts collapsed
+ https://bugs.webkit.org/show_bug.cgi?id=202057
+ <rdar://problem/55572345>
+
+ Reviewed by Devin Rousso.
+
+ * UserInterface/Views/ElementsTabContentView.js:
+ (WI.ElementsTabContentView.prototype.get detailsSidebarExpandedByDefault):
+ Default the Elements tab detail sidebar to be shown, not collapsed.
+
+ * UserInterface/Views/TabContentView.js:
+ (WI.TabContentView):
+ (WI.TabContentView.prototype.get detailsSidebarExpandedByDefault):
+ Allow classes to specify whether or not their detail sidebar should
+ be expanded by default.
+
2019-09-25 Devin Rousso <drou...@apple.com>
Web Inspector: Uncaught Exception: TypeError: undefined is not an object (evaluating 'WI.showDebugUISetting.addEventListener')
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ElementsTabContentView.js (250375 => 250376)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ElementsTabContentView.js 2019-09-26 02:01:53 UTC (rev 250375)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ElementsTabContentView.js 2019-09-26 04:19:11 UTC (rev 250376)
@@ -64,6 +64,11 @@
return true;
}
+ get detailsSidebarExpandedByDefault()
+ {
+ return true;
+ }
+
canShowRepresentedObject(representedObject)
{
return representedObject instanceof WI.DOMTree;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TabContentView.js (250375 => 250376)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TabContentView.js 2019-09-26 02:01:53 UTC (rev 250375)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TabContentView.js 2019-09-26 04:19:11 UTC (rev 250376)
@@ -52,7 +52,7 @@
this._navigationSidebarCollapsedSetting = new WI.Setting(identifier + "-navigation-sidebar-collapsed", false);
this._navigationSidebarWidthSetting = new WI.Setting(identifier + "-navigation-sidebar-width", defaultSidebarWidth);
- this._detailsSidebarCollapsedSetting = new WI.Setting(identifier + "-details-sidebar-collapsed", true);
+ this._detailsSidebarCollapsedSetting = new WI.Setting(identifier + "-details-sidebar-collapsed", !this.detailsSidebarExpandedByDefault);
this._detailsSidebarSelectedPanelSetting = new WI.Setting(identifier + "-details-sidebar-selected-panel", null);
this._detailsSidebarWidthSetting = new WI.Setting(identifier + "-details-sidebar-width", defaultSidebarWidth);
@@ -101,6 +101,12 @@
return false;
}
+ get detailsSidebarExpandedByDefault()
+ {
+ // Implemented by subclasses.
+ return false;
+ }
+
showDetailsSidebarPanels()
{
// Implemented by subclasses.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
