Diff
Modified: trunk/Source/WebCore/ChangeLog (250660 => 250661)
--- trunk/Source/WebCore/ChangeLog 2019-10-03 17:45:03 UTC (rev 250660)
+++ trunk/Source/WebCore/ChangeLog 2019-10-03 17:49:03 UTC (rev 250661)
@@ -1,5 +1,25 @@
2019-10-03 Tim Horton <timothy_hor...@apple.com>
+ WebKit doesn't build with trunk clang
+ https://bugs.webkit.org/show_bug.cgi?id=202511
+
+ Reviewed by Anders Carlsson.
+
+ * Modules/fetch/FetchLoader.h:
+ * Modules/geolocation/Geolocation.h:
+ * Modules/indexeddb/IDBTransaction.h:
+ * Modules/indexeddb/shared/InProcessIDBServer.cpp:
+ * Modules/indexeddb/shared/InProcessIDBServer.h:
+ * Modules/notifications/Notification.cpp:
+ * Modules/notifications/Notification.h:
+ * platform/graphics/ca/TileController.h:
+ * workers/service/context/ServiceWorkerThreadProxy.h:
+ Fix the build by exporting destructors and custom delete operators.
+ I don't know why this changed, but trunk clang insists.
+ There are also some new warnings; this only fixes the hard errors.
+
+2019-10-03 Tim Horton <timothy_hor...@apple.com>
+
Yet another build fix
* css/typedom/TypedOMCSSImageValue.h:
Modified: trunk/Source/WebCore/Modules/fetch/FetchLoader.h (250660 => 250661)
--- trunk/Source/WebCore/Modules/fetch/FetchLoader.h 2019-10-03 17:45:03 UTC (rev 250660)
+++ trunk/Source/WebCore/Modules/fetch/FetchLoader.h 2019-10-03 17:49:03 UTC (rev 250661)
@@ -43,7 +43,7 @@
class FetchLoader final : public ThreadableLoaderClient {
public:
FetchLoader(FetchLoaderClient&, FetchBodyConsumer*);
- ~FetchLoader();
+ WEBCORE_EXPORT ~FetchLoader();
RefPtr<SharedBuffer> startStreaming();
Modified: trunk/Source/WebCore/Modules/geolocation/Geolocation.h (250660 => 250661)
--- trunk/Source/WebCore/Modules/geolocation/Geolocation.h 2019-10-03 17:45:03 UTC (rev 250660)
+++ trunk/Source/WebCore/Modules/geolocation/Geolocation.h 2019-10-03 17:49:03 UTC (rev 250661)
@@ -52,7 +52,7 @@
struct PositionOptions;
class Geolocation final : public ScriptWrappable, public RefCounted<Geolocation>, public ActiveDOMObject {
- WTF_MAKE_ISO_ALLOCATED(Geolocation);
+ WTF_MAKE_ISO_ALLOCATED_EXPORT(Geolocation, WEBCORE_EXPORT);
friend class GeoNotifier;
public:
static Ref<Geolocation> create(Navigator&);
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBTransaction.h (250660 => 250661)
--- trunk/Source/WebCore/Modules/indexeddb/IDBTransaction.h 2019-10-03 17:45:03 UTC (rev 250660)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBTransaction.h 2019-10-03 17:49:03 UTC (rev 250661)
@@ -66,12 +66,12 @@
}
class IDBTransaction final : public ThreadSafeRefCounted<IDBTransaction>, public EventTargetWithInlineData, public IDBActiveDOMObject {
- WTF_MAKE_ISO_ALLOCATED(IDBTransaction);
+ WTF_MAKE_ISO_ALLOCATED_EXPORT(IDBTransaction, WEBCORE_EXPORT);
public:
static Ref<IDBTransaction> create(IDBDatabase&, const IDBTransactionInfo&);
static Ref<IDBTransaction> create(IDBDatabase&, const IDBTransactionInfo&, IDBOpenDBRequest&);
- ~IDBTransaction() final;
+ WEBCORE_EXPORT ~IDBTransaction() final;
// IDBTransaction IDL
Ref<DOMStringList> objectStoreNames() const;
Modified: trunk/Source/WebCore/Modules/indexeddb/shared/InProcessIDBServer.cpp (250660 => 250661)
--- trunk/Source/WebCore/Modules/indexeddb/shared/InProcessIDBServer.cpp 2019-10-03 17:45:03 UTC (rev 250660)
+++ trunk/Source/WebCore/Modules/indexeddb/shared/InProcessIDBServer.cpp 2019-10-03 17:49:03 UTC (rev 250661)
@@ -59,6 +59,8 @@
return server;
}
+InProcessIDBServer::~InProcessIDBServer() = default;
+
StorageQuotaManager* InProcessIDBServer::quotaManager(const ClientOrigin& origin)
{
return m_quotaManagers.ensure(origin, [] {
Modified: trunk/Source/WebCore/Modules/indexeddb/shared/InProcessIDBServer.h (250660 => 250661)
--- trunk/Source/WebCore/Modules/indexeddb/shared/InProcessIDBServer.h 2019-10-03 17:45:03 UTC (rev 250660)
+++ trunk/Source/WebCore/Modules/indexeddb/shared/InProcessIDBServer.h 2019-10-03 17:49:03 UTC (rev 250661)
@@ -59,6 +59,8 @@
WEBCORE_EXPORT static Ref<InProcessIDBServer> create(PAL::SessionID);
WEBCORE_EXPORT static Ref<InProcessIDBServer> create(PAL::SessionID, const String& databaseDirectoryPath);
+ WEBCORE_EXPORT virtual ~InProcessIDBServer();
+
WEBCORE_EXPORT IDBClient::IDBConnectionToServer& connectionToServer() const;
IDBServer::IDBConnectionToClient& connectionToClient() const;
IDBServer::IDBServer& server() { return m_server.get(); }
Modified: trunk/Source/WebCore/Modules/notifications/Notification.cpp (250660 => 250661)
--- trunk/Source/WebCore/Modules/notifications/Notification.cpp 2019-10-03 17:45:03 UTC (rev 250660)
+++ trunk/Source/WebCore/Modules/notifications/Notification.cpp 2019-10-03 17:49:03 UTC (rev 250661)
@@ -74,7 +74,7 @@
m_taskTimer->startOneShot(0_s);
}
-Notification::~Notification() = default;
+Notification::~Notification() = default;
void Notification::show()
{
Modified: trunk/Source/WebCore/Modules/notifications/Notification.h (250660 => 250661)
--- trunk/Source/WebCore/Modules/notifications/Notification.h 2019-10-03 17:45:03 UTC (rev 250660)
+++ trunk/Source/WebCore/Modules/notifications/Notification.h 2019-10-03 17:49:03 UTC (rev 250661)
@@ -47,7 +47,7 @@
class NotificationPermissionCallback;
class Notification final : public RefCounted<Notification>, public ActiveDOMObject, public EventTargetWithInlineData {
- WTF_MAKE_ISO_ALLOCATED(Notification);
+ WTF_MAKE_ISO_ALLOCATED_EXPORT(Notification, WEBCORE_EXPORT);
public:
using Permission = NotificationPermission;
using Direction = NotificationDirection;
@@ -61,7 +61,7 @@
};
static Ref<Notification> create(Document&, const String& title, const Options&);
- virtual ~Notification();
+ WEBCORE_EXPORT virtual ~Notification();
void show();
void close();
Modified: trunk/Source/WebCore/platform/graphics/ca/TileController.h (250660 => 250661)
--- trunk/Source/WebCore/platform/graphics/ca/TileController.h 2019-10-03 17:45:03 UTC (rev 250660)
+++ trunk/Source/WebCore/platform/graphics/ca/TileController.h 2019-10-03 17:49:03 UTC (rev 250661)
@@ -56,7 +56,7 @@
friend class TileGrid;
public:
WEBCORE_EXPORT explicit TileController(PlatformCALayer*);
- ~TileController();
+ WEBCORE_EXPORT ~TileController();
WEBCORE_EXPORT static String tileGridContainerLayerName();
static String zoomedOutTileGridContainerLayerName();
Modified: trunk/Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.h (250660 => 250661)
--- trunk/Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.h 2019-10-03 17:45:03 UTC (rev 250660)
+++ trunk/Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.h 2019-10-03 17:49:03 UTC (rev 250661)
@@ -55,7 +55,7 @@
{
return adoptRef(*new ServiceWorkerThreadProxy(std::forward<Args>(args)...));
}
- ~ServiceWorkerThreadProxy();
+ WEBCORE_EXPORT ~ServiceWorkerThreadProxy();
ServiceWorkerIdentifier identifier() const { return m_serviceWorkerThread->identifier(); }
ServiceWorkerThread& thread() { return m_serviceWorkerThread.get(); }
