Title: [250958] trunk/Source/WebCore
- Revision
- 250958
- Author
- [email protected]
- Date
- 2019-10-10 00:44:40 -0700 (Thu, 10 Oct 2019)
Log Message
Add asserts to MediaStreamPrivate observer routines
https://bugs.webkit.org/show_bug.cgi?id=202724
Reviewed by Alex Christensen.
These methods are only to be called in main thread.
Add asserts to validate this.
No change of behavior.
* platform/mediastream/MediaStreamPrivate.cpp:
(WebCore::MediaStreamPrivate::addObserver):
(WebCore::MediaStreamPrivate::removeObserver):
(WebCore::MediaStreamPrivate::forEachObserver const):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (250957 => 250958)
--- trunk/Source/WebCore/ChangeLog 2019-10-10 06:59:13 UTC (rev 250957)
+++ trunk/Source/WebCore/ChangeLog 2019-10-10 07:44:40 UTC (rev 250958)
@@ -1,3 +1,19 @@
+2019-10-10 youenn fablet <[email protected]>
+
+ Add asserts to MediaStreamPrivate observer routines
+ https://bugs.webkit.org/show_bug.cgi?id=202724
+
+ Reviewed by Alex Christensen.
+
+ These methods are only to be called in main thread.
+ Add asserts to validate this.
+ No change of behavior.
+
+ * platform/mediastream/MediaStreamPrivate.cpp:
+ (WebCore::MediaStreamPrivate::addObserver):
+ (WebCore::MediaStreamPrivate::removeObserver):
+ (WebCore::MediaStreamPrivate::forEachObserver const):
+
2019-10-09 youenn fablet <[email protected]>
A service worker process should not be created when enqueuing a service worker job
Modified: trunk/Source/WebCore/platform/mediastream/MediaStreamPrivate.cpp (250957 => 250958)
--- trunk/Source/WebCore/platform/mediastream/MediaStreamPrivate.cpp 2019-10-10 06:59:13 UTC (rev 250957)
+++ trunk/Source/WebCore/platform/mediastream/MediaStreamPrivate.cpp 2019-10-10 07:44:40 UTC (rev 250958)
@@ -91,16 +91,19 @@
void MediaStreamPrivate::addObserver(MediaStreamPrivate::Observer& observer)
{
+ RELEASE_ASSERT(isMainThread());
m_observers.add(&observer);
}
void MediaStreamPrivate::removeObserver(MediaStreamPrivate::Observer& observer)
{
+ RELEASE_ASSERT(isMainThread());
m_observers.remove(&observer);
}
void MediaStreamPrivate::forEachObserver(const WTF::Function<void(Observer&)>& apply) const
{
+ RELEASE_ASSERT(isMainThread());
for (auto* observer : copyToVector(m_observers)) {
if (!m_observers.contains(observer))
continue;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
