Title: [250995] trunk/JSTests
- Revision
- 250995
- Author
- [email protected]
- Date
- 2019-10-10 16:44:01 -0700 (Thu, 10 Oct 2019)
Log Message
Modify JSTests/stress/string-overflow-createError-*.js tests to allow an OOME result.
https://bugs.webkit.org/show_bug.cgi?id=202828
Reviewed by Yusuke Suzuki.
The tests intentionally allocate a very large string. Hence, for some memory
limited configurations, it is perfectly reasonable for the test to throw an Out
Of Memory error.
* stress/string-overflow-createError-builder.js:
* stress/string-overflow-createError-fit.js:
Modified Paths
Diff
Modified: trunk/JSTests/ChangeLog (250994 => 250995)
--- trunk/JSTests/ChangeLog 2019-10-10 22:28:39 UTC (rev 250994)
+++ trunk/JSTests/ChangeLog 2019-10-10 23:44:01 UTC (rev 250995)
@@ -1,3 +1,17 @@
+2019-10-10 Mark Lam <[email protected]>
+
+ Modify JSTests/stress/string-overflow-createError-*.js tests to allow an OOME result.
+ https://bugs.webkit.org/show_bug.cgi?id=202828
+
+ Reviewed by Yusuke Suzuki.
+
+ The tests intentionally allocate a very large string. Hence, for some memory
+ limited configurations, it is perfectly reasonable for the test to throw an Out
+ Of Memory error.
+
+ * stress/string-overflow-createError-builder.js:
+ * stress/string-overflow-createError-fit.js:
+
2019-10-09 Yusuke Suzuki <[email protected]>
Unreviewed, roll out r250878
Modified: trunk/JSTests/stress/string-overflow-createError-builder.js (250994 => 250995)
--- trunk/JSTests/stress/string-overflow-createError-builder.js 2019-10-10 22:28:39 UTC (rev 250994)
+++ trunk/JSTests/stress/string-overflow-createError-builder.js 2019-10-10 23:44:01 UTC (rev 250995)
@@ -11,5 +11,6 @@
// when the StringBuilder for the error message overflows,
// "object is not a function" is used as message for the TypeError.
-if (exception.message != "object is not a function.")
+if (exception.message != "object is not a function."
+ && exception != "Error: Out of memory")
throw "FAILED";
Modified: trunk/JSTests/stress/string-overflow-createError-fit.js (250994 => 250995)
--- trunk/JSTests/stress/string-overflow-createError-fit.js 2019-10-10 22:28:39 UTC (rev 250994)
+++ trunk/JSTests/stress/string-overflow-createError-fit.js 2019-10-10 23:44:01 UTC (rev 250995)
@@ -12,5 +12,6 @@
// Although the message of the TypeError is quite long,
// it still fits into String::MaxLength. Check the start
// of the error message.
-if (!exception.message.startsWith("foo is not a function"))
+if (!exception.message.startsWith("foo is not a function")
+ && exception != "Error: Out of memory")
throw "FAILED";
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
