Title: [251002] trunk/Source/WebKit
Revision
251002
Author
commit-qu...@webkit.org
Date
2019-10-10 23:59:35 -0700 (Thu, 10 Oct 2019)

Log Message

Remove unused WebProcessPool::requestNetworkingStatistics
https://bugs.webkit.org/show_bug.cgi?id=202818

Patch by Alex Christensen <achristen...@webkit.org> on 2019-10-10
Reviewed by Chris Dumez.

Its only use was removed in rdar://problem/56160996

* NetworkProcess/Downloads/DownloadManager.h:
(WebKit::DownloadManager::isDownloading const):
(WebKit::DownloadManager::activeDownloadCount const): Deleted.
* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::getNetworkProcessStatistics): Deleted.
* NetworkProcess/NetworkProcess.h:
* NetworkProcess/NetworkProcess.messages.in:
* Shared/Authentication/AuthenticationManager.h:
(WebKit::AuthenticationManager::outstandingAuthenticationChallengeCount const): Deleted.
* UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::didReceiveMessage):
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::getStatistics):
(WebKit::WebProcessPool::requestNetworkingStatistics): Deleted.
* UIProcess/WebProcessPool.h:

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (251001 => 251002)


--- trunk/Source/WebKit/ChangeLog	2019-10-11 05:18:34 UTC (rev 251001)
+++ trunk/Source/WebKit/ChangeLog	2019-10-11 06:59:35 UTC (rev 251002)
@@ -1,3 +1,28 @@
+2019-10-10  Alex Christensen  <achristen...@webkit.org>
+
+        Remove unused WebProcessPool::requestNetworkingStatistics
+        https://bugs.webkit.org/show_bug.cgi?id=202818
+
+        Reviewed by Chris Dumez.
+
+        Its only use was removed in rdar://problem/56160996
+
+        * NetworkProcess/Downloads/DownloadManager.h:
+        (WebKit::DownloadManager::isDownloading const):
+        (WebKit::DownloadManager::activeDownloadCount const): Deleted.
+        * NetworkProcess/NetworkProcess.cpp:
+        (WebKit::NetworkProcess::getNetworkProcessStatistics): Deleted.
+        * NetworkProcess/NetworkProcess.h:
+        * NetworkProcess/NetworkProcess.messages.in:
+        * Shared/Authentication/AuthenticationManager.h:
+        (WebKit::AuthenticationManager::outstandingAuthenticationChallengeCount const): Deleted.
+        * UIProcess/Network/NetworkProcessProxy.cpp:
+        (WebKit::NetworkProcessProxy::didReceiveMessage):
+        * UIProcess/WebProcessPool.cpp:
+        (WebKit::WebProcessPool::getStatistics):
+        (WebKit::WebProcessPool::requestNetworkingStatistics): Deleted.
+        * UIProcess/WebProcessPool.h:
+
 2019-10-10  Basuke Suzuki  <basuke.suz...@sony.com>
 
         [WinCairo] Move remote communication handling from RemoteInspectorServer to RemoteInspector.

Modified: trunk/Source/WebKit/NetworkProcess/Downloads/DownloadManager.h (251001 => 251002)


--- trunk/Source/WebKit/NetworkProcess/Downloads/DownloadManager.h	2019-10-11 05:18:34 UTC (rev 251001)
+++ trunk/Source/WebKit/NetworkProcess/Downloads/DownloadManager.h	2019-10-11 06:59:35 UTC (rev 251002)
@@ -98,7 +98,6 @@
 
     void downloadFinished(Download&);
     bool isDownloading() const { return !m_downloads.isEmpty(); }
-    uint64_t activeDownloadCount() const { return m_downloads.size(); }
 
     void applicationDidEnterBackground();
     void applicationWillEnterForeground();

Modified: trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp (251001 => 251002)


--- trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp	2019-10-11 05:18:34 UTC (rev 251001)
+++ trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp	2019-10-11 06:59:35 UTC (rev 251002)
@@ -2020,16 +2020,6 @@
     });
 }
 
-void NetworkProcess::getNetworkProcessStatistics(uint64_t callbackID)
-{
-    StatisticsData data;
-
-    data.statisticsNumbers.set("DownloadsActiveCount", downloadManager().activeDownloadCount());
-    data.statisticsNumbers.set("OutstandingAuthenticationChallengesCount", authenticationManager().outstandingAuthenticationChallengeCount());
-
-    parentProcessConnection()->send(Messages::WebProcessPool::DidGetStatistics(data, callbackID), 0);
-}
-
 void NetworkProcess::setAllowsAnySSLCertificateForWebSocket(bool allows, CompletionHandler<void()>&& completionHandler)
 {
     DeprecatedGlobalSettings::setAllowsAnySSLCertificate(allows);

Modified: trunk/Source/WebKit/NetworkProcess/NetworkProcess.h (251001 => 251002)


--- trunk/Source/WebKit/NetworkProcess/NetworkProcess.h	2019-10-11 05:18:34 UTC (rev 251001)
+++ trunk/Source/WebKit/NetworkProcess/NetworkProcess.h	2019-10-11 06:59:35 UTC (rev 251002)
@@ -417,7 +417,6 @@
 
     void setCacheModel(CacheModel, String overrideCacheStorageDirectory);
     void allowSpecificHTTPSCertificateForHost(const WebCore::CertificateInfo&, const String& host);
-    void getNetworkProcessStatistics(uint64_t callbackID);
     void clearCacheForAllOrigins(uint32_t cachesToClear);
     void setAllowsAnySSLCertificateForWebSocket(bool, CompletionHandler<void()>&&);
     

Modified: trunk/Source/WebKit/NetworkProcess/NetworkProcess.messages.in (251001 => 251002)


--- trunk/Source/WebKit/NetworkProcess/NetworkProcess.messages.in	2019-10-11 05:18:34 UTC (rev 251001)
+++ trunk/Source/WebKit/NetworkProcess/NetworkProcess.messages.in	2019-10-11 06:59:35 UTC (rev 251002)
@@ -68,8 +68,6 @@
 
     AllowSpecificHTTPSCertificateForHost(WebCore::CertificateInfo certificate, String host)
     
-    GetNetworkProcessStatistics(uint64_t callbackID)
-    
     ClearCacheForAllOrigins(uint32_t cachesToClear)
     SetCacheModel(enum:uint8_t WebKit::CacheModel cacheModel, String overrideCacheStorageDirectory);
 

Modified: trunk/Source/WebKit/Shared/Authentication/AuthenticationManager.h (251001 => 251002)


--- trunk/Source/WebKit/Shared/Authentication/AuthenticationManager.h	2019-10-11 05:18:34 UTC (rev 251001)
+++ trunk/Source/WebKit/Shared/Authentication/AuthenticationManager.h	2019-10-11 06:59:35 UTC (rev 251002)
@@ -74,8 +74,6 @@
 
     void completeAuthenticationChallenge(uint64_t challengeID, AuthenticationChallengeDisposition, WebCore::Credential&&);
 
-    uint64_t outstandingAuthenticationChallengeCount() const { return m_challenges.size(); }
-
 private:
     struct Challenge {
         WebPageProxyIdentifier pageID;

Modified: trunk/Source/WebKit/UIProcess/WebProcessPool.cpp (251001 => 251002)


--- trunk/Source/WebKit/UIProcess/WebProcessPool.cpp	2019-10-11 05:18:34 UTC (rev 251001)
+++ trunk/Source/WebKit/UIProcess/WebProcessPool.cpp	2019-10-11 06:59:35 UTC (rev 251002)
@@ -1801,9 +1801,6 @@
 
     if (statisticsMask & StatisticsRequestTypeWebContent)
         requestWebContentStatistics(request.get());
-    
-    if (statisticsMask & StatisticsRequestTypeNetworking)
-        requestNetworkingStatistics(request.get());
 }
 
 void WebProcessPool::requestWebContentStatistics(StatisticsRequest& request)
@@ -1811,18 +1808,6 @@
     // FIXME (Multi-WebProcess) <rdar://problem/13200059>: Make getting statistics from multiple WebProcesses work.
 }
 
-void WebProcessPool::requestNetworkingStatistics(StatisticsRequest& request)
-{
-    if (!m_networkProcess) {
-        LOG_ERROR("Attempt to get NetworkProcess statistics but the NetworkProcess is unavailable");
-        return;
-    }
-
-    uint64_t requestID = request.addOutstandingRequest();
-    m_statisticsRequests.set(requestID, &request);
-    m_networkProcess->send(Messages::NetworkProcess::GetNetworkProcessStatistics(requestID), 0);
-}
-
 static WebProcessProxy* webProcessProxyFromConnection(IPC::Connection& connection, const Vector<RefPtr<WebProcessProxy>>& processes)
 {
     for (auto& process : processes) {

Modified: trunk/Source/WebKit/UIProcess/WebProcessPool.h (251001 => 251002)


--- trunk/Source/WebKit/UIProcess/WebProcessPool.h	2019-10-11 05:18:34 UTC (rev 251001)
+++ trunk/Source/WebKit/UIProcess/WebProcessPool.h	2019-10-11 06:59:35 UTC (rev 251002)
@@ -541,7 +541,6 @@
     void initializeNewWebProcess(WebProcessProxy&, WebsiteDataStore*, WebProcessProxy::IsPrewarmed = WebProcessProxy::IsPrewarmed::No);
 
     void requestWebContentStatistics(StatisticsRequest&);
-    void requestNetworkingStatistics(StatisticsRequest&);
 
     void platformInitializeNetworkProcess(NetworkProcessCreationParameters&);
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to