Title: [251005] trunk
- Revision
- 251005
- Author
- annu...@yandex.ru
- Date
- 2019-10-11 02:04:12 -0700 (Fri, 11 Oct 2019)
Log Message
[cmake] Use HINTS instead of PATHS when searching in paths from pkg-config
https://bugs.webkit.org/show_bug.cgi?id=202831
Reviewed by Carlos Garcia Campos.
HINTS and PATHS sections are similar, however HINTS is processed before
default system locations, while PATHS - after. If target file can be found
in the system, pkg-config results are ignored in case of PATHS, making it
impossible to override system version of library with PKG_CONFIG_PATH.
Note that CMake documentation recommends using PATHS for hard-coded guesses.
* Source/cmake/FindEnchant.cmake:
* Source/cmake/FindFontconfig.cmake:
* Source/cmake/FindLibEpoxy.cmake:
* Source/cmake/FindLibtasn1.cmake:
* Source/cmake/FindSqlite.cmake:
Modified Paths
Diff
Modified: trunk/ChangeLog (251004 => 251005)
--- trunk/ChangeLog 2019-10-11 08:53:41 UTC (rev 251004)
+++ trunk/ChangeLog 2019-10-11 09:04:12 UTC (rev 251005)
@@ -1,3 +1,23 @@
+2019-10-11 Konstantin Tokarev <annu...@yandex.ru>
+
+ [cmake] Use HINTS instead of PATHS when searching in paths from pkg-config
+ https://bugs.webkit.org/show_bug.cgi?id=202831
+
+ Reviewed by Carlos Garcia Campos.
+
+ HINTS and PATHS sections are similar, however HINTS is processed before
+ default system locations, while PATHS - after. If target file can be found
+ in the system, pkg-config results are ignored in case of PATHS, making it
+ impossible to override system version of library with PKG_CONFIG_PATH.
+
+ Note that CMake documentation recommends using PATHS for hard-coded guesses.
+
+ * Source/cmake/FindEnchant.cmake:
+ * Source/cmake/FindFontconfig.cmake:
+ * Source/cmake/FindLibEpoxy.cmake:
+ * Source/cmake/FindLibtasn1.cmake:
+ * Source/cmake/FindSqlite.cmake:
+
2019-10-08 Adrian Perez de Castro <ape...@igalia.com>
Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.27.1 release
Modified: trunk/Source/cmake/FindEnchant.cmake (251004 => 251005)
--- trunk/Source/cmake/FindEnchant.cmake 2019-10-11 08:53:41 UTC (rev 251004)
+++ trunk/Source/cmake/FindEnchant.cmake 2019-10-11 09:04:12 UTC (rev 251005)
@@ -37,13 +37,13 @@
find_path(ENCHANT_INCLUDE_DIRS
NAMES enchant.h
- PATHS ${PC_ENCHANT_INCLUDEDIR}
+ HINTS ${PC_ENCHANT_INCLUDEDIR}
${PC_ENCHANT_INCLUDE_DIRS}
)
find_library(ENCHANT_LIBRARIES
NAMES ${ENCHANT_NAME}
- PATHS ${PC_ENCHANT_LIBDIR}
+ HINTS ${PC_ENCHANT_LIBDIR}
${PC_ENCHANT_LIBRARY_DIRS}
)
Modified: trunk/Source/cmake/FindFontconfig.cmake (251004 => 251005)
--- trunk/Source/cmake/FindFontconfig.cmake 2019-10-11 08:53:41 UTC (rev 251004)
+++ trunk/Source/cmake/FindFontconfig.cmake 2019-10-11 09:04:12 UTC (rev 251005)
@@ -49,16 +49,12 @@
endif (NOT WIN32)
find_path(FONTCONFIG_INCLUDE_DIR fontconfig/fontconfig.h
- PATHS
- ${PC_FONTCONFIG_INCLUDEDIR}
- ${PC_FONTCONFIG_INCLUDE_DIRS}
- /usr/X11/include
+ HINTS ${PC_FONTCONFIG_INCLUDEDIR} ${PC_FONTCONFIG_INCLUDE_DIRS}
+ PATHS /usr/X11/include
)
find_library(FONTCONFIG_LIBRARIES NAMES fontconfig
- PATHS
- ${PC_FONTCONFIG_LIBDIR}
- ${PC_FONTCONFIG_LIBRARY_DIRS}
+ HINTS ${PC_FONTCONFIG_LIBDIR} ${PC_FONTCONFIG_LIBRARY_DIRS}
)
include(FindPackageHandleStandardArgs)
Modified: trunk/Source/cmake/FindLibEpoxy.cmake (251004 => 251005)
--- trunk/Source/cmake/FindLibEpoxy.cmake 2019-10-11 08:53:41 UTC (rev 251004)
+++ trunk/Source/cmake/FindLibEpoxy.cmake 2019-10-11 09:04:12 UTC (rev 251005)
@@ -36,12 +36,12 @@
find_path(LIBEPOXY_INCLUDE_DIRS
NAMES epoxy/gl.h
- PATHS ${PC_LIBEPOXY_INCLUDEDIR} ${PC_LIBEPOXY_INCLUDE_DIRS}
+ HINTS ${PC_LIBEPOXY_INCLUDEDIR} ${PC_LIBEPOXY_INCLUDE_DIRS}
)
find_library(LIBEPOXY_LIBRARIES
NAMES epoxy
- PATHS ${PC_LIBEPOXY_LIBDIR} ${PC_LIBEPOXY_LIBRARY_DIRS}
+ HINTS ${PC_LIBEPOXY_LIBDIR} ${PC_LIBEPOXY_LIBRARY_DIRS}
)
mark_as_advanced(LIBEPOXY_INCLUDE_DIRS LIBEPOXY_LIBRARIES)
Modified: trunk/Source/cmake/FindLibtasn1.cmake (251004 => 251005)
--- trunk/Source/cmake/FindLibtasn1.cmake 2019-10-11 08:53:41 UTC (rev 251004)
+++ trunk/Source/cmake/FindLibtasn1.cmake 2019-10-11 09:04:12 UTC (rev 251005)
@@ -33,12 +33,12 @@
find_path(LIBTASN1_INCLUDE_DIRS
NAMES libtasn1.h
- PATHS ${PC_LIBTASN1_INCLUDEDIR} ${PC_LIBTASN1_INCLUDE_DIRS}
+ HINTS ${PC_LIBTASN1_INCLUDEDIR} ${PC_LIBTASN1_INCLUDE_DIRS}
)
find_library(LIBTASN1_LIBRARIES
NAMES tasn1
- PATHS ${PC_LIBTASN1_LIBDIR} ${PC_LIBTASN1_LIBRARY_DIRS}
+ HINTS ${PC_LIBTASN1_LIBDIR} ${PC_LIBTASN1_LIBRARY_DIRS}
)
include(FindPackageHandleStandardArgs)
Modified: trunk/Source/cmake/FindSqlite.cmake (251004 => 251005)
--- trunk/Source/cmake/FindSqlite.cmake 2019-10-11 08:53:41 UTC (rev 251004)
+++ trunk/Source/cmake/FindSqlite.cmake 2019-10-11 09:04:12 UTC (rev 251005)
@@ -47,15 +47,11 @@
endif (NOT WIN32)
find_path(SQLITE_INCLUDE_DIR NAMES sqlite3.h
- PATHS
- ${PC_SQLITE_INCLUDEDIR}
- ${PC_SQLITE_INCLUDE_DIRS}
+ HINTS ${PC_SQLITE_INCLUDEDIR} ${PC_SQLITE_INCLUDE_DIRS}
)
find_library(SQLITE_LIBRARIES NAMES sqlite3
- PATHS
- ${PC_SQLITE_LIBDIR}
- ${PC_SQLITE_LIBRARY_DIRS}
+ HINTS ${PC_SQLITE_LIBDIR} ${PC_SQLITE_LIBRARY_DIRS}
)
include(FindPackageHandleStandardArgs)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes