Title: [103147] trunk/Source/WebKit/chromium
- Revision
- 103147
- Author
- [email protected]
- Date
- 2011-12-17 09:10:41 -0800 (Sat, 17 Dec 2011)
Log Message
[Chromium] Implement PluginViewBase::getFormValue
https://bugs.webkit.org/show_bug.cgi?id=64434
Reviewed by Darin Fisher.
This patch was landed as r102873, but reverted because of Chromium Mac build failure.
The fix was landed as Chromium r114920. The patch should be safe to land.
No new tests. No behavior change at this time. We should add a test for PPAPI after chromium supports the feature.
* public/WebPlugin.h: Added getFormValue().
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::getFormValue): Added.
* src/WebPluginContainerImpl.h: Added getFormValue().
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (103146 => 103147)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-12-17 13:07:12 UTC (rev 103146)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-12-17 17:10:41 UTC (rev 103147)
@@ -1,3 +1,20 @@
+2011-12-17 Kenichi Ishibashi <[email protected]>
+
+ [Chromium] Implement PluginViewBase::getFormValue
+ https://bugs.webkit.org/show_bug.cgi?id=64434
+
+ Reviewed by Darin Fisher.
+
+ This patch was landed as r102873, but reverted because of Chromium Mac build failure.
+ The fix was landed as Chromium r114920. The patch should be safe to land.
+
+ No new tests. No behavior change at this time. We should add a test for PPAPI after chromium supports the feature.
+
+ * public/WebPlugin.h: Added getFormValue().
+ * src/WebPluginContainerImpl.cpp:
+ (WebKit::WebPluginContainerImpl::getFormValue): Added.
+ * src/WebPluginContainerImpl.h: Added getFormValue().
+
2011-12-16 James Robinson <[email protected]>
[chromium] CCLayerDelegate and WebLayerClient do not need notifySyncRequired
Modified: trunk/Source/WebKit/chromium/public/WebPlugin.h (103146 => 103147)
--- trunk/Source/WebKit/chromium/public/WebPlugin.h 2011-12-17 13:07:12 UTC (rev 103146)
+++ trunk/Source/WebKit/chromium/public/WebPlugin.h 2011-12-17 17:10:41 UTC (rev 103147)
@@ -58,6 +58,11 @@
virtual NPObject* scriptableObject() = 0;
+ // Returns true if the form submission value is successfully obtained
+ // from the plugin. The value would be associated with the name attribute
+ // of the corresponding object element.
+ virtual bool getFormValue(WebString&) { return false; }
+
virtual void paint(WebCanvas*, const WebRect&) = 0;
// Coordinates are relative to the containing window.
Modified: trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp (103146 => 103147)
--- trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp 2011-12-17 13:07:12 UTC (rev 103146)
+++ trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp 2011-12-17 17:10:41 UTC (rev 103147)
@@ -464,6 +464,16 @@
return m_webPlugin->scriptableObject();
}
+bool WebPluginContainerImpl::getFormValue(String& value)
+{
+ WebString webValue;
+ if (m_webPlugin->getFormValue(webValue)) {
+ value = webValue;
+ return true;
+ }
+ return false;
+}
+
void WebPluginContainerImpl::willDestroyPluginLoadObserver(WebPluginLoadObserver* observer)
{
size_t pos = m_pluginLoadObservers.find(observer);
Modified: trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.h (103146 => 103147)
--- trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.h 2011-12-17 13:07:12 UTC (rev 103146)
+++ trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.h 2011-12-17 17:10:41 UTC (rev 103147)
@@ -38,6 +38,7 @@
#include <wtf/OwnPtr.h>
#include <wtf/PassRefPtr.h>
#include <wtf/Vector.h>
+#include <wtf/text/WTFString.h>
struct NPObject;
@@ -70,6 +71,9 @@
return adoptRef(new WebPluginContainerImpl(element, webPlugin));
}
+ // PluginViewBase methods
+ virtual bool getFormValue(String&);
+
// Widget methods
virtual void setFrameRect(const WebCore::IntRect&);
virtual void paint(WebCore::GraphicsContext*, const WebCore::IntRect&);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
