Title: [251026] trunk/LayoutTests
- Revision
- 251026
- Author
- [email protected]
- Date
- 2019-10-11 14:45:36 -0700 (Fri, 11 Oct 2019)
Log Message
Layout Test fast/events/touch/ios/tap-with-passive-listener-inside-active-listener.html is a Flaky Failure
https://bugs.webkit.org/show_bug.cgi?id=202867
<rdar://52968736>
Reviewed by Wenson Hsieh.
>From the failing results, it looks like the event listener for touchend was firing
after the uiScriptController returned its result, which is strange.
I was unable to reproduce this, so I rewrote the test to use UIHelper, which
hopefully will improve the situation (although... is basically the same code).
* fast/events/touch/ios/tap-with-passive-listener-inside-active-listener-expected.txt:
* fast/events/touch/ios/tap-with-passive-listener-inside-active-listener.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (251025 => 251026)
--- trunk/LayoutTests/ChangeLog 2019-10-11 21:26:47 UTC (rev 251025)
+++ trunk/LayoutTests/ChangeLog 2019-10-11 21:45:36 UTC (rev 251026)
@@ -1,3 +1,19 @@
+2019-10-11 Dean Jackson <[email protected]>
+
+ Layout Test fast/events/touch/ios/tap-with-passive-listener-inside-active-listener.html is a Flaky Failure
+ https://bugs.webkit.org/show_bug.cgi?id=202867
+ <rdar://52968736>
+
+ Reviewed by Wenson Hsieh.
+
+ From the failing results, it looks like the event listener for touchend was firing
+ after the uiScriptController returned its result, which is strange.
+ I was unable to reproduce this, so I rewrote the test to use UIHelper, which
+ hopefully will improve the situation (although... is basically the same code).
+
+ * fast/events/touch/ios/tap-with-passive-listener-inside-active-listener-expected.txt:
+ * fast/events/touch/ios/tap-with-passive-listener-inside-active-listener.html:
+
2019-10-10 Joseph Pecoraro <[email protected]>
Web Inspector: Local Resource Overrides: UI for overriding image and font resource content
Modified: trunk/LayoutTests/fast/events/touch/ios/tap-with-passive-listener-inside-active-listener-expected.txt (251025 => 251026)
--- trunk/LayoutTests/fast/events/touch/ios/tap-with-passive-listener-inside-active-listener-expected.txt 2019-10-11 21:26:47 UTC (rev 251025)
+++ trunk/LayoutTests/fast/events/touch/ios/tap-with-passive-listener-inside-active-listener-expected.txt 2019-10-11 21:45:36 UTC (rev 251026)
@@ -6,7 +6,7 @@
Listener target1 received cancelable event touchend targetting eventTarget1
defaultPrevented before preventDefault(): false
defaultPrevented after preventDefault(): true
-Done
+
Tap on Target2 (red)
Listener target1 received cancelable event touchstart targetting eventTarget2 at 150, 50
@@ -15,7 +15,7 @@
Listener target1 received cancelable event touchend targetting eventTarget2
defaultPrevented before preventDefault(): false
defaultPrevented after preventDefault(): true
-Done
+
Tap on Target3 (blue)
Listener target3 received cancelable event touchstart targetting eventTarget3 at 250, 50
Modified: trunk/LayoutTests/fast/events/touch/ios/tap-with-passive-listener-inside-active-listener.html (251025 => 251026)
--- trunk/LayoutTests/fast/events/touch/ios/tap-with-passive-listener-inside-active-listener.html 2019-10-11 21:26:47 UTC (rev 251025)
+++ trunk/LayoutTests/fast/events/touch/ios/tap-with-passive-listener-inside-active-listener.html 2019-10-11 21:45:36 UTC (rev 251026)
@@ -2,6 +2,7 @@
<html>
<head>
+ <script src=""
<script>
if (window.testRunner) {
testRunner.dumpAsText();
@@ -8,18 +9,8 @@
testRunner.waitUntilDone();
}
- function getUIScript(x, y)
+ async function runTest()
{
- return `
- (function() {
- uiController.singleTapAtPoint(${x}, ${y}, function() {
- uiController.uiScriptComplete("Done");
- });
- })();`
- }
-
- function runTest()
- {
if (!testRunner.runUIScript)
return;
@@ -61,18 +52,16 @@
target3.addEventListener('touchcancel', getLogEvent("target3"), { 'passive': true });
output += "<h1>Tap on Target1 (green)</h1>";
- testRunner.runUIScript(getUIScript(50, 50), function(result) {
- output += result;
- output += "<h1>Tap on Target2 (red)</h1>";
- testRunner.runUIScript(getUIScript(150, 50), function(result) {
- output += result;
- output += "<h1>Tap on Target3 (blue)</h1>";
- testRunner.runUIScript(getUIScript(250, 50), function(result) {
- document.getElementById('output').innerHTML = output;
- testRunner.notifyDone();
- });
- });
- });
+ await UIHelper.tapAt(50, 50);
+
+ output += "<br><h1>Tap on Target2 (red)</h1>";
+ await UIHelper.tapAt(150, 50);
+
+ output += "<br><h1>Tap on Target3 (blue)</h1>";
+ await UIHelper.tapAt(250, 50);
+
+ document.getElementById('output').innerHTML = output;
+ testRunner.notifyDone();
}
window.addEventListener('load', runTest, false);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
