Diff
Modified: trunk/Source/WebKitLegacy/win/ChangeLog (251045 => 251046)
--- trunk/Source/WebKitLegacy/win/ChangeLog 2019-10-12 07:57:07 UTC (rev 251045)
+++ trunk/Source/WebKitLegacy/win/ChangeLog 2019-10-12 09:16:39 UTC (rev 251046)
@@ -1,3 +1,22 @@
+2019-10-12 Ryosuke Niwa <[email protected]>
+
+ requestIdleCallback is not enabled in DumpRenderTree on Windows
+ https://bugs.webkit.org/show_bug.cgi?id=202876
+
+ Reviewed by Wenson Hsieh.
+
+ Added the missing plumbing to enable requestIdleCallback.
+
+ * Interfaces/IWebPreferencesPrivate.idl:
+ * WebPreferenceKeysPrivate.h:
+ * WebPreferences.cpp:
+ (WebPreferences::initializeDefaultSettings):
+ (WebPreferences::requestIdleCallbackEnabled):
+ (WebPreferences::setRequestIdleCallbackEnabled):
+ * WebPreferences.h:
+ * WebView.cpp:
+ (WebView::notifyPreferencesChanged):
+
2019-10-04 Alex Christensen <[email protected]>
Rename SchemeRegistry to LegacySchemeRegistry
Modified: trunk/Source/WebKitLegacy/win/Interfaces/IWebPreferencesPrivate.idl (251045 => 251046)
--- trunk/Source/WebKitLegacy/win/Interfaces/IWebPreferencesPrivate.idl 2019-10-12 07:57:07 UTC (rev 251045)
+++ trunk/Source/WebKitLegacy/win/Interfaces/IWebPreferencesPrivate.idl 2019-10-12 09:16:39 UTC (rev 251046)
@@ -244,4 +244,6 @@
HRESULT setResizeObserverEnabled([in] BOOL enabled);
HRESULT coreMathMLEnabled([out, retval] BOOL* enabled);
HRESULT setCoreMathMLEnabled([in] BOOL enabled);
+ HRESULT requestIdleCallbackEnabled([out, retval] BOOL* enabled);
+ HRESULT setRequestIdleCallbackEnabled([in] BOOL enabled);
}
Modified: trunk/Source/WebKitLegacy/win/WebPreferenceKeysPrivate.h (251045 => 251046)
--- trunk/Source/WebKitLegacy/win/WebPreferenceKeysPrivate.h 2019-10-12 07:57:07 UTC (rev 251045)
+++ trunk/Source/WebKitLegacy/win/WebPreferenceKeysPrivate.h 2019-10-12 09:16:39 UTC (rev 251046)
@@ -211,3 +211,5 @@
#define WebKitResizeObserverEnabledPreferenceKey "WebKitResizeObserverEnabled"
#define WebKitCoreMathMLEnabledPreferenceKey "WebKitCoreMathMLEnabled"
+
+#define WebKitRequestIdleCallbackEnabledPreferenceKey "RequestIdleCallbackEnabled"
Modified: trunk/Source/WebKitLegacy/win/WebPreferences.cpp (251045 => 251046)
--- trunk/Source/WebKitLegacy/win/WebPreferences.cpp 2019-10-12 07:57:07 UTC (rev 251045)
+++ trunk/Source/WebKitLegacy/win/WebPreferences.cpp 2019-10-12 09:16:39 UTC (rev 251046)
@@ -339,6 +339,8 @@
CFDictionaryAddValue(defaults, CFSTR(WebKitCoreMathMLEnabledPreferenceKey), kCFBooleanFalse);
+ CFDictionaryAddValue(defaults, CFSTR(WebKitRequestIdleCallbackEnabledPreferenceKey), kCFBooleanFalse);
+
defaultSettings = defaults;
#endif
}
@@ -2277,6 +2279,20 @@
return S_OK;
}
+HRESULT WebPreferences::requestIdleCallbackEnabled(_Out_ BOOL* enabled)
+{
+ if (!enabled)
+ return E_POINTER;
+ *enabled = boolValueForKey(WebKitRequestIdleCallbackEnabledPreferenceKey);
+ return S_OK;
+}
+
+HRESULT WebPreferences::setRequestIdleCallbackEnabled(BOOL enabled)
+{
+ setBoolValue(WebKitRequestIdleCallbackEnabledPreferenceKey, enabled);
+ return S_OK;
+}
+
HRESULT WebPreferences::setApplicationId(BSTR applicationId)
{
#if USE(CF)
Modified: trunk/Source/WebKitLegacy/win/WebPreferences.h (251045 => 251046)
--- trunk/Source/WebKitLegacy/win/WebPreferences.h 2019-10-12 07:57:07 UTC (rev 251045)
+++ trunk/Source/WebKitLegacy/win/WebPreferences.h 2019-10-12 09:16:39 UTC (rev 251046)
@@ -289,6 +289,8 @@
virtual HRESULT STDMETHODCALLTYPE setResizeObserverEnabled(BOOL);
virtual HRESULT STDMETHODCALLTYPE coreMathMLEnabled(_Out_ BOOL*);
virtual HRESULT STDMETHODCALLTYPE setCoreMathMLEnabled(BOOL);
+ virtual HRESULT STDMETHODCALLTYPE requestIdleCallbackEnabled(_Out_ BOOL*);
+ virtual HRESULT STDMETHODCALLTYPE setRequestIdleCallbackEnabled(BOOL);
// WebPreferences
Modified: trunk/Source/WebKitLegacy/win/WebView.cpp (251045 => 251046)
--- trunk/Source/WebKitLegacy/win/WebView.cpp 2019-10-12 07:57:07 UTC (rev 251045)
+++ trunk/Source/WebKitLegacy/win/WebView.cpp 2019-10-12 09:16:39 UTC (rev 251046)
@@ -5609,6 +5609,11 @@
return hr;
settings.setCoreMathMLEnabled(!!enabled);
+ hr = prefsPrivate->requestIdleCallbackEnabled(&enabled);
+ if (FAILED(hr))
+ return hr;
+ settings.setRequestIdleCallbackEnabled(!!enabled);
+
return S_OK;
}
Modified: trunk/Tools/ChangeLog (251045 => 251046)
--- trunk/Tools/ChangeLog 2019-10-12 07:57:07 UTC (rev 251045)
+++ trunk/Tools/ChangeLog 2019-10-12 09:16:39 UTC (rev 251046)
@@ -1,3 +1,15 @@
+2019-10-12 Ryosuke Niwa <[email protected]>
+
+ requestIdleCallback cannot be enabled in DumpRenderTree on Windows
+ https://bugs.webkit.org/show_bug.cgi?id=202876
+
+ Reviewed by Wenson Hsieh.
+
+ Added the missing plumbing for Windows port.
+
+ * DumpRenderTree/win/DumpRenderTree.cpp:
+ (setWebPreferencesForTestOptions):
+
2019-10-11 Aakash Jain <[email protected]>
Update build.webkit.org basedir
Modified: trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp (251045 => 251046)
--- trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp 2019-10-12 07:57:07 UTC (rev 251045)
+++ trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp 2019-10-12 09:16:39 UTC (rev 251046)
@@ -903,7 +903,7 @@
static void setWebPreferencesForTestOptions(IWebPreferences* preferences, const TestOptions& options)
{
- COMPtr<IWebPreferencesPrivate6> prefsPrivate { Query, preferences };
+ COMPtr<IWebPreferencesPrivate7> prefsPrivate { Query, preferences };
prefsPrivate->setWebAnimationsCSSIntegrationEnabled(options.enableWebAnimationsCSSIntegration);
prefsPrivate->setMenuItemElementEnabled(options.enableMenuItemElement);
@@ -911,6 +911,7 @@
prefsPrivate->setModernMediaControlsEnabled(options.enableModernMediaControls);
prefsPrivate->setIsSecureContextAttributeEnabled(options.enableIsSecureContextAttribute);
prefsPrivate->setInspectorAdditionsEnabled(options.enableInspectorAdditions);
+ prefsPrivate->setRequestIdleCallbackEnabled(options.enableRequestIdleCallback);
preferences->setPrivateBrowsingEnabled(options.useEphemeralSession);
preferences->setUsesPageCache(options.enablePageCache);
}
