Title: [251175] trunk/LayoutTests
- Revision
- 251175
- Author
- wenson_hs...@apple.com
- Date
- 2019-10-15 19:06:01 -0700 (Tue, 15 Oct 2019)
Log Message
editing/async-clipboard/clipboard-item-basic.html is a flaky failure on macOS and iOS
https://bugs.webkit.org/show_bug.cgi?id=203015
Reviewed by Tim Horton.
This test, for the most part, finishes and dumps its final output before a couple of (intentionally) rejected
promises finish and log their uncaught rejections to the console. In the case where we lose this race and the
console messages happen earlier, we end up with a text diff failure.
Avoid this issue by making sure that we catch these promise rejections.
* editing/async-clipboard/clipboard-item-basic.html:
Also give this test a tiny bit more variety, by making one of the promises reject immediately, while the other
still waits for a short delay (50 ms).
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (251174 => 251175)
--- trunk/LayoutTests/ChangeLog 2019-10-16 01:49:53 UTC (rev 251174)
+++ trunk/LayoutTests/ChangeLog 2019-10-16 02:06:01 UTC (rev 251175)
@@ -1,3 +1,21 @@
+2019-10-15 Wenson Hsieh <wenson_hs...@apple.com>
+
+ editing/async-clipboard/clipboard-item-basic.html is a flaky failure on macOS and iOS
+ https://bugs.webkit.org/show_bug.cgi?id=203015
+
+ Reviewed by Tim Horton.
+
+ This test, for the most part, finishes and dumps its final output before a couple of (intentionally) rejected
+ promises finish and log their uncaught rejections to the console. In the case where we lose this race and the
+ console messages happen earlier, we end up with a text diff failure.
+
+ Avoid this issue by making sure that we catch these promise rejections.
+
+ * editing/async-clipboard/clipboard-item-basic.html:
+
+ Also give this test a tiny bit more variety, by making one of the promises reject immediately, while the other
+ still waits for a short delay (50 ms).
+
2019-10-15 Carlos Alberto Lopez Perez <clo...@igalia.com>
Import apng testcases from WPT.
Modified: trunk/LayoutTests/editing/async-clipboard/clipboard-item-basic.html (251174 => 251175)
--- trunk/LayoutTests/editing/async-clipboard/clipboard-item-basic.html 2019-10-16 01:49:53 UTC (rev 251174)
+++ trunk/LayoutTests/editing/async-clipboard/clipboard-item-basic.html 2019-10-16 02:06:01 UTC (rev 251175)
@@ -143,8 +143,10 @@
await (async function() {
item = tryToCreateClipboardItem({
"text/plain" : Promise.resolve("璎濊瑵"),
- "text/html" : new Promise((_, reject) => setTimeout(() => reject(imageBlob()), 50)),
- "image/png" : new Promise((_, reject) => setTimeout(() => reject(imageBlob()), 50)),
+ "text/html" : new Promise((_, reject) => {
+ setTimeout(reject, 50);
+ }).catch(() => { }),
+ "image/png" : Promise.reject(imageBlob()).catch(() => { }),
"馃馃馃" : Promise.resolve("诪拽讜专 讛砖诐 注讘专讬转"),
"诪拽讜专 讛砖诐 注讘专讬转" : Promise.resolve("馃馃馃")
});
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
