Title: [251276] trunk/Source/_javascript_Core
- Revision
- 251276
- Author
- hironori.fu...@sony.com
- Date
- 2019-10-18 01:29:51 -0700 (Fri, 18 Oct 2019)
Log Message
[Clang][Windows] Options.cpp(317,25): error: no matching function for call to 'optionTypeSpecificIndex'
https://bugs.webkit.org/show_bug.cgi?id=203142
Unreviewed build fix
clang-cl reported a compilation error for MSVC bug workaround code of optionTypeSpecificIndex.
runtime\Options.cpp(294,12): error: variables defined in a constexpr function must be initialized
size_t index;
^
* runtime/Options.cpp:
(JSC::optionTypeSpecificIndex): Initialize the variable 'index'.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (251275 => 251276)
--- trunk/Source/_javascript_Core/ChangeLog 2019-10-18 05:01:50 UTC (rev 251275)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-10-18 08:29:51 UTC (rev 251276)
@@ -1,3 +1,18 @@
+2019-10-18 Fujii Hironori <hironori.fu...@sony.com>
+
+ [Clang][Windows] Options.cpp(317,25): error: no matching function for call to 'optionTypeSpecificIndex'
+ https://bugs.webkit.org/show_bug.cgi?id=203142
+
+ Unreviewed build fix
+
+ clang-cl reported a compilation error for MSVC bug workaround code of optionTypeSpecificIndex.
+
+ runtime\Options.cpp(294,12): error: variables defined in a constexpr function must be initialized
+ size_t index;
+ ^
+ * runtime/Options.cpp:
+ (JSC::optionTypeSpecificIndex): Initialize the variable 'index'.
+
2019-10-17 Mark Lam <mark....@apple.com>
Add missing checks after calls to the sameValue() JSValue comparator.
Modified: trunk/Source/_javascript_Core/runtime/Options.cpp (251275 => 251276)
--- trunk/Source/_javascript_Core/runtime/Options.cpp 2019-10-18 05:01:50 UTC (rev 251275)
+++ trunk/Source/_javascript_Core/runtime/Options.cpp 2019-10-18 08:29:51 UTC (rev 251276)
@@ -291,7 +291,7 @@
template<OptionTypeID type, OptionID id>
constexpr size_t optionTypeSpecificIndex()
{
- size_t index;
+ size_t index = 0;
index = 0; // MSVC (16.3.5) improperly optimizes away the inline initialization of index, so use an explicit assignment.
#define COUNT_INDEX_AND_FIND_MATCH(type_, name_, defaultValue_, availability_, description_) \
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
