Title: [251557] trunk/LayoutTests
Revision
251557
Author
commit-qu...@webkit.org
Date
2019-10-24 13:48:18 -0700 (Thu, 24 Oct 2019)

Log Message

[Web Animations] Fix compositing/backing/transform-transition-from-outside-view.html
https://bugs.webkit.org/show_bug.cgi?id=184566

Patch by Antoine Quint <grao...@apple.com> on 2019-10-24
Reviewed by Simon Fraser.

For the most part this is the same fix that Simon Fraser made to address 184611 in r251412 although here I also
changed the setTimeout call to requestAnimationFrame in order to ensure that the backing store bit was set in the
layer dump for WK1.

* TestExpectations:
* compositing/backing/transform-transition-from-outside-view.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (251556 => 251557)


--- trunk/LayoutTests/ChangeLog	2019-10-24 20:27:38 UTC (rev 251556)
+++ trunk/LayoutTests/ChangeLog	2019-10-24 20:48:18 UTC (rev 251557)
@@ -1,3 +1,17 @@
+2019-10-24  Antoine Quint  <grao...@apple.com>
+
+        [Web Animations] Fix compositing/backing/transform-transition-from-outside-view.html
+        https://bugs.webkit.org/show_bug.cgi?id=184566
+
+        Reviewed by Simon Fraser.
+
+        For the most part this is the same fix that Simon Fraser made to address 184611 in r251412 although here I also
+        changed the setTimeout call to requestAnimationFrame in order to ensure that the backing store bit was set in the
+        layer dump for WK1.
+
+        * TestExpectations:
+        * compositing/backing/transform-transition-from-outside-view.html:
+
 2019-10-24  Chris Dumez  <cdu...@apple.com>
 
         Unreviewed, skip new tests added in 251509 on Windows

Modified: trunk/LayoutTests/TestExpectations (251556 => 251557)


--- trunk/LayoutTests/TestExpectations	2019-10-24 20:27:38 UTC (rev 251556)
+++ trunk/LayoutTests/TestExpectations	2019-10-24 20:48:18 UTC (rev 251557)
@@ -3649,7 +3649,6 @@
 webkit.org/b/190032 animations/missing-values-first-keyframe.html [ Failure ]
 webkit.org/b/190032 animations/missing-values-last-keyframe.html [ Failure ]
 webkit.org/b/190032 compositing/backing/backing-store-attachment-fill-forwards-animation.html [ Failure ]
-webkit.org/b/190032 compositing/backing/transform-transition-from-outside-view.html [ Failure ]
 webkit.org/b/190032 compositing/layer-creation/mismatched-rotated-transform-transition-overlap.html [ Failure ]
 webkit.org/b/190032 compositing/layer-creation/mismatched-transform-transition-overlap.html [ Failure ]
 webkit.org/b/190032 compositing/layer-creation/scale-rotation-transition-overlap.html [ Failure ]

Modified: trunk/LayoutTests/compositing/backing/transform-transition-from-outside-view.html (251556 => 251557)


--- trunk/LayoutTests/compositing/backing/transform-transition-from-outside-view.html	2019-10-24 20:27:38 UTC (rev 251556)
+++ trunk/LayoutTests/compositing/backing/transform-transition-from-outside-view.html	2019-10-24 20:48:18 UTC (rev 251557)
@@ -33,10 +33,17 @@
             testRunner.waitUntilDone();
         }
 
+        function filterString(inputString, skippedLinesRegexp)
+        {
+            var lines = inputString.split("\n");
+            var filtered = lines.filter(function (str) { return !skippedLinesRegexp.test(str); });
+            return filtered.join("\n");
+        }
+
         function dumpLayers()
         {
             if (window.testRunner) {
-                output.innerText = window.internals.layerTreeAsText(document, internals.LAYER_TREE_INCLUDES_BACKING_STORE_ATTACHED);
+                output.innerText = filterString(window.internals.layerTreeAsText(document, internals.LAYER_TREE_INCLUDES_BACKING_STORE_ATTACHED), /transform/);
                 testRunner.notifyDone();
             }
         }
@@ -43,7 +50,7 @@
 
         window.addEventListener("load", function() {
             document.body.classList.add('changed');
-            window.setTimeout(dumpLayers, 0);
+            requestAnimationFrame(dumpLayers);
         });
     </script>
 </head>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to