Modified: trunk/Tools/ChangeLog (251669 => 251670)
--- trunk/Tools/ChangeLog 2019-10-28 20:44:03 UTC (rev 251669)
+++ trunk/Tools/ChangeLog 2019-10-28 20:50:47 UTC (rev 251670)
@@ -1,3 +1,21 @@
+2019-10-28 Jonathan Bedard <[email protected]>
+
+ results.webkit.org: Show results which are missing expectations
+ https://bugs.webkit.org/show_bug.cgi?id=203494
+ <rdar://problem/56436643>
+
+ Reviewed by Aakash Jain.
+
+ * resultsdbpy/resultsdbpy/view/static/css/timeline.css:
+ (.dot.warning): Add warning dot with dark-orange color.
+ * resultsdbpy/resultsdbpy/view/static/js/expectations.js:
+ (Expectations.colorMap): Add warning.
+ (Expectations.failureTypes): Ditto.
+ (Expectations.failureTypeMap): Ditto.
+ (Expectations.symbolMap): Ditto.
+ * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
+ (Legend): Add warning bubble.
+
2019-10-28 John Wilander <[email protected]>
Storage Access API: Make the API work with the experimental 3rd-party cookie blocking
Modified: trunk/Tools/resultsdbpy/resultsdbpy/view/static/css/timeline.css (251669 => 251670)
--- trunk/Tools/resultsdbpy/resultsdbpy/view/static/css/timeline.css 2019-10-28 20:44:03 UTC (rev 251669)
+++ trunk/Tools/resultsdbpy/resultsdbpy/view/static/css/timeline.css 2019-10-28 20:50:47 UTC (rev 251670)
@@ -23,6 +23,10 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
+.dot.warning {
+ background-color: var(--orangeDark);
+}
+
.dot.timedout {
background-color: var(--orangeLight);
}
Modified: trunk/Tools/resultsdbpy/resultsdbpy/view/static/js/expectations.js (251669 => 251670)
--- trunk/Tools/resultsdbpy/resultsdbpy/view/static/js/expectations.js 2019-10-28 20:44:03 UTC (rev 251669)
+++ trunk/Tools/resultsdbpy/resultsdbpy/view/static/js/expectations.js 2019-10-28 20:50:47 UTC (rev 251670)
@@ -27,6 +27,7 @@
const computedStyle = getComputedStyle(document.body);
return {
success: computedStyle.getPropertyValue('--greenLight').trim(),
+ warning: computedStyle.getPropertyValue('--orangeDark').trim(),
failed: computedStyle.getPropertyValue('--redLight').trim(),
timedout: computedStyle.getPropertyValue('--orangeLight').trim(),
crashed: computedStyle.getPropertyValue('--purpleLight').trim(),
@@ -87,8 +88,9 @@
WARNING: 0x38,
PASS: 0x40,
};
-Expectations.failureTypes = ['failed', 'timedout', 'crashed'];
+Expectations.failureTypes = ['warning', 'failed', 'timedout', 'crashed'];
Expectations.failureTypeMap = {
+ warning: 'WARNING',
failed: 'ERROR',
timedout: 'TIMEOUT',
crashed: 'CRASH',
@@ -100,6 +102,7 @@
}
Expectations.symbolMap = {
success: '✓',
+ warning: '?',
failed: '𝖷',
timedout: timeoutImage,
crashed: '!',
Modified: trunk/Tools/resultsdbpy/resultsdbpy/view/static/js/timeline.js (251669 => 251670)
--- trunk/Tools/resultsdbpy/resultsdbpy/view/static/js/timeline.js 2019-10-28 20:44:03 UTC (rev 251669)
+++ trunk/Tools/resultsdbpy/resultsdbpy/view/static/js/timeline.js 2019-10-28 20:50:47 UTC (rev 251670)
@@ -829,6 +829,10 @@
expected: plural ? 'No unexpected results' : 'Result expected',
unexpected: plural ? 'All tests passed' : 'Test passed',
},
+ warning: {
+ expected: plural ? 'Some tests unexpectedly reported warnings' : 'Unexpected warning',
+ unexpected: plural ? 'Some tests reported warnings' : 'Test warning',
+ },
failed: {
expected: plural ? 'Some tests unexpectedly failed' : 'Unexpectedly failed',
unexpected: plural ? 'Some tests failed' : 'Test failed',
