Diff
Modified: trunk/LayoutTests/ChangeLog (251763 => 251764)
--- trunk/LayoutTests/ChangeLog 2019-10-30 03:14:44 UTC (rev 251763)
+++ trunk/LayoutTests/ChangeLog 2019-10-30 03:14:51 UTC (rev 251764)
@@ -1,3 +1,13 @@
+2019-10-29 Said Abou-Hallawa <sabouhall...@apple.com>
+
+ [SVG2] SVGSymbolElement should inherits SVGGraphicsElement
+ https://bugs.webkit.org/show_bug.cgi?id=203573
+
+ Reviewed by Simon Fraser.
+
+ * svg/dom/svg2-inheritance-expected.txt:
+ * svg/dom/svg2-inheritance.html:
+
2019-10-29 Wenson Hsieh <wenson_hs...@apple.com>
REGRESSION (r251693): [iOS] Unable to change selection after focusing an element with keyboard attached
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (251763 => 251764)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2019-10-30 03:14:44 UTC (rev 251763)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2019-10-30 03:14:51 UTC (rev 251764)
@@ -1,3 +1,12 @@
+2019-10-29 Said Abou-Hallawa <sabouhall...@apple.com>
+
+ [SVG2] SVGSymbolElement should inherits SVGGraphicsElement
+ https://bugs.webkit.org/show_bug.cgi?id=203573
+
+ Reviewed by Simon Fraser.
+
+ * web-platform-tests/svg/idlharness.window-expected.txt:
+
2019-10-29 Simon Fraser <simon.fra...@apple.com>
Align CSS hsl() -> rgb() color conversion with the spec
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/svg/idlharness.window-expected.txt (251763 => 251764)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/svg/idlharness.window-expected.txt 2019-10-30 03:14:44 UTC (rev 251763)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/svg/idlharness.window-expected.txt 2019-10-30 03:14:51 UTC (rev 251764)
@@ -511,14 +511,10 @@
PASS SVGElement interface: objects.title must inherit property "viewportElement" with the proper type
FAIL SVGElement interface: objects.title must inherit property "correspondingElement" with the proper type assert_inherits: property "correspondingElement" not found in prototype chain
FAIL SVGElement interface: objects.title must inherit property "correspondingUseElement" with the proper type assert_inherits: property "correspondingUseElement" not found in prototype chain
-FAIL SVGSymbolElement interface: existence and properties of interface object assert_equals: prototype of SVGSymbolElement is not SVGGraphicsElement expected function "function SVGGraphicsElement() {
- [native code]
-}" but got function "function SVGElement() {
- [native code]
-}"
+PASS SVGSymbolElement interface: existence and properties of interface object
PASS SVGSymbolElement interface object length
PASS SVGSymbolElement interface object name
-FAIL SVGSymbolElement interface: existence and properties of interface prototype object assert_equals: prototype of SVGSymbolElement.prototype is not SVGGraphicsElement.prototype expected object "[object SVGGraphicsElementPrototype]" but got object "[object SVGElementPrototype]"
+PASS SVGSymbolElement interface: existence and properties of interface prototype object
PASS SVGSymbolElement interface: existence and properties of interface prototype object's "constructor" property
PASS SVGSymbolElement interface: existence and properties of interface prototype object's @@unscopables property
PASS SVGSymbolElement interface: attribute viewBox
@@ -527,13 +523,13 @@
PASS Stringification of objects.symbol
PASS SVGSymbolElement interface: objects.symbol must inherit property "viewBox" with the proper type
PASS SVGSymbolElement interface: objects.symbol must inherit property "preserveAspectRatio" with the proper type
-FAIL SVGGraphicsElement interface: objects.symbol must inherit property "transform" with the proper type assert_inherits: property "transform" not found in prototype chain
-FAIL SVGGraphicsElement interface: objects.symbol must inherit property "getBBox(SVGBoundingBoxOptions)" with the proper type assert_inherits: property "getBBox" not found in prototype chain
-FAIL SVGGraphicsElement interface: calling getBBox(SVGBoundingBoxOptions) on objects.symbol with too few arguments must throw TypeError assert_inherits: property "getBBox" not found in prototype chain
-FAIL SVGGraphicsElement interface: objects.symbol must inherit property "getCTM()" with the proper type assert_inherits: property "getCTM" not found in prototype chain
-FAIL SVGGraphicsElement interface: objects.symbol must inherit property "getScreenCTM()" with the proper type assert_inherits: property "getScreenCTM" not found in prototype chain
-FAIL SVGGraphicsElement interface: objects.symbol must inherit property "requiredExtensions" with the proper type assert_inherits: property "requiredExtensions" not found in prototype chain
-FAIL SVGGraphicsElement interface: objects.symbol must inherit property "systemLanguage" with the proper type assert_inherits: property "systemLanguage" not found in prototype chain
+PASS SVGGraphicsElement interface: objects.symbol must inherit property "transform" with the proper type
+PASS SVGGraphicsElement interface: objects.symbol must inherit property "getBBox(SVGBoundingBoxOptions)" with the proper type
+PASS SVGGraphicsElement interface: calling getBBox(SVGBoundingBoxOptions) on objects.symbol with too few arguments must throw TypeError
+PASS SVGGraphicsElement interface: objects.symbol must inherit property "getCTM()" with the proper type
+PASS SVGGraphicsElement interface: objects.symbol must inherit property "getScreenCTM()" with the proper type
+PASS SVGGraphicsElement interface: objects.symbol must inherit property "requiredExtensions" with the proper type
+PASS SVGGraphicsElement interface: objects.symbol must inherit property "systemLanguage" with the proper type
PASS SVGElement interface: objects.symbol must inherit property "className" with the proper type
PASS SVGElement interface: objects.symbol must inherit property "ownerSVGElement" with the proper type
PASS SVGElement interface: objects.symbol must inherit property "viewportElement" with the proper type
Modified: trunk/LayoutTests/svg/dom/svg2-inheritance-expected.txt (251763 => 251764)
--- trunk/LayoutTests/svg/dom/svg2-inheritance-expected.txt 2019-10-30 03:14:44 UTC (rev 251763)
+++ trunk/LayoutTests/svg/dom/svg2-inheritance-expected.txt 2019-10-30 03:14:51 UTC (rev 251764)
@@ -106,7 +106,7 @@
PASS SVGStringList inherits Object
PASS SVGStyleElement inherits SVGElement
PASS SVGSwitchElement inherits SVGGraphicsElement
-PASS SVGSymbolElement inherits SVGElement
+PASS SVGSymbolElement inherits SVGGraphicsElement
PASS SVGTRefElement inherits SVGTextPositioningElement
PASS SVGTSpanElement inherits SVGTextPositioningElement
PASS SVGTextContentElement inherits SVGGraphicsElement
Modified: trunk/LayoutTests/svg/dom/svg2-inheritance.html (251763 => 251764)
--- trunk/LayoutTests/svg/dom/svg2-inheritance.html 2019-10-30 03:14:44 UTC (rev 251763)
+++ trunk/LayoutTests/svg/dom/svg2-inheritance.html 2019-10-30 03:14:51 UTC (rev 251764)
@@ -134,7 +134,7 @@
checkParent("SVGStringList", "Object");
checkParent("SVGStyleElement", "SVGElement");
checkParent("SVGSwitchElement", "SVGGraphicsElement");
-checkParent("SVGSymbolElement", "SVGElement");
+checkParent("SVGSymbolElement", "SVGGraphicsElement");
checkParent("SVGTRefElement", "SVGTextPositioningElement");
checkParent("SVGTSpanElement", "SVGTextPositioningElement");
checkParent("SVGTextContentElement", "SVGGraphicsElement");
Modified: trunk/Source/WebCore/ChangeLog (251763 => 251764)
--- trunk/Source/WebCore/ChangeLog 2019-10-30 03:14:44 UTC (rev 251763)
+++ trunk/Source/WebCore/ChangeLog 2019-10-30 03:14:51 UTC (rev 251764)
@@ -1,3 +1,19 @@
+2019-10-29 Said Abou-Hallawa <sabouhall...@apple.com>
+
+ [SVG2] SVGSymbolElement should inherits SVGGraphicsElement
+ https://bugs.webkit.org/show_bug.cgi?id=203573
+
+ Reviewed by Simon Fraser.
+
+ The spec link is:
+ https://www.w3.org/TR/SVG2/struct.html#InterfaceSVGSymbolElement
+
+ * svg/SVGSymbolElement.cpp:
+ (WebCore::SVGSymbolElement::SVGSymbolElement):
+ (WebCore::SVGSymbolElement::parseAttribute):
+ * svg/SVGSymbolElement.h:
+ * svg/SVGSymbolElement.idl:
+
2019-10-29 Jiewen Tan <jiewen_...@apple.com>
[WebAuthn] Add more information to _WKWebAuthenticationPanel
Modified: trunk/Source/WebCore/svg/SVGSymbolElement.cpp (251763 => 251764)
--- trunk/Source/WebCore/svg/SVGSymbolElement.cpp 2019-10-30 03:14:44 UTC (rev 251763)
+++ trunk/Source/WebCore/svg/SVGSymbolElement.cpp 2019-10-30 03:14:51 UTC (rev 251764)
@@ -32,7 +32,7 @@
WTF_MAKE_ISO_ALLOCATED_IMPL(SVGSymbolElement);
inline SVGSymbolElement::SVGSymbolElement(const QualifiedName& tagName, Document& document)
- : SVGElement(tagName, document)
+ : SVGGraphicsElement(tagName, document)
, SVGFitToViewBox(this)
{
ASSERT(hasTagName(SVGNames::symbolTag));
@@ -45,7 +45,7 @@
void SVGSymbolElement::parseAttribute(const QualifiedName& name, const AtomString& value)
{
- SVGElement::parseAttribute(name, value);
+ SVGGraphicsElement::parseAttribute(name, value);
SVGFitToViewBox::parseAttribute(name, value);
}
Modified: trunk/Source/WebCore/svg/SVGSymbolElement.h (251763 => 251764)
--- trunk/Source/WebCore/svg/SVGSymbolElement.h 2019-10-30 03:14:44 UTC (rev 251763)
+++ trunk/Source/WebCore/svg/SVGSymbolElement.h 2019-10-30 03:14:51 UTC (rev 251764)
@@ -21,12 +21,12 @@
#pragma once
-#include "SVGElement.h"
#include "SVGFitToViewBox.h"
+#include "SVGGraphicsElement.h"
namespace WebCore {
-class SVGSymbolElement final : public SVGElement, public SVGFitToViewBox {
+class SVGSymbolElement final : public SVGGraphicsElement, public SVGFitToViewBox {
WTF_MAKE_ISO_ALLOCATED(SVGSymbolElement);
public:
static Ref<SVGSymbolElement> create(const QualifiedName&, Document&);
@@ -34,7 +34,7 @@
private:
SVGSymbolElement(const QualifiedName&, Document&);
- using PropertyRegistry = SVGPropertyOwnerRegistry<SVGSymbolElement, SVGElement, SVGFitToViewBox>;
+ using PropertyRegistry = SVGPropertyOwnerRegistry<SVGSymbolElement, SVGGraphicsElement, SVGFitToViewBox>;
const SVGPropertyRegistry& propertyRegistry() const final { return m_propertyRegistry; }
void parseAttribute(const QualifiedName&, const AtomString&) override;
Modified: trunk/Source/WebCore/svg/SVGSymbolElement.idl (251763 => 251764)
--- trunk/Source/WebCore/svg/SVGSymbolElement.idl 2019-10-30 03:14:44 UTC (rev 251763)
+++ trunk/Source/WebCore/svg/SVGSymbolElement.idl 2019-10-30 03:14:51 UTC (rev 251764)
@@ -23,7 +23,7 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-interface SVGSymbolElement : SVGElement {
+interface SVGSymbolElement : SVGGraphicsElement {
};
SVGSymbolElement implements SVGFitToViewBox;
