Title: [251832] trunk/Source/WebCore
- Revision
- 251832
- Author
- [email protected]
- Date
- 2019-10-30 20:47:34 -0700 (Wed, 30 Oct 2019)
Log Message
Web Inspector: Timelines: ResizeObserver callbacks are not labeled in the Events timeline
https://bugs.webkit.org/show_bug.cgi?id=203634
<rdar://problem/56760736>
Reviewed by Simon Fraser.
Wrap the `ResizeObserver` event handler in two `InspectorInstrumentation` calls so the
frontend knows how to properly label the callbacks.
* page/ResizeObserver.cpp:
(WebCore::ResizeObserver::deliverObservations):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (251831 => 251832)
--- trunk/Source/WebCore/ChangeLog 2019-10-31 03:06:31 UTC (rev 251831)
+++ trunk/Source/WebCore/ChangeLog 2019-10-31 03:47:34 UTC (rev 251832)
@@ -1,3 +1,17 @@
+2019-10-30 Devin Rousso <[email protected]>
+
+ Web Inspector: Timelines: ResizeObserver callbacks are not labeled in the Events timeline
+ https://bugs.webkit.org/show_bug.cgi?id=203634
+ <rdar://problem/56760736>
+
+ Reviewed by Simon Fraser.
+
+ Wrap the `ResizeObserver` event handler in two `InspectorInstrumentation` calls so the
+ frontend knows how to properly label the callbacks.
+
+ * page/ResizeObserver.cpp:
+ (WebCore::ResizeObserver::deliverObservations):
+
2019-10-30 Alex Christensen <[email protected]>
Prevent Mac CMake build from bit rotting
Modified: trunk/Source/WebCore/page/ResizeObserver.cpp (251831 => 251832)
--- trunk/Source/WebCore/page/ResizeObserver.cpp 2019-10-31 03:06:31 UTC (rev 251831)
+++ trunk/Source/WebCore/page/ResizeObserver.cpp 2019-10-31 03:47:34 UTC (rev 251832)
@@ -29,6 +29,7 @@
#include "ResizeObserver.h"
#include "Element.h"
+#include "InspectorInstrumentation.h"
#include "ResizeObserverEntry.h"
namespace WebCore {
@@ -122,7 +123,14 @@
entries.append(ResizeObserverEntry::create(observation->target(), observation->computeContentRect()));
}
m_activeObservations.clear();
+
+ auto* context = m_callback->scriptExecutionContext();
+ if (!context)
+ return;
+
+ InspectorInstrumentation::willFireObserverCallback(*context, "ResizeObserver"_s);
m_callback->handleEvent(entries, *this);
+ InspectorInstrumentation::didFireObserverCallback(*context);
}
bool ResizeObserver::removeTarget(Element& target)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
