Diff
Modified: trunk/Source/WebKit/ChangeLog (251858 => 251859)
--- trunk/Source/WebKit/ChangeLog 2019-10-31 17:39:51 UTC (rev 251858)
+++ trunk/Source/WebKit/ChangeLog 2019-10-31 17:49:54 UTC (rev 251859)
@@ -1,5 +1,24 @@
2019-10-31 Alex Christensen <achristen...@webkit.org>
+ Expose more WKPreferences SPI
+ https://bugs.webkit.org/show_bug.cgi?id=203631
+ <rdar://problem/56717160>
+
+ Reviewed by Brady Eidson.
+
+ I added a unit test for the one that can be easily tested.
+
+ * UIProcess/API/Cocoa/WKPreferences.mm:
+ (-[WKPreferences _setWebAudioEnabled:]):
+ (-[WKPreferences _webAudioEnabled]):
+ (-[WKPreferences _setAcceleratedCompositingEnabled:]):
+ (-[WKPreferences _acceleratedCompositingEnabled]):
+ (-[WKPreferences _setRequestAnimationFrameEnabled:]):
+ (-[WKPreferences _requestAnimationFrameEnabled]):
+ * UIProcess/API/Cocoa/WKPreferencesPrivate.h:
+
+2019-10-31 Alex Christensen <achristen...@webkit.org>
+
CMake build should make WebKit framework able to be used by Safari
https://bugs.webkit.org/show_bug.cgi?id=203685
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm (251858 => 251859)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm 2019-10-31 17:39:51 UTC (rev 251858)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm 2019-10-31 17:49:54 UTC (rev 251859)
@@ -862,6 +862,36 @@
_preferences->setSecureContextChecksEnabled(enabled);
}
+- (void)_setWebAudioEnabled:(BOOL)enabled
+{
+ _preferences->setWebAudioEnabled(enabled);
+}
+
+- (BOOL)_webAudioEnabled
+{
+ return _preferences->webAudioEnabled();
+}
+
+- (void)_setAcceleratedCompositingEnabled:(BOOL)enabled
+{
+ _preferences->setAcceleratedCompositingEnabled(enabled);
+}
+
+- (BOOL)_acceleratedCompositingEnabled
+{
+ return _preferences->acceleratedCompositingEnabled();
+}
+
+- (void)_setRequestAnimationFrameEnabled:(BOOL)enabled
+{
+ _preferences->setRequestAnimationFrameEnabled(enabled);
+}
+
+- (BOOL)_requestAnimationFrameEnabled
+{
+ return _preferences->requestAnimationFrameEnabled();
+}
+
- (BOOL)_remotePlaybackEnabled
{
return _preferences->remotePlaybackEnabled();
@@ -893,16 +923,6 @@
return _preferences->canvasUsesAcceleratedDrawing();
}
-- (void)_setAcceleratedCompositingEnabled:(BOOL)enabled
-{
- _preferences->setAcceleratedCompositingEnabled(enabled);
-}
-
-- (BOOL)_acceleratedCompositingEnabled
-{
- return _preferences->acceleratedCompositingEnabled();
-}
-
- (void)_setDefaultTextEncodingName:(NSString *)name
{
_preferences->setDefaultTextEncodingName(name);
@@ -1296,16 +1316,6 @@
return _preferences->wantsBalancedSetDefersLoadingBehavior();
}
-- (void)_setWebAudioEnabled:(BOOL)enabled
-{
- _preferences->setWebAudioEnabled(enabled);
-}
-
-- (BOOL)_webAudioEnabled
-{
- return _preferences->webAudioEnabled();
-}
-
- (void)_setAggressiveTileRetentionEnabled:(BOOL)enabled
{
_preferences->setAggressiveTileRetentionEnabled(enabled);
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h (251858 => 251859)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h 2019-10-31 17:39:51 UTC (rev 251858)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h 2019-10-31 17:49:54 UTC (rev 251859)
@@ -158,12 +158,14 @@
@property (nonatomic, setter=_setMediaSourceEnabled:) BOOL _mediaSourceEnabled WK_API_AVAILABLE(macos(10.13.4), ios(WK_IOS_TBA));
@property (nonatomic, setter=_setSecureContextChecksEnabled:) BOOL _secureContextChecksEnabled WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
@property (nonatomic, setter=_setRemotePlaybackEnabled:) BOOL _remotePlaybackEnabled WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
+@property (nonatomic, setter=_setWebAudioEnabled:) BOOL _webAudioEnabled WK_API_AVAILABLE(macos(10.14), ios(WK_IOS_TBA));
+@property (nonatomic, setter=_setAcceleratedCompositingEnabled:) BOOL _acceleratedCompositingEnabled WK_API_AVAILABLE(macos(10.13.4), ios(WK_IOS_TBA));
+@property (nonatomic, setter=_setRequestAnimationFrameEnabled:) BOOL _requestAnimationFrameEnabled WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
#if !TARGET_OS_IPHONE
@property (nonatomic, setter=_setWebGLEnabled:) BOOL _webGLEnabled WK_API_AVAILABLE(macos(10.13.4));
@property (nonatomic, setter=_setJavaEnabledForLocalFiles:) BOOL _javaEnabledForLocalFiles WK_API_AVAILABLE(macos(10.13.4));
@property (nonatomic, setter=_setCanvasUsesAcceleratedDrawing:) BOOL _canvasUsesAcceleratedDrawing WK_API_AVAILABLE(macos(10.13.4));
-@property (nonatomic, setter=_setAcceleratedCompositingEnabled:) BOOL _acceleratedCompositingEnabled WK_API_AVAILABLE(macos(10.13.4));
@property (nonatomic, setter=_setDefaultTextEncodingName:) NSString *_defaultTextEncodingName WK_API_AVAILABLE(macos(10.13.4));
@property (nonatomic, setter=_setAuthorAndUserStylesEnabled:) BOOL _authorAndUserStylesEnabled WK_API_AVAILABLE(macos(10.13.4));
@property (nonatomic, setter=_setDOMTimersThrottlingEnabled:) BOOL _domTimersThrottlingEnabled WK_API_AVAILABLE(macos(10.13.4));
@@ -202,7 +204,6 @@
@property (nonatomic, setter=_setTextAreasAreResizable:) BOOL _textAreasAreResizable WK_API_AVAILABLE(macos(10.14));
@property (nonatomic, setter=_setUseGiantTiles:) BOOL _useGiantTiles WK_API_AVAILABLE(macos(10.14));
@property (nonatomic, setter=_setWantsBalancedSetDefersLoadingBehavior:) BOOL _wantsBalancedSetDefersLoadingBehavior WK_API_AVAILABLE(macos(10.14));
-@property (nonatomic, setter=_setWebAudioEnabled:) BOOL _webAudioEnabled WK_API_AVAILABLE(macos(10.14));
@property (nonatomic, setter=_setAggressiveTileRetentionEnabled:) BOOL _aggressiveTileRetentionEnabled WK_API_AVAILABLE(macos(10.14));
@property (nonatomic, setter=_setAppNapEnabled:) BOOL _appNapEnabled WK_API_AVAILABLE(macos(WK_MAC_TBA));
#endif
Modified: trunk/Tools/ChangeLog (251858 => 251859)
--- trunk/Tools/ChangeLog 2019-10-31 17:39:51 UTC (rev 251858)
+++ trunk/Tools/ChangeLog 2019-10-31 17:49:54 UTC (rev 251859)
@@ -1,3 +1,14 @@
+2019-10-31 Alex Christensen <achristen...@webkit.org>
+
+ Expose more WKPreferences SPI
+ https://bugs.webkit.org/show_bug.cgi?id=203631
+ <rdar://problem/56717160>
+
+ Reviewed by Brady Eidson.
+
+ * TestWebKitAPI/Tests/WebKitCocoa/Preferences.mm:
+ (TEST):
+
2019-10-30 Wenson Hsieh <wenson_hs...@apple.com>
[iOS] imported/mozilla/svg/text/textpath-selection.svg is still flaky
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/Preferences.mm (251858 => 251859)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/Preferences.mm 2019-10-31 17:39:51 UTC (rev 251858)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/Preferences.mm 2019-10-31 17:49:54 UTC (rev 251859)
@@ -25,6 +25,7 @@
#import "config.h"
+#import "PlatformUtilities.h"
#import "Test.h"
#import "Utilities.h"
#import <WebKit/WKFoundation.h>
@@ -66,6 +67,25 @@
}
}
+TEST(WebKit, WebAudioPreference)
+{
+ auto check = [](bool value) {
+ WKWebViewConfiguration *configuration = [[[WKWebViewConfiguration alloc] init] autorelease];
+ configuration.preferences._webAudioEnabled = value;
+ auto webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 100, 100) configuration:configuration]);
+ __block bool done = false;
+ __block RetainPtr<NSString> result;
+ [webView evaluateJavaScript:@"new Boolean(window.webkitAudioContext).toString()" completionHandler:^(id resultFromJS, NSError *error) {
+ result = resultFromJS;
+ done = true;
+ }];
+ TestWebKitAPI::Util::run(&done);
+ return result.autorelease();
+ };
+ EXPECT_WK_STREQ(check(true), "true");
+ EXPECT_WK_STREQ(check(false), "false");
+}
+
#if PLATFORM(MAC)
static bool receivedAlert;
