Title: [251869] trunk/Tools
- Revision
- 251869
- Author
- [email protected]
- Date
- 2019-10-31 12:56:34 -0700 (Thu, 31 Oct 2019)
Log Message
[ews-build] Display pre-existing API test names in the build summary
https://bugs.webkit.org/show_bug.cgi?id=199525
Reviewed by Jonathan Bedard.
* BuildSlaveSupport/ews-build/steps.py:
(AnalyzeAPITestsResults.analyzeResults): Include the names of pre-existing test failures in summary string and
limit the number of failures to display to NUM_API_FAILURES_TO_DISPLAY.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps.py (251868 => 251869)
--- trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2019-10-31 19:29:51 UTC (rev 251868)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2019-10-31 19:56:34 UTC (rev 251869)
@@ -1488,6 +1488,8 @@
first_run_failures = getAPITestFailures(first_run_results)
second_run_failures = getAPITestFailures(second_run_results)
clean_tree_failures = getAPITestFailures(clean_tree_results)
+ clean_tree_failures_to_display = list(clean_tree_failures)[:self.NUM_API_FAILURES_TO_DISPLAY]
+ clean_tree_failures_string = ', '.join(clean_tree_failures_to_display)
failures_with_patch = first_run_failures.intersection(second_run_failures)
flaky_failures = first_run_failures.union(second_run_failures) - first_run_failures.intersection(second_run_failures)
@@ -1517,7 +1519,9 @@
self.build.results = SUCCESS
self.descriptionDone = 'Passed API tests'
pluralSuffix = 's' if len(clean_tree_failures) > 1 else ''
- message = 'Found {} pre-existing API test failure{}'.format(len(clean_tree_failures), pluralSuffix)
+ message = 'Found {} pre-existing API test failure{}: {}'.format(len(clean_tree_failures), pluralSuffix, clean_tree_failures_string)
+ if len(clean_tree_failures) > self.NUM_API_FAILURES_TO_DISPLAY:
+ message += ' ...'
if flaky_failures:
message += '. Flaky tests: {}'.format(flaky_failures_string)
self.build.buildFinished([message], SUCCESS)
Modified: trunk/Tools/ChangeLog (251868 => 251869)
--- trunk/Tools/ChangeLog 2019-10-31 19:29:51 UTC (rev 251868)
+++ trunk/Tools/ChangeLog 2019-10-31 19:56:34 UTC (rev 251869)
@@ -1,3 +1,14 @@
+2019-10-31 Aakash Jain <[email protected]>
+
+ [ews-build] Display pre-existing API test names in the build summary
+ https://bugs.webkit.org/show_bug.cgi?id=199525
+
+ Reviewed by Jonathan Bedard.
+
+ * BuildSlaveSupport/ews-build/steps.py:
+ (AnalyzeAPITestsResults.analyzeResults): Include the names of pre-existing test failures in summary string and
+ limit the number of failures to display to NUM_API_FAILURES_TO_DISPLAY.
+
2019-10-31 Alex Christensen <[email protected]>
Expose more WKPreferences SPI
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
