Title: [251948] trunk/Source/WebKit
- Revision
- 251948
- Author
- bb...@apple.com
- Date
- 2019-11-01 15:16:29 -0700 (Fri, 01 Nov 2019)
Log Message
REGRESSION(r248696): Element Click on Mac is adding an extra page topContentInsets to y-coordinate
https://bugs.webkit.org/show_bug.cgi?id=203765
<rdar://problem/56014369>
Reviewed by Devin Rousso.
* UIProcess/Automation/mac/WebAutomationSessionMac.mm:
(WebKit::WebAutomationSession::platformSimulateMouseInteraction):
The topContentInsets is accounted for by rootViewToWindow(), so don't add it in manually.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (251947 => 251948)
--- trunk/Source/WebKit/ChangeLog 2019-11-01 21:59:02 UTC (rev 251947)
+++ trunk/Source/WebKit/ChangeLog 2019-11-01 22:16:29 UTC (rev 251948)
@@ -1,3 +1,15 @@
+2019-11-01 Brian Burg <bb...@apple.com>
+
+ REGRESSION(r248696): Element Click on Mac is adding an extra page topContentInsets to y-coordinate
+ https://bugs.webkit.org/show_bug.cgi?id=203765
+ <rdar://problem/56014369>
+
+ Reviewed by Devin Rousso.
+
+ * UIProcess/Automation/mac/WebAutomationSessionMac.mm:
+ (WebKit::WebAutomationSession::platformSimulateMouseInteraction):
+ The topContentInsets is accounted for by rootViewToWindow(), so don't add it in manually.
+
2019-11-01 Per Arne Vollan <pvol...@apple.com>
Investigate if mach lookup access to *.apple-extension-service, *.viewservice, and com.apple.uikit.viewservice.* can be denied
Modified: trunk/Source/WebKit/UIProcess/Automation/mac/WebAutomationSessionMac.mm (251947 => 251948)
--- trunk/Source/WebKit/UIProcess/Automation/mac/WebAutomationSessionMac.mm 2019-11-01 21:59:02 UTC (rev 251947)
+++ trunk/Source/WebKit/UIProcess/Automation/mac/WebAutomationSessionMac.mm 2019-11-01 22:16:29 UTC (rev 251948)
@@ -137,7 +137,7 @@
{
IntRect windowRect;
- IntPoint locationInView = WebCore::IntPoint(locationInViewport.x(), locationInViewport.y() + page.topContentInset());
+ IntPoint locationInView = WebCore::IntPoint(locationInViewport.x(), locationInViewport.y());
page.rootViewToWindow(IntRect(locationInView, IntSize()), windowRect);
IntPoint locationInWindow = windowRect.location();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
