Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (252062 => 252063)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-11-05 18:52:12 UTC (rev 252062)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-11-05 18:53:13 UTC (rev 252063)
@@ -1,3 +1,18 @@
+2019-11-05 Ross Kirsling <ross.kirsl...@sony.com>
+
+ Web Inspector: Layers: enable tab by default
+ https://bugs.webkit.org/show_bug.cgi?id=203833
+
+ Reviewed by Timothy Hatcher.
+
+ * Localizations/en.lproj/localizedStrings.js:
+ * UserInterface/Base/Setting.js:
+ * UserInterface/Views/ContextMenuUtilities.js:
+ * UserInterface/Views/LayersTabContentView.js:
+ (WI.LayersTabContentView.isTabAllowed):
+ * UserInterface/Views/SettingsTabContentView.js:
+ (WI.SettingsTabContentView.prototype._createExperimentalSettingsView):
+
2019-11-04 Devin Rousso <drou...@apple.com>
Web Inspector: "Toggle Visibility" does not work for element inside Shadow DOM
Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (252062 => 252063)
--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2019-11-05 18:52:12 UTC (rev 252062)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2019-11-05 18:53:13 UTC (rev 252063)
@@ -449,7 +449,6 @@
localizedStrings["Enable Event Listener"] = "Enable Event Listener";
localizedStrings["Enable Event Listeners"] = "Enable Event Listeners";
localizedStrings["Enable Inspector Bootstrap Script"] = "Enable Inspector Bootstrap Script";
-localizedStrings["Enable Layers Tab"] = "Enable Layers Tab";
localizedStrings["Enable Local Override"] = "Enable Local Override";
localizedStrings["Enable New Tab Bar"] = "Enable New Tab Bar";
localizedStrings["Enable Preview Features"] = "Enable Preview Features";
@@ -658,7 +657,6 @@
localizedStrings["Layer Count: %d"] = "Layer Count: %d";
localizedStrings["Layer Info"] = "Layer Info";
localizedStrings["Layers"] = "Layers";
-localizedStrings["Layers:"] = "Layers:";
localizedStrings["Layout & Rendering"] = "Layout & Rendering";
/* Layout phase timeline records */
localizedStrings["Layout @ Timeline record"] = "Layout";
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js (252062 => 252063)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js 2019-11-05 18:52:12 UTC (rev 252062)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js 2019-11-05 18:53:13 UTC (rev 252063)
@@ -187,7 +187,6 @@
// Experimental
experimentalEnablePreviewFeatures: new WI.Setting("experimental-enable-preview-features", false),
- experimentalEnableLayersTab: new WI.Setting("experimental-enable-layers-tab", false),
experimentalEnableNewTabBar: new WI.Setting("experimental-enable-new-tab-bar", false),
experimentalEnableStylesJumpToEffective: new WI.Setting("experimental-styles-jump-to-effective", false),
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js (252062 => 252063)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js 2019-11-05 18:52:12 UTC (rev 252062)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js 2019-11-05 18:53:13 UTC (rev 252063)
@@ -300,7 +300,7 @@
});
}
- if (WI.settings.experimentalEnableLayersTab.value && InspectorBackend.hasDomain("LayerTree") && attached) {
+ if (InspectorBackend.hasDomain("LayerTree") && attached) {
contextMenu.appendItem(WI.UIString("Reveal in Layers Tab", "Open Layers tab and select the layer corresponding to this node"), () => {
WI.showLayersTab({nodeToSelect: domNode});
});
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/LayersTabContentView.js (252062 => 252063)
--- trunk/Source/WebInspectorUI/UserInterface/Views/LayersTabContentView.js 2019-11-05 18:52:12 UTC (rev 252062)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/LayersTabContentView.js 2019-11-05 18:53:13 UTC (rev 252063)
@@ -53,7 +53,7 @@
static isTabAllowed()
{
- return InspectorBackend.hasDomain("LayerTree") && !!WI.settings.experimentalEnableLayersTab.value;
+ return InspectorBackend.hasDomain("LayerTree");
}
// Public
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js (252062 => 252063)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js 2019-11-05 18:52:12 UTC (rev 252062)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js 2019-11-05 18:53:13 UTC (rev 252063)
@@ -354,11 +354,6 @@
experimentalSettingsView.addSeparator();
}
- if (InspectorBackend.hasDomain("LayerTree")) {
- experimentalSettingsView.addSetting(WI.UIString("Layers:"), WI.settings.experimentalEnableLayersTab, WI.UIString("Enable Layers Tab"));
- experimentalSettingsView.addSeparator();
- }
-
experimentalSettingsView.addSetting(WI.UIString("User Interface:"), WI.settings.experimentalEnableNewTabBar, WI.UIString("Enable New Tab Bar"));
experimentalSettingsView.addSeparator();
@@ -371,10 +366,6 @@
let reloadInspectorButton = document.createElement("button");
reloadInspectorButton.textContent = WI.UIString("Reload Web Inspector");
reloadInspectorButton.addEventListener("click", (event) => {
- if (!initialValues.get(WI.settings.experimentalEnableLayersTab) && InspectorBackend.hasDomain("LayerTree") && WI.settings.experimentalEnableLayersTab.value)
- WI._openTabsSetting.value.push(WI.LayersTabContentView.Type);
- WI._openTabsSetting.save();
-
InspectorFrontendHost.reopen();
});
@@ -389,7 +380,6 @@
}
listenForChange(WI.settings.experimentalEnablePreviewFeatures);
- listenForChange(WI.settings.experimentalEnableLayersTab);
listenForChange(WI.settings.experimentalEnableNewTabBar);
if (InspectorBackend.hasDomain("CSS"))
