Title: [252116] trunk
- Revision
- 252116
- Author
- wilan...@apple.com
- Date
- 2019-11-05 17:38:59 -0800 (Tue, 05 Nov 2019)
Log Message
Temporarily turn off NSURLSession isolation
https://bugs.webkit.org/show_bug.cgi?id=201822
Reviewed by Chris Dumez.
Source/WebKit:
Existing tests skipped.
Re-enabling it is tracked in rdar://problem/56921584.
* NetworkProcess/cache/NetworkCacheStorage.h:
Bumps the version to force a clean cache.
* NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
Skips setting needsIsolatedSession.
LayoutTests:
Re-enabling it is tracked in rdar://problem/56921584.
* platform/wk2/TestExpectations:
Skipped the associated tests.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (252115 => 252116)
--- trunk/LayoutTests/ChangeLog 2019-11-06 01:30:41 UTC (rev 252115)
+++ trunk/LayoutTests/ChangeLog 2019-11-06 01:38:59 UTC (rev 252116)
@@ -1,3 +1,15 @@
+2019-11-05 John Wilander <wilan...@apple.com>
+
+ Temporarily turn off NSURLSession isolation
+ https://bugs.webkit.org/show_bug.cgi?id=201822
+
+ Reviewed by Chris Dumez.
+
+ Re-enabling it is tracked in rdar://problem/56921584.
+
+ * platform/wk2/TestExpectations:
+ Skipped the associated tests.
+
2019-11-05 Oriol Brufau <obru...@igalia.com>
[css-lists] Implement list-style-type: <string>
Modified: trunk/LayoutTests/platform/wk2/TestExpectations (252115 => 252116)
--- trunk/LayoutTests/platform/wk2/TestExpectations 2019-11-06 01:30:41 UTC (rev 252115)
+++ trunk/LayoutTests/platform/wk2/TestExpectations 2019-11-06 01:38:59 UTC (rev 252116)
@@ -746,6 +746,10 @@
http/tests/resourceLoadStatistics/non-prevalent-resources-can-access-cookies-in-a-third-party-context.html [ Skip ]
http/tests/resourceLoadStatistics/cap-cache-max-age-for-prevalent-resource.html [ Skip ]
+# rdar://problem/56921584
+http/tests/resourceLoadStatistics/switch-session-on-navigation-to-prevalent-with-interaction.php [ Skip ]
+http/tests/resourceLoadStatistics/switch-session-on-navigation-to-prevalent-with-interaction-database.php [ Skip ]
+
# This feature is currently disabled by default and unfinished <rdar://problem/38925077>.
http/tests/navigation/process-swap-window-open.html [ Skip ]
Modified: trunk/Source/WebKit/ChangeLog (252115 => 252116)
--- trunk/Source/WebKit/ChangeLog 2019-11-06 01:30:41 UTC (rev 252115)
+++ trunk/Source/WebKit/ChangeLog 2019-11-06 01:38:59 UTC (rev 252116)
@@ -1,3 +1,20 @@
+2019-11-05 John Wilander <wilan...@apple.com>
+
+ Temporarily turn off NSURLSession isolation
+ https://bugs.webkit.org/show_bug.cgi?id=201822
+
+ Reviewed by Chris Dumez.
+
+ Existing tests skipped.
+
+ Re-enabling it is tracked in rdar://problem/56921584.
+
+ * NetworkProcess/cache/NetworkCacheStorage.h:
+ Bumps the version to force a clean cache.
+ * NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
+ (WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
+ Skips setting needsIsolatedSession.
+
2019-11-05 Per Arne Vollan <pvol...@apple.com>
Eliminate mach lookup to cfprefsd on process startup
Modified: trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h (252115 => 252116)
--- trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h 2019-11-06 01:30:41 UTC (rev 252115)
+++ trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h 2019-11-06 01:38:59 UTC (rev 252116)
@@ -107,7 +107,7 @@
size_t approximateSize() const;
// Incrementing this number will delete all existing cache content for everyone. Do you really need to do it?
- static const unsigned version = 14;
+ static const unsigned version = 15;
#if PLATFORM(MAC)
/// Allow the last stable version of the cache to co-exist with the latest development one.
static const unsigned lastStableVersion = 13;
Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm (252115 => 252116)
--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm 2019-11-06 01:30:41 UTC (rev 252115)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm 2019-11-06 01:38:59 UTC (rev 252116)
@@ -213,7 +213,7 @@
if (auto* networkStorageSession = session.networkStorageSession()) {
if (!shouldBlockCookies)
shouldBlockCookies = networkStorageSession->shouldBlockCookies(request, frameID, pageID);
- needsIsolatedSession = networkStorageSession->shouldBlockThirdPartyCookiesButKeepFirstPartyCookiesFor(firstParty);
+ // FIXME: <rdar://problem/56921584> needsIsolatedSession should be set here.
}
#endif
restrictRequestReferrerToOriginIfNeeded(request);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
