Title: [252325] trunk
- Revision
- 252325
- Author
- commit-qu...@webkit.org
- Date
- 2019-11-11 08:24:49 -0800 (Mon, 11 Nov 2019)
Log Message
Unreviewed, rolling out r251460.
https://bugs.webkit.org/show_bug.cgi?id=204070
This patch caused a crash due to synchronous event firing
(Requested by jernoble on #webkit).
Reverted changeset:
"media/W3C/video/networkState/networkState_during_progress.html
is flaky"
https://bugs.webkit.org/show_bug.cgi?id=76280
https://trac.webkit.org/changeset/251460
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (252324 => 252325)
--- trunk/LayoutTests/ChangeLog 2019-11-11 16:23:25 UTC (rev 252324)
+++ trunk/LayoutTests/ChangeLog 2019-11-11 16:24:49 UTC (rev 252325)
@@ -1,3 +1,18 @@
+2019-11-11 Commit Queue <commit-qu...@webkit.org>
+
+ Unreviewed, rolling out r251460.
+ https://bugs.webkit.org/show_bug.cgi?id=204070
+
+ This patch caused a crash due to synchronous event firing
+ (Requested by jernoble on #webkit).
+
+ Reverted changeset:
+
+ "media/W3C/video/networkState/networkState_during_progress.html
+ is flaky"
+ https://bugs.webkit.org/show_bug.cgi?id=76280
+ https://trac.webkit.org/changeset/251460
+
2019-11-10 Ryosuke Niwa <rn...@webkit.org>
iOS: fast/events/scroll-subframe-in-rendering-update.html always fails
Modified: trunk/LayoutTests/TestExpectations (252324 => 252325)
--- trunk/LayoutTests/TestExpectations 2019-11-11 16:23:25 UTC (rev 252324)
+++ trunk/LayoutTests/TestExpectations 2019-11-11 16:24:49 UTC (rev 252325)
@@ -846,6 +846,9 @@
webkit.org/b/139862 editing/spelling/editing-multiple-words-with-markers.html [ Timeout Pass ]
webkit.org/b/139903 editing/spelling/grammar-paste.html [ Timeout Pass ]
+# media/W3C/video/networkState/networkState_during_progress.html is flaky
+webkit.org/b/76280 media/W3C/video/networkState/networkState_during_progress.html [ Pass Failure ]
+
# This test will run slowly in debug mode, but is plenty fast in release.
[ Debug ] js/slow-stress/emscripten-memops.html [ Skip ]
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (252324 => 252325)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2019-11-11 16:23:25 UTC (rev 252324)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2019-11-11 16:24:49 UTC (rev 252325)
@@ -1560,6 +1560,8 @@
webkit.org/b/133000 js/slow-stress/call-spread.html [ Pass Timeout ]
webkit.org/b/133001 fast/workers/worker-context-gc.html [ Pass Timeout ]
+webkit.org/b/133865 media/W3C/video/networkState/networkState_during_progress.html [ Failure Pass ]
+
webkit.org/b/133869 media/video-seek-after-end.html [ Failure Pass ]
webkit.org/b/36642 fast/replaced/border-radius-clip.html [ Failure Pass ]
Modified: trunk/LayoutTests/platform/mac/TestExpectations (252324 => 252325)
--- trunk/LayoutTests/platform/mac/TestExpectations 2019-11-11 16:23:25 UTC (rev 252324)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2019-11-11 16:24:49 UTC (rev 252325)
@@ -765,6 +765,7 @@
## --- Start flaky media tests ---
webkit.org/b/34331 http/tests/media/video-referer.html [ Pass Timeout ]
webkit.org/b/35297 media/video-display-aspect-ratio.html [ Pass Failure ]
+webkit.org/b/82976 media/W3C/video/networkState/networkState_during_progress.html [ Pass Failure ]
webkit.org/b/85525 media/video-played-reset.html [ Pass Failure ]
webkit.org/b/112659 media/video-playing-and-pause.html [ Failure Timeout ]
webkit.org/b/114744 media/video-layer-crash.html [ Pass Timeout Failure ]
Modified: trunk/LayoutTests/platform/win/TestExpectations (252324 => 252325)
--- trunk/LayoutTests/platform/win/TestExpectations 2019-11-11 16:23:25 UTC (rev 252324)
+++ trunk/LayoutTests/platform/win/TestExpectations 2019-11-11 16:24:49 UTC (rev 252325)
@@ -913,6 +913,8 @@
media/encrypted-media/encrypted-media-not-loaded.html [ Skip ] # [ WontFix ]
media/encrypted-media/encrypted-media-syntax.html [ Skip ] # [ WontFix ]
+webkit.org/b/103442 media/W3C/video/networkState/networkState_during_progress.html [ Skip ]
+
# No CORS support for media elements is implemented yet.
webkit.org/b/176626 http/tests/security/canvas-remote-read-remote-video-allowed-anonymous.html [ Crash Failure ]
webkit.org/b/176653 http/tests/security/canvas-remote-read-remote-video-allowed-with-credentials.html [ Crash Failure ]
Modified: trunk/Source/WebCore/ChangeLog (252324 => 252325)
--- trunk/Source/WebCore/ChangeLog 2019-11-11 16:23:25 UTC (rev 252324)
+++ trunk/Source/WebCore/ChangeLog 2019-11-11 16:24:49 UTC (rev 252325)
@@ -1,3 +1,18 @@
+2019-11-11 Commit Queue <commit-qu...@webkit.org>
+
+ Unreviewed, rolling out r251460.
+ https://bugs.webkit.org/show_bug.cgi?id=204070
+
+ This patch caused a crash due to synchronous event firing
+ (Requested by jernoble on #webkit).
+
+ Reverted changeset:
+
+ "media/W3C/video/networkState/networkState_during_progress.html
+ is flaky"
+ https://bugs.webkit.org/show_bug.cgi?id=76280
+ https://trac.webkit.org/changeset/251460
+
2019-11-11 Zalan Bujtas <za...@apple.com>
[LFC][IFC] Line::m_trimmableRuns does not need to be a ListHashSet
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (252324 => 252325)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2019-11-11 16:23:25 UTC (rev 252324)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2019-11-11 16:24:49 UTC (rev 252325)
@@ -2369,16 +2369,11 @@
if (hasMediaControls() && m_player->didLoadingProgress())
mediaControls()->bufferingProgressed();
- // Schedule one last *synchronous* progress event so we guarantee
- // that at least one is fired for files that load very
- // quickly. This must be synchronous since it's very easy for the
- // async queue to dispatch this to JS after we set m_networkState
- // to IDLE below, which breaks the invariant of onprogress
- // happening during NETWORK_LOADING.
- dispatchEvent(Event::create(eventNames().progressEvent, Event::CanBubble::No, Event::IsCancelable::Yes));
-
+ // Schedule one last progress event so we guarantee that at least one is fired
+ // for files that load very quickly.
+ scheduleEvent(eventNames().progressEvent);
+ scheduleEvent(eventNames().suspendEvent);
m_networkState = NETWORK_IDLE;
- scheduleEvent(eventNames().suspendEvent);
}
void HTMLMediaElement::mediaPlayerReadyStateChanged(MediaPlayer*)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
