Title: [252355] trunk/Source/WebKit
- Revision
- 252355
- Author
- carlo...@webkit.org
- Date
- 2019-11-12 00:07:55 -0800 (Tue, 12 Nov 2019)
Log Message
REGRESSION(r250707): [GTK] UIClient::setWindowFrame only works the first time
https://bugs.webkit.org/show_bug.cgi?id=204068
Reviewed by Adrian Perez de Castro.
This is because we are connecting to configure-event of parent window, but not returning FALSE from the callback
to propagate the event.
* UIProcess/API/glib/WebKitUIClient.cpp:
(UIClient::windowConfigureEventCallback): Make it boolean and return FALSE.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (252354 => 252355)
--- trunk/Source/WebKit/ChangeLog 2019-11-12 02:56:48 UTC (rev 252354)
+++ trunk/Source/WebKit/ChangeLog 2019-11-12 08:07:55 UTC (rev 252355)
@@ -1,3 +1,16 @@
+2019-11-12 Carlos Garcia Campos <cgar...@igalia.com>
+
+ REGRESSION(r250707): [GTK] UIClient::setWindowFrame only works the first time
+ https://bugs.webkit.org/show_bug.cgi?id=204068
+
+ Reviewed by Adrian Perez de Castro.
+
+ This is because we are connecting to configure-event of parent window, but not returning FALSE from the callback
+ to propagate the event.
+
+ * UIProcess/API/glib/WebKitUIClient.cpp:
+ (UIClient::windowConfigureEventCallback): Make it boolean and return FALSE.
+
2019-11-11 Alex Christensen <achristen...@webkit.org>
Add SPI to access a WebsiteDataStore without instantiating it, and its configuration
Modified: trunk/Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp (252354 => 252355)
--- trunk/Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp 2019-11-12 02:56:48 UTC (rev 252354)
+++ trunk/Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp 2019-11-12 08:07:55 UTC (rev 252355)
@@ -139,7 +139,7 @@
}
#if PLATFORM(GTK)
- static void windowConfigureEventCallback(GtkWindow* window, GdkEventConfigure*, GdkRectangle* targetGeometry)
+ static gboolean windowConfigureEventCallback(GtkWindow* window, GdkEventConfigure*, GdkRectangle* targetGeometry)
{
GdkRectangle geometry = { 0, 0, 0, 0 };
gtk_window_get_position(window, &geometry.x, &geometry.y);
@@ -146,6 +146,8 @@
gtk_window_get_size(window, &geometry.width, &geometry.height);
if (geometry.x == targetGeometry->x && geometry.y == targetGeometry->y && geometry.width == targetGeometry->width && geometry.height == targetGeometry->height)
RunLoop::current().stop();
+
+ return FALSE;
}
void setWindowFrameTimerFired()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
