Title: [252402] trunk/Source/WebCore
- Revision
- 252402
- Author
- [email protected]
- Date
- 2019-11-13 04:31:54 -0800 (Wed, 13 Nov 2019)
Log Message
Unreviewed, fix GTK/WPE builds after enabling POINTER_EVENTS support.
Our g++ 8.3.0 yields "error: call to non-constexpr function
WTFReportAssertionFailure" when compiling rendering/EventRegion.cpp
since r252366.
Simply remove the ASSERT_NOT_REACHED() from toIndex(): a missing value
in the switch statement will be caught by compiler warnings. Remove the
constexpr flag from toTouchAction(): in this case, the
ASSERT_NOT_REACHED() is useful and should stay.
Rubber-stamped by Philippe Normand.
* rendering/EventRegion.cpp:
(WebCore::toIndex): Remove call to ASSERT_NOT_REACHED().
(WebCore::toTouchAction): Keep ASSERT_NOT_REACHED(), removed constexpr.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (252401 => 252402)
--- trunk/Source/WebCore/ChangeLog 2019-11-13 12:15:55 UTC (rev 252401)
+++ trunk/Source/WebCore/ChangeLog 2019-11-13 12:31:54 UTC (rev 252402)
@@ -1,3 +1,22 @@
+2019-11-13 Nikolas Zimmermann <[email protected]>
+
+ Unreviewed, fix GTK/WPE builds after enabling POINTER_EVENTS support.
+
+ Our g++ 8.3.0 yields "error: call to non-constexpr function
+ WTFReportAssertionFailure" when compiling rendering/EventRegion.cpp
+ since r252366.
+
+ Simply remove the ASSERT_NOT_REACHED() from toIndex(): a missing value
+ in the switch statement will be caught by compiler warnings. Remove the
+ constexpr flag from toTouchAction(): in this case, the
+ ASSERT_NOT_REACHED() is useful and should stay.
+
+ Rubber-stamped by Philippe Normand.
+
+ * rendering/EventRegion.cpp:
+ (WebCore::toIndex): Remove call to ASSERT_NOT_REACHED().
+ (WebCore::toTouchAction): Keep ASSERT_NOT_REACHED(), removed constexpr.
+
2019-11-13 Philippe Normand <[email protected]>
Unreviewed, fix build for accessibility disabled.
Modified: trunk/Source/WebCore/rendering/EventRegion.cpp (252401 => 252402)
--- trunk/Source/WebCore/rendering/EventRegion.cpp 2019-11-13 12:15:55 UTC (rev 252401)
+++ trunk/Source/WebCore/rendering/EventRegion.cpp 2019-11-13 12:31:54 UTC (rev 252402)
@@ -144,11 +144,10 @@
case TouchAction::Auto:
break;
}
- ASSERT_NOT_REACHED();
return 0;
}
-constexpr TouchAction toTouchAction(unsigned index)
+TouchAction toTouchAction(unsigned index)
{
switch (index) {
case 0:
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
