Title: [252420] trunk/LayoutTests
- Revision
- 252420
- Author
- [email protected]
- Date
- 2019-11-13 11:36:39 -0800 (Wed, 13 Nov 2019)
Log Message
Web Inspector: inspector/model/remote-object-weak-collection.html is failing
https://bugs.webkit.org/show_bug.cgi?id=202932
Reviewed by Brian Burg.
* inspector/model/remote-object-weak-collection.html:
Don't `generatePreview` when evaluating each _expression_, as that can create additional
references to the object. Use `HeapAgent.gc()` as that's guaranteed to be synchronous.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (252419 => 252420)
--- trunk/LayoutTests/ChangeLog 2019-11-13 19:22:54 UTC (rev 252419)
+++ trunk/LayoutTests/ChangeLog 2019-11-13 19:36:39 UTC (rev 252420)
@@ -1,3 +1,14 @@
+2019-11-13 Devin Rousso <[email protected]>
+
+ Web Inspector: inspector/model/remote-object-weak-collection.html is failing
+ https://bugs.webkit.org/show_bug.cgi?id=202932
+
+ Reviewed by Brian Burg.
+
+ * inspector/model/remote-object-weak-collection.html:
+ Don't `generatePreview` when evaluating each _expression_, as that can create additional
+ references to the object. Use `HeapAgent.gc()` as that's guaranteed to be synchronous.
+
2019-11-13 Antti Koivisto <[email protected]>
Google Docs spreadsheet tiles render very slowly (because of event region painting)
Modified: trunk/LayoutTests/inspector/model/remote-object-weak-collection.html (252419 => 252420)
--- trunk/LayoutTests/inspector/model/remote-object-weak-collection.html 2019-11-13 19:22:54 UTC (rev 252419)
+++ trunk/LayoutTests/inspector/model/remote-object-weak-collection.html 2019-11-13 19:36:39 UTC (rev 252420)
@@ -54,9 +54,13 @@
// Run the _expression_, and then run a garbage collection on a different
// event loop so no objects are kept alive by the stack.
- WI.runtimeManager.evaluateInInspectedWindow(step._expression_, {objectGroup: "test", doNotPauseOnExceptionsAndMuteConsole: true, generatePreview: true}, function(remoteObject, wasThrown) {
- WI.runtimeManager.evaluateInInspectedWindow("GCController.collect()", {objectGroup: "test", doNotPauseOnExceptionsAndMuteConsole: true}, function() {
- InspectorTest.assert(remoteObject instanceof WI.RemoteObject);
+ WI.runtimeManager.evaluateInInspectedWindow(step._expression_, {objectGroup: "test", doNotPauseOnExceptionsAndMuteConsole: true}, function(remoteObject, wasThrown) {
+ InspectorTest.assert(remoteObject instanceof WI.RemoteObject);
+ InspectorTest.assert(!wasThrown);
+
+ HeapAgent.gc(function(error) {
+ InspectorTest.assert(!error, error);
+
remoteObject.getCollectionEntries(function(entries) {
InspectorTest.log("ENTRIES:");
entries.sort((a, b) => a.value.value - b.value.value);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
