Title: [252426] tags/Safari-609.1.9.5
- Revision
- 252426
- Author
- [email protected]
- Date
- 2019-11-13 13:11:09 -0800 (Wed, 13 Nov 2019)
Log Message
Cherry-pick r252116. rdar://problem/57162237
Temporarily turn off NSURLSession isolation
https://bugs.webkit.org/show_bug.cgi?id=201822
Reviewed by Chris Dumez.
Source/WebKit:
Existing tests skipped.
Re-enabling it is tracked in rdar://problem/56921584.
* NetworkProcess/cache/NetworkCacheStorage.h:
Bumps the version to force a clean cache.
* NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
Skips setting needsIsolatedSession.
LayoutTests:
Re-enabling it is tracked in rdar://problem/56921584.
* platform/wk2/TestExpectations:
Skipped the associated tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@252116 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: tags/Safari-609.1.9.5/LayoutTests/ChangeLog (252425 => 252426)
--- tags/Safari-609.1.9.5/LayoutTests/ChangeLog 2019-11-13 21:07:16 UTC (rev 252425)
+++ tags/Safari-609.1.9.5/LayoutTests/ChangeLog 2019-11-13 21:11:09 UTC (rev 252426)
@@ -1,3 +1,46 @@
+2019-11-13 Kocsen Chung <[email protected]>
+
+ Cherry-pick r252116. rdar://problem/57162237
+
+ Temporarily turn off NSURLSession isolation
+ https://bugs.webkit.org/show_bug.cgi?id=201822
+
+ Reviewed by Chris Dumez.
+
+ Source/WebKit:
+
+ Existing tests skipped.
+
+ Re-enabling it is tracked in rdar://problem/56921584.
+
+ * NetworkProcess/cache/NetworkCacheStorage.h:
+ Bumps the version to force a clean cache.
+ * NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
+ (WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
+ Skips setting needsIsolatedSession.
+
+ LayoutTests:
+
+ Re-enabling it is tracked in rdar://problem/56921584.
+
+ * platform/wk2/TestExpectations:
+ Skipped the associated tests.
+
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@252116 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2019-11-05 John Wilander <[email protected]>
+
+ Temporarily turn off NSURLSession isolation
+ https://bugs.webkit.org/show_bug.cgi?id=201822
+
+ Reviewed by Chris Dumez.
+
+ Re-enabling it is tracked in rdar://problem/56921584.
+
+ * platform/wk2/TestExpectations:
+ Skipped the associated tests.
+
2019-10-30 Alan Coon <[email protected]>
Cherry-pick r251710. rdar://problem/56689789
Modified: tags/Safari-609.1.9.5/LayoutTests/platform/wk2/TestExpectations (252425 => 252426)
--- tags/Safari-609.1.9.5/LayoutTests/platform/wk2/TestExpectations 2019-11-13 21:07:16 UTC (rev 252425)
+++ tags/Safari-609.1.9.5/LayoutTests/platform/wk2/TestExpectations 2019-11-13 21:11:09 UTC (rev 252426)
@@ -746,6 +746,10 @@
http/tests/resourceLoadStatistics/non-prevalent-resources-can-access-cookies-in-a-third-party-context.html [ Skip ]
http/tests/resourceLoadStatistics/cap-cache-max-age-for-prevalent-resource.html [ Skip ]
+# rdar://problem/56921584
+http/tests/resourceLoadStatistics/switch-session-on-navigation-to-prevalent-with-interaction.php [ Skip ]
+http/tests/resourceLoadStatistics/switch-session-on-navigation-to-prevalent-with-interaction-database.php [ Skip ]
+
# This feature is currently disabled by default and unfinished <rdar://problem/38925077>.
http/tests/navigation/process-swap-window-open.html [ Skip ]
Modified: tags/Safari-609.1.9.5/Source/WebKit/ChangeLog (252425 => 252426)
--- tags/Safari-609.1.9.5/Source/WebKit/ChangeLog 2019-11-13 21:07:16 UTC (rev 252425)
+++ tags/Safari-609.1.9.5/Source/WebKit/ChangeLog 2019-11-13 21:11:09 UTC (rev 252426)
@@ -1,3 +1,51 @@
+2019-11-13 Kocsen Chung <[email protected]>
+
+ Cherry-pick r252116. rdar://problem/57162237
+
+ Temporarily turn off NSURLSession isolation
+ https://bugs.webkit.org/show_bug.cgi?id=201822
+
+ Reviewed by Chris Dumez.
+
+ Source/WebKit:
+
+ Existing tests skipped.
+
+ Re-enabling it is tracked in rdar://problem/56921584.
+
+ * NetworkProcess/cache/NetworkCacheStorage.h:
+ Bumps the version to force a clean cache.
+ * NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
+ (WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
+ Skips setting needsIsolatedSession.
+
+ LayoutTests:
+
+ Re-enabling it is tracked in rdar://problem/56921584.
+
+ * platform/wk2/TestExpectations:
+ Skipped the associated tests.
+
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@252116 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2019-11-05 John Wilander <[email protected]>
+
+ Temporarily turn off NSURLSession isolation
+ https://bugs.webkit.org/show_bug.cgi?id=201822
+
+ Reviewed by Chris Dumez.
+
+ Existing tests skipped.
+
+ Re-enabling it is tracked in rdar://problem/56921584.
+
+ * NetworkProcess/cache/NetworkCacheStorage.h:
+ Bumps the version to force a clean cache.
+ * NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
+ (WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
+ Skips setting needsIsolatedSession.
+
2019-11-01 Kocsen Chung <[email protected]>
Cherry-pick r251897. rdar://problem/56765698
Modified: tags/Safari-609.1.9.5/Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h (252425 => 252426)
--- tags/Safari-609.1.9.5/Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h 2019-11-13 21:07:16 UTC (rev 252425)
+++ tags/Safari-609.1.9.5/Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h 2019-11-13 21:11:09 UTC (rev 252426)
@@ -107,7 +107,7 @@
size_t approximateSize() const;
// Incrementing this number will delete all existing cache content for everyone. Do you really need to do it?
- static const unsigned version = 14;
+ static const unsigned version = 15;
#if PLATFORM(MAC)
/// Allow the last stable version of the cache to co-exist with the latest development one.
static const unsigned lastStableVersion = 13;
Modified: tags/Safari-609.1.9.5/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm (252425 => 252426)
--- tags/Safari-609.1.9.5/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm 2019-11-13 21:07:16 UTC (rev 252425)
+++ tags/Safari-609.1.9.5/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm 2019-11-13 21:11:09 UTC (rev 252426)
@@ -213,7 +213,7 @@
if (auto* networkStorageSession = session.networkStorageSession()) {
if (!shouldBlockCookies)
shouldBlockCookies = networkStorageSession->shouldBlockCookies(request, frameID, pageID);
- needsIsolatedSession = networkStorageSession->shouldBlockThirdPartyCookiesButKeepFirstPartyCookiesFor(firstParty);
+ // FIXME: <rdar://problem/56921584> needsIsolatedSession should be set here.
}
#endif
restrictRequestReferrerToOriginIfNeeded(request);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
