Title: [252469] trunk/Source/WebKit
- Revision
- 252469
- Author
- [email protected]
- Date
- 2019-11-14 16:31:01 -0800 (Thu, 14 Nov 2019)
Log Message
Make NetworkResourceLoader::didReceiveResponse more straightforward after r244700
https://bugs.webkit.org/show_bug.cgi?id=204134
Patch by Alex Christensen <[email protected]> on 2019-11-14
Reviewed by Youenn Fablet.
If m_isKeptAlive is true, we do not want to receive any HTTP body.
Rather than storing the CompletionHandler and relying on the destructor to call it, just call it.
No change in behavior.
* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didReceiveResponse):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (252468 => 252469)
--- trunk/Source/WebKit/ChangeLog 2019-11-15 00:16:57 UTC (rev 252468)
+++ trunk/Source/WebKit/ChangeLog 2019-11-15 00:31:01 UTC (rev 252469)
@@ -1,3 +1,18 @@
+2019-11-14 Alex Christensen <[email protected]>
+
+ Make NetworkResourceLoader::didReceiveResponse more straightforward after r244700
+ https://bugs.webkit.org/show_bug.cgi?id=204134
+
+ Reviewed by Youenn Fablet.
+
+ If m_isKeptAlive is true, we do not want to receive any HTTP body.
+ Rather than storing the CompletionHandler and relying on the destructor to call it, just call it.
+
+ No change in behavior.
+
+ * NetworkProcess/NetworkResourceLoader.cpp:
+ (WebKit::NetworkResourceLoader::didReceiveResponse):
+
2019-11-14 Chris Dumez <[email protected]>
[iOS] Crash under WebProcess::processTaskStateDidChange(WebKit::ProcessTaskStateObserver::TaskState)
Modified: trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp (252468 => 252469)
--- trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp 2019-11-15 00:16:57 UTC (rev 252468)
+++ trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp 2019-11-15 00:31:01 UTC (rev 252469)
@@ -530,13 +530,8 @@
return;
}
- if (m_isKeptAlive) {
- m_responseCompletionHandler = WTFMove(completionHandler);
- RunLoop::main().dispatch([protectedThis = makeRef(*this)] {
- protectedThis->didFinishLoading(NetworkLoadMetrics { });
- });
- return;
- }
+ if (m_isKeptAlive)
+ return completionHandler(PolicyAction::Ignore);
completionHandler(PolicyAction::Use);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
