Title: [252485] trunk/Tools
- Revision
- 252485
- Author
- [email protected]
- Date
- 2019-11-15 08:39:25 -0800 (Fri, 15 Nov 2019)
Log Message
[ews] Perform validation of patch before retrying JSC tests
https://bugs.webkit.org/show_bug.cgi?id=204222
Reviewed by Jonathan Bedard.
* BuildSlaveSupport/ews-build/steps.py:
(RunJavaScriptCoreTests.evaluateCommand): Add a ValidatePatch step before retrying.
(ReRunJavaScriptCoreTests.evaluateCommand): Ditto.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps.py (252484 => 252485)
--- trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2019-11-15 16:36:23 UTC (rev 252484)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2019-11-15 16:39:25 UTC (rev 252485)
@@ -974,7 +974,7 @@
self.build.results = SUCCESS
self.build.buildFinished([message], SUCCESS)
else:
- self.build.addStepsAfterCurrentStep([ReRunJavaScriptCoreTests()])
+ self.build.addStepsAfterCurrentStep([ValidatePatch(verifyBugClosed=False, addURLs=False), ReRunJavaScriptCoreTests()])
return rc
def commandComplete(self, cmd):
@@ -1046,7 +1046,12 @@
self.build.buildFinished([message], SUCCESS)
else:
self.setProperty('patchFailedTests', True)
- self.build.addStepsAfterCurrentStep([UnApplyPatchIfRequired(), CompileJSCToT(), RunJSCTestsWithoutPatch(), AnalyzeJSCTestsResults()])
+ self.build.addStepsAfterCurrentStep([UnApplyPatchIfRequired(),
+ ValidatePatch(verifyBugClosed=False, addURLs=False),
+ CompileJSCToT(),
+ ValidatePatch(verifyBugClosed=False, addURLs=False),
+ RunJSCTestsWithoutPatch(),
+ AnalyzeJSCTestsResults()])
return rc
Modified: trunk/Tools/ChangeLog (252484 => 252485)
--- trunk/Tools/ChangeLog 2019-11-15 16:36:23 UTC (rev 252484)
+++ trunk/Tools/ChangeLog 2019-11-15 16:39:25 UTC (rev 252485)
@@ -1,3 +1,14 @@
+2019-11-15 Aakash Jain <[email protected]>
+
+ [ews] Perform validation of patch before retrying JSC tests
+ https://bugs.webkit.org/show_bug.cgi?id=204222
+
+ Reviewed by Jonathan Bedard.
+
+ * BuildSlaveSupport/ews-build/steps.py:
+ (RunJavaScriptCoreTests.evaluateCommand): Add a ValidatePatch step before retrying.
+ (ReRunJavaScriptCoreTests.evaluateCommand): Ditto.
+
2019-11-14 Jonathan Bedard <[email protected]>
Python 3: Add support in webkitpy.layout_tests.layout_package
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
