Title: [252489] trunk/Tools
- Revision
- 252489
- Author
- [email protected]
- Date
- 2019-11-15 10:00:42 -0800 (Fri, 15 Nov 2019)
Log Message
run-webkit-tests loads committers.py 4 times, taking about 40ms
https://bugs.webkit.org/show_bug.cgi?id=204211
Reviewed by Aakash Jain.
* Scripts/webkitpy/common/checkout/changelog.py:
(ChangeLogEntry): Don't create CommitterList on import.
* Scripts/webkitpy/common/checkout/commitinfo.py:
(CommitInfo.__init__): Ditto.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (252488 => 252489)
--- trunk/Tools/ChangeLog 2019-11-15 17:14:07 UTC (rev 252488)
+++ trunk/Tools/ChangeLog 2019-11-15 18:00:42 UTC (rev 252489)
@@ -1,3 +1,15 @@
+2019-11-15 Jonathan Bedard <[email protected]>
+
+ run-webkit-tests loads committers.py 4 times, taking about 40ms
+ https://bugs.webkit.org/show_bug.cgi?id=204211
+
+ Reviewed by Aakash Jain.
+
+ * Scripts/webkitpy/common/checkout/changelog.py:
+ (ChangeLogEntry): Don't create CommitterList on import.
+ * Scripts/webkitpy/common/checkout/commitinfo.py:
+ (CommitInfo.__init__): Ditto.
+
2019-11-15 Aakash Jain <[email protected]>
[ews] Perform validation of patch before retrying JSC tests
Modified: trunk/Tools/Scripts/webkitpy/common/checkout/changelog.py (252488 => 252489)
--- trunk/Tools/Scripts/webkitpy/common/checkout/changelog.py 2019-11-15 17:14:07 UTC (rev 252488)
+++ trunk/Tools/Scripts/webkitpy/common/checkout/changelog.py 2019-11-15 18:00:42 UTC (rev 252489)
@@ -107,9 +107,9 @@
split_names_regexp = r'\s*(?:,(?:\s+and\s+|&)?|(?:^|\s+)and\s+|&&|[/+&])\s*'
- def __init__(self, contents, committer_list=CommitterList(), revision=None):
+ def __init__(self, contents, committer_list=None, revision=None):
self._contents = contents
- self._committer_list = committer_list
+ self._committer_list = committer_list or CommitterList()
self._revision = revision
self._parse_entry()
Modified: trunk/Tools/Scripts/webkitpy/common/checkout/commitinfo.py (252488 => 252489)
--- trunk/Tools/Scripts/webkitpy/common/checkout/commitinfo.py 2019-11-15 17:14:07 UTC (rev 252488)
+++ trunk/Tools/Scripts/webkitpy/common/checkout/commitinfo.py 2019-11-15 18:00:42 UTC (rev 252489)
@@ -33,13 +33,13 @@
class CommitInfo(object):
- def __init__(self, revision, committer_email, changelog_data, committer_list=CommitterList()):
+ def __init__(self, revision, committer_email, changelog_data, committer_list=None):
self._revision = revision
self._committer_email = committer_email
self._changelog_data = changelog_data
# Derived values:
- self._committer = committer_list.committer_by_email(committer_email)
+ self._committer = (committer_list or CommitterList()).committer_by_email(committer_email)
def revision(self):
return self._revision
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
