Title: [252600] trunk/Tools
- Revision
- 252600
- Author
- cdu...@apple.com
- Date
- 2019-11-18 15:25:00 -0800 (Mon, 18 Nov 2019)
Log Message
TestWebKitAPI.ProcessSwap.QuickBackForwardNavigationWithPSON is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=199645
<rdar://problem/52856112>
Reviewed by Alex Christensen.
Make sure the test waits for the history navigations to complete before checking the
back/forward list.
* TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (252599 => 252600)
--- trunk/Tools/ChangeLog 2019-11-18 23:21:15 UTC (rev 252599)
+++ trunk/Tools/ChangeLog 2019-11-18 23:25:00 UTC (rev 252600)
@@ -1,3 +1,16 @@
+2019-11-18 Chris Dumez <cdu...@apple.com>
+
+ TestWebKitAPI.ProcessSwap.QuickBackForwardNavigationWithPSON is a flaky crash
+ https://bugs.webkit.org/show_bug.cgi?id=199645
+ <rdar://problem/52856112>
+
+ Reviewed by Alex Christensen.
+
+ Make sure the test waits for the history navigations to complete before checking the
+ back/forward list.
+
+ * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
+
2019-11-18 Keith Rollin <krol...@apple.com>
Move jsc from Resources to Helpers
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm (252599 => 252600)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm 2019-11-18 23:21:15 UTC (rev 252599)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm 2019-11-18 23:25:00 UTC (rev 252600)
@@ -2324,6 +2324,9 @@
TestWebKitAPI::Util::spinRunLoop(0.1);
}
+ TestWebKitAPI::Util::run(&done);
+ done = false;
+
Vector<String> backForwardListURLs;
auto* backForwardList = [webView backForwardList];
for (unsigned i = 0; i < backForwardList.backList.count; ++i)
@@ -2331,7 +2334,7 @@
backForwardListURLs.append([backForwardList.currentItem.URL absoluteString]);
for (unsigned i = 0; i < backForwardList.forwardList.count; ++i)
backForwardListURLs.append([backForwardList.forwardList[i].URL absoluteString]);
- EXPECT_EQ(3u, backForwardListURLs.size());
+ RELEASE_ASSERT(backForwardListURLs.size() == 3u);
EXPECT_WK_STREQ("pson://www.webkit.org/main1.html", backForwardListURLs[0]);
EXPECT_WK_STREQ("pson://www.webkit.org/main2.html", backForwardListURLs[1]);
EXPECT_WK_STREQ("pson://www.apple.com/main.html", backForwardListURLs[2]);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
