Title: [252626] trunk/Source/WebCore
- Revision
- 252626
- Author
- [email protected]
- Date
- 2019-11-19 06:23:46 -0800 (Tue, 19 Nov 2019)
Log Message
http/tests/navigation/page-cache-mediastream.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=204321
Reviewed by Eric Carlson.
Make sure the MediaStreamTrack stays alive if there is a pending ended event to dispatch.
No new tests, covered by existing test.
* Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::hasPendingActivity const):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (252625 => 252626)
--- trunk/Source/WebCore/ChangeLog 2019-11-19 12:45:53 UTC (rev 252625)
+++ trunk/Source/WebCore/ChangeLog 2019-11-19 14:23:46 UTC (rev 252626)
@@ -1,3 +1,17 @@
+2019-11-19 Chris Dumez <[email protected]>
+
+ http/tests/navigation/page-cache-mediastream.html is a flaky crash
+ https://bugs.webkit.org/show_bug.cgi?id=204321
+
+ Reviewed by Eric Carlson.
+
+ Make sure the MediaStreamTrack stays alive if there is a pending ended event to dispatch.
+
+ No new tests, covered by existing test.
+
+ * Modules/mediastream/MediaStreamTrack.cpp:
+ (WebCore::MediaStreamTrack::hasPendingActivity const):
+
2019-11-19 Thibault Saunier <[email protected]>
REGRESSION(r249428): [GStreamer] VP9 video rendered green
Modified: trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp (252625 => 252626)
--- trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp 2019-11-19 12:45:53 UTC (rev 252625)
+++ trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp 2019-11-19 14:23:46 UTC (rev 252626)
@@ -573,7 +573,7 @@
bool MediaStreamTrack::hasPendingActivity() const
{
- return !m_ended;
+ return !m_ended || ActiveDOMObject::hasPendingActivity();
}
AudioSourceProvider* MediaStreamTrack::audioSourceProvider()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
