Diff
Modified: trunk/LayoutTests/ChangeLog (252632 => 252633)
--- trunk/LayoutTests/ChangeLog 2019-11-19 16:50:55 UTC (rev 252632)
+++ trunk/LayoutTests/ChangeLog 2019-11-19 16:51:33 UTC (rev 252633)
@@ -1,3 +1,13 @@
+2019-11-19 Sihui Liu <[email protected]>
+
+ Update expectations for bufferedAmount-unchanged-by-sync-xhr.any.worker.html
+ https://bugs.webkit.org/show_bug.cgi?id=204313
+
+ Reviewed by Alex Christensen.
+
+ * platform/ios-wk2/TestExpectations:
+ * platform/mac-wk2/TestExpectations:
+
2019-11-19 Eric Carlson <[email protected]>
OverConstrainedError is missing 'name' property
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (252632 => 252633)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2019-11-19 16:50:55 UTC (rev 252632)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2019-11-19 16:51:33 UTC (rev 252633)
@@ -1,3 +1,12 @@
+2019-11-19 Sihui Liu <[email protected]>
+
+ Update expectations for bufferedAmount-unchanged-by-sync-xhr.any.worker.html
+ https://bugs.webkit.org/show_bug.cgi?id=204313
+
+ Reviewed by Alex Christensen.
+
+ * web-platform-tests/websockets/bufferedAmount-unchanged-by-sync-xhr.any.worker-expected.txt:
+
2019-11-19 Eric Carlson <[email protected]>
OverConstrainedError is missing 'name' property
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/websockets/bufferedAmount-unchanged-by-sync-xhr.any.worker-expected.txt (252632 => 252633)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/websockets/bufferedAmount-unchanged-by-sync-xhr.any.worker-expected.txt 2019-11-19 16:50:55 UTC (rev 252632)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/websockets/bufferedAmount-unchanged-by-sync-xhr.any.worker-expected.txt 2019-11-19 16:51:33 UTC (rev 252633)
@@ -1,3 +1,3 @@
-FAIL bufferedAmount should not be updated during a sync XHR assert_unreached: open should succeed Reached unreachable code
+FAIL bufferedAmount should not be updated during a sync XHR assert_equals: expected 5 but got 0
Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (252632 => 252633)
--- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2019-11-19 16:50:55 UTC (rev 252632)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2019-11-19 16:51:33 UTC (rev 252633)
@@ -1314,8 +1314,6 @@
webkit.org/b/197662 [ Debug ] imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-getStats.https.html [ Pass Failure ]
-webkit.org/b/198774 imported/w3c/web-platform-tests/websockets/bufferedAmount-unchanged-by-sync-xhr.any.worker.html [ Failure ]
-
webkit.org/b/176030 http/tests/websocket/tests/hybi/send-object-tostring-check.html [ Pass Failure ]
webkit.org/b/199013 [ Debug ] imported/w3c/web-platform-tests/websockets/Create-Secure-verify-url-set-non-default-port.any.html [ Pass Failure ]
Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (252632 => 252633)
--- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2019-11-19 16:50:55 UTC (rev 252632)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2019-11-19 16:51:33 UTC (rev 252633)
@@ -913,8 +913,6 @@
webkit.org/b/198663 http/tests/storageAccess/request-and-grant-access-then-navigate-same-site-should-have-access.html [ Pass Timeout ]
-webkit.org/b/198774 imported/w3c/web-platform-tests/websockets/bufferedAmount-unchanged-by-sync-xhr.any.worker.html [ Failure ]
-
webkit.org/b/176030 [ Debug ] http/tests/websocket/tests/hybi/send-object-tostring-check.html [ Pass Failure ]
webkit.org/b/198921 [ Mojave+ ] webgpu/blend-color-triangle-strip.html [ Pass ImageOnlyFailure ]
Modified: trunk/Source/WebCore/ChangeLog (252632 => 252633)
--- trunk/Source/WebCore/ChangeLog 2019-11-19 16:50:55 UTC (rev 252632)
+++ trunk/Source/WebCore/ChangeLog 2019-11-19 16:51:33 UTC (rev 252633)
@@ -1,3 +1,22 @@
+2019-11-19 Sihui Liu <[email protected]>
+
+ Update expectations for bufferedAmount-unchanged-by-sync-xhr.any.worker.html
+ https://bugs.webkit.org/show_bug.cgi?id=204313
+
+ Reviewed by Alex Christensen.
+
+ Add some logging to help debug the flaky timeout of bufferedAmount-unchanged-by-sync-xhr.any.worker.html on
+ commit-queue bot.
+
+ * Modules/websockets/WebSocketChannel.cpp:
+ (WebCore::WebSocketChannel::fail):
+ (WebCore::WebSocketChannel::didFailSocketStream):
+ * platform/network/cf/SocketStreamHandleImplCFNet.cpp:
+ (WebCore::SocketStreamHandleImpl::scheduleStreams):
+ (WebCore::SocketStreamHandleImpl::readStreamCallback):
+ * testing/InternalSettings.cpp:
+ (WebCore::InternalSettings::Backup::restoreTo):Remove a duplicate setting.
+
2019-11-19 Eric Carlson <[email protected]>
OverConstrainedError is missing 'name' property
Modified: trunk/Source/WebCore/Modules/websockets/WebSocketChannel.cpp (252632 => 252633)
--- trunk/Source/WebCore/Modules/websockets/WebSocketChannel.cpp 2019-11-19 16:50:55 UTC (rev 252632)
+++ trunk/Source/WebCore/Modules/websockets/WebSocketChannel.cpp 2019-11-19 16:51:33 UTC (rev 252633)
@@ -203,7 +203,7 @@
void WebSocketChannel::fail(const String& reason)
{
- LOG(Network, "WebSocketChannel %p fail() reason='%s'", this, reason.utf8().data());
+ RELEASE_LOG(Network, "WebSocketChannel %p fail() reason='%s'", this, reason.utf8().data());
ASSERT(!m_suspended);
if (m_document) {
InspectorInstrumentation::didReceiveWebSocketFrameError(m_document.get(), m_identifier, reason);
@@ -363,6 +363,7 @@
message = "WebSocket network error: " + error.localizedDescription();
InspectorInstrumentation::didReceiveWebSocketFrameError(m_document.get(), m_identifier, message);
m_document->addConsoleMessage(MessageSource::Network, MessageLevel::Error, message);
+ LOG_ERROR("%s", message.utf8().data());
}
m_shouldDiscardReceivedData = true;
if (m_client)
Modified: trunk/Source/WebCore/platform/network/cf/SocketStreamHandleImplCFNet.cpp (252632 => 252633)
--- trunk/Source/WebCore/platform/network/cf/SocketStreamHandleImplCFNet.cpp 2019-11-19 16:50:55 UTC (rev 252632)
+++ trunk/Source/WebCore/platform/network/cf/SocketStreamHandleImplCFNet.cpp 2019-11-19 16:51:33 UTC (rev 252633)
@@ -154,6 +154,7 @@
removePACRunLoopSource();
m_connectingSubstate = WaitingForConnect;
+ RELEASE_LOG(Network, "SocketStreamHandleImpl::scheduleStreams - m_connectionSubState is WaitingForConnect");
}
void* SocketStreamHandleImpl::retainSocketStreamHandle(void* info)
@@ -578,6 +579,7 @@
return;
}
}
+ RELEASE_LOG(Network, "SocketStreamHandleImpl::readStreamCallback - m_connectionSubState is Connected");
m_connectingSubstate = Connected;
m_state = Open;
m_client.didOpenSocketStream(*this);
Modified: trunk/Source/WebCore/testing/InternalSettings.cpp (252632 => 252633)
--- trunk/Source/WebCore/testing/InternalSettings.cpp 2019-11-19 16:50:55 UTC (rev 252632)
+++ trunk/Source/WebCore/testing/InternalSettings.cpp 2019-11-19 16:51:33 UTC (rev 252633)
@@ -207,7 +207,6 @@
settings.setForcedDisplayIsMonochromeAccessibilityValue(m_forcedDisplayIsMonochromeAccessibilityValue);
settings.setForcedPrefersReducedMotionAccessibilityValue(m_forcedPrefersReducedMotionAccessibilityValue);
settings.setFontLoadTimingOverride(m_fontLoadTimingOverride);
- DeprecatedGlobalSettings::setAllowsAnySSLCertificate(false);
RenderTheme::singleton().setShouldMockBoldSystemFontForAccessibility(m_shouldMockBoldSystemFontForAccessibility);
FontCache::singleton().setShouldMockBoldSystemFontForAccessibility(m_shouldMockBoldSystemFontForAccessibility);
settings.setFrameFlattening(m_frameFlattening);
Modified: trunk/Tools/ChangeLog (252632 => 252633)
--- trunk/Tools/ChangeLog 2019-11-19 16:50:55 UTC (rev 252632)
+++ trunk/Tools/ChangeLog 2019-11-19 16:51:33 UTC (rev 252633)
@@ -1,3 +1,13 @@
+2019-11-19 Sihui Liu <[email protected]>
+
+ Update expectations for bufferedAmount-unchanged-by-sync-xhr.any.worker.html
+ https://bugs.webkit.org/show_bug.cgi?id=204313
+
+ Reviewed by Alex Christensen.
+
+ * DumpRenderTree/mac/DumpRenderTree.mm:
+ (resetWebViewToConsistentStateBeforeTesting):
+
2019-11-19 Paulo Matos <[email protected]>
Setup EWS queues for JSConly 32bits ARMv7 and MIPSel
Modified: trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm (252632 => 252633)
--- trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2019-11-19 16:50:55 UTC (rev 252632)
+++ trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2019-11-19 16:51:33 UTC (rev 252633)
@@ -1900,7 +1900,7 @@
#endif
TestRunner::setSerializeHTTPLoads(false);
- TestRunner::setAllowsAnySSLCertificate(false);
+ TestRunner::setAllowsAnySSLCertificate(true);
setlocale(LC_ALL, "");
