Title: [252645] trunk/LayoutTests
- Revision
- 252645
- Author
- [email protected]
- Date
- 2019-11-19 13:36:54 -0800 (Tue, 19 Nov 2019)
Log Message
fast/events/touch/ios/long-press-on-link.html times out after r251693
https://bugs.webkit.org/show_bug.cgi?id=204365
<rdar://problem/57324773>
Reviewed by Megan Gardner.
The change in trac.webkit.org/r251693 inadvertently fixed a failing layout test, fast/events/touch/ios/
long-press-on-image.html. In doing so, it caused the subsequent layout test, long-press-on-link.html, to begin
failing, since both tests depend on the previous test not presenting a context menu when long pressing; if the
previous test presents a context menu, the next test will proceed while the context menu is still dismissing,
which prevents the touches from making it to the web view.
To fix this, simply mark both tests as `runSingly` in test options; this forces context menu UI to be torn down
after running these two tests, so that these tests won't have side effects when they successfully show a context
menu.
* fast/events/touch/ios/long-press-on-image.html:
* fast/events/touch/ios/long-press-on-link.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (252644 => 252645)
--- trunk/LayoutTests/ChangeLog 2019-11-19 21:21:41 UTC (rev 252644)
+++ trunk/LayoutTests/ChangeLog 2019-11-19 21:36:54 UTC (rev 252645)
@@ -1,3 +1,24 @@
+2019-11-19 Wenson Hsieh <[email protected]>
+
+ fast/events/touch/ios/long-press-on-link.html times out after r251693
+ https://bugs.webkit.org/show_bug.cgi?id=204365
+ <rdar://problem/57324773>
+
+ Reviewed by Megan Gardner.
+
+ The change in trac.webkit.org/r251693 inadvertently fixed a failing layout test, fast/events/touch/ios/
+ long-press-on-image.html. In doing so, it caused the subsequent layout test, long-press-on-link.html, to begin
+ failing, since both tests depend on the previous test not presenting a context menu when long pressing; if the
+ previous test presents a context menu, the next test will proceed while the context menu is still dismissing,
+ which prevents the touches from making it to the web view.
+
+ To fix this, simply mark both tests as `runSingly` in test options; this forces context menu UI to be torn down
+ after running these two tests, so that these tests won't have side effects when they successfully show a context
+ menu.
+
+ * fast/events/touch/ios/long-press-on-image.html:
+ * fast/events/touch/ios/long-press-on-link.html:
+
2019-11-19 John Wilander <[email protected]>
Resource Load Statistics: Count third-party script loads under top frame
Modified: trunk/LayoutTests/fast/events/touch/ios/long-press-on-image.html (252644 => 252645)
--- trunk/LayoutTests/fast/events/touch/ios/long-press-on-image.html 2019-11-19 21:21:41 UTC (rev 252644)
+++ trunk/LayoutTests/fast/events/touch/ios/long-press-on-image.html 2019-11-19 21:36:54 UTC (rev 252645)
@@ -1,4 +1,4 @@
-<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true ] -->
+<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true runSingly=true ] -->
<meta charset="utf-8">
<html>
Modified: trunk/LayoutTests/fast/events/touch/ios/long-press-on-link.html (252644 => 252645)
--- trunk/LayoutTests/fast/events/touch/ios/long-press-on-link.html 2019-11-19 21:21:41 UTC (rev 252644)
+++ trunk/LayoutTests/fast/events/touch/ios/long-press-on-link.html 2019-11-19 21:36:54 UTC (rev 252645)
@@ -1,4 +1,4 @@
-<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true ] -->
+<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true runSingly=true ] -->
<html>
<head>
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
