Modified: trunk/Source/WebCore/ChangeLog (252672 => 252673)
--- trunk/Source/WebCore/ChangeLog 2019-11-20 02:08:55 UTC (rev 252672)
+++ trunk/Source/WebCore/ChangeLog 2019-11-20 02:13:24 UTC (rev 252673)
@@ -1,5 +1,20 @@
2019-11-19 Sihui Liu <[email protected]>
+ IndexedDB: pass along error of IDBBackingStore operations
+ https://bugs.webkit.org/show_bug.cgi?id=204381
+
+ Reviewed by Brady Eidson.
+
+ Covered by existing tests.
+
+ * Modules/indexeddb/server/UniqueIDBDatabase.cpp:
+ (WebCore::IDBServer::UniqueIDBDatabase::performCreateObjectStore):
+ (WebCore::IDBServer::UniqueIDBDatabase::performDeleteObjectStore):
+ (WebCore::IDBServer::UniqueIDBDatabase::performClearObjectStore):
+ (WebCore::IDBServer::UniqueIDBDatabase::performDeleteIndex):
+
+2019-11-19 Sihui Liu <[email protected]>
+
IndexedDB: overflow of KeyGenerator in MemoryIDBBackingStore
https://bugs.webkit.org/show_bug.cgi?id=204366
Modified: trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp (252672 => 252673)
--- trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp 2019-11-20 02:08:55 UTC (rev 252672)
+++ trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp 2019-11-20 02:13:24 UTC (rev 252673)
@@ -892,9 +892,8 @@
}
ASSERT(m_backingStore);
- m_backingStore->createObjectStore(transactionIdentifier, info);
+ IDBError error = m_backingStore->createObjectStore(transactionIdentifier, info);
- IDBError error;
postDatabaseTaskReply(createCrossThreadTask(*this, &UniqueIDBDatabase::didPerformCreateObjectStore, callbackIdentifier, error, info));
}
@@ -945,9 +944,8 @@
LOG(IndexedDB, "(db) UniqueIDBDatabase::performDeleteObjectStore");
ASSERT(m_backingStore);
- m_backingStore->deleteObjectStore(transactionIdentifier, objectStoreIdentifier);
+ IDBError error = m_backingStore->deleteObjectStore(transactionIdentifier, objectStoreIdentifier);
- IDBError error;
postDatabaseTaskReply(createCrossThreadTask(*this, &UniqueIDBDatabase::didPerformDeleteObjectStore, callbackIdentifier, error, objectStoreIdentifier));
}
@@ -1048,9 +1046,8 @@
LOG(IndexedDB, "(db) UniqueIDBDatabase::performClearObjectStore");
ASSERT(m_backingStore);
- m_backingStore->clearObjectStore(transactionIdentifier, objectStoreIdentifier);
+ IDBError error = m_backingStore->clearObjectStore(transactionIdentifier, objectStoreIdentifier);
- IDBError error;
postDatabaseTaskReply(createCrossThreadTask(*this, &UniqueIDBDatabase::didPerformClearObjectStore, callbackIdentifier, error));
}
@@ -1168,9 +1165,8 @@
LOG(IndexedDB, "(db) UniqueIDBDatabase::performDeleteIndex");
ASSERT(m_backingStore);
- m_backingStore->deleteIndex(transactionIdentifier, objectStoreIdentifier, indexIdentifier);
+ IDBError error = m_backingStore->deleteIndex(transactionIdentifier, objectStoreIdentifier, indexIdentifier);
- IDBError error;
postDatabaseTaskReply(createCrossThreadTask(*this, &UniqueIDBDatabase::didPerformDeleteIndex, callbackIdentifier, error, objectStoreIdentifier, indexIdentifier));
}
