Diff
Modified: trunk/LayoutTests/ChangeLog (252675 => 252676)
--- trunk/LayoutTests/ChangeLog 2019-11-20 02:37:16 UTC (rev 252675)
+++ trunk/LayoutTests/ChangeLog 2019-11-20 02:43:37 UTC (rev 252676)
@@ -1,5 +1,21 @@
2019-11-19 Peng Liu <peng.l...@apple.com>
+ Typos in layout test names
+ https://bugs.webkit.org/show_bug.cgi?id=204387
+
+ Reviewed by Eric Carlson.
+
+ * media/video-fullscreen-only-controls-expected.txt: Renamed from LayoutTests/media/video-fullscreeen-only-controls-expected.txt.
+ * media/video-fullscreen-only-controls.html: Renamed from LayoutTests/media/video-fullscreeen-only-controls.html.
+ * media/video-fullscreen-only-playback-expected.txt: Renamed from LayoutTests/media/video-fullscreeen-only-playback-expected.txt.
+ * media/video-fullscreen-only-playback.html: Renamed from LayoutTests/media/video-fullscreeen-only-playback.html.
+ * platform/gtk/TestExpectations:
+ * platform/ios/TestExpectations:
+ * platform/mac/TestExpectations:
+ * platform/win/TestExpectations:
+
+2019-11-19 Peng Liu <peng.l...@apple.com>
+
Assertion failure in HTMLMediaElement::enterFullscreen()
https://bugs.webkit.org/show_bug.cgi?id=204376
Deleted: trunk/LayoutTests/media/video-fullscreeen-only-controls-expected.txt (252675 => 252676)
--- trunk/LayoutTests/media/video-fullscreeen-only-controls-expected.txt 2019-11-20 02:37:16 UTC (rev 252675)
+++ trunk/LayoutTests/media/video-fullscreeen-only-controls-expected.txt 2019-11-20 02:43:37 UTC (rev 252676)
@@ -1,13 +0,0 @@
-This tests that when inline-playback is restricted, the video element's "controls" are always shown while inline.
-
-
-RUN(internals.settings.setAllowsInlineMediaPlayback(false))
-EXPECTED (video.hasAttribute('controls') == 'false') OK
-EXPECTED (video.controls == 'false') OK
-EXPECTED (shadowRoot = internals.shadowRoot(video) != 'null') OK
-EXPECTED (panel = mediaControlsElement(shadowRoot.firstChild, '-webkit-media-controls-panel') != 'null') OK
-EXPECTED (internals.shadowPseudoId(panel) == '-webkit-media-controls-panel') OK
-EXPECTED (document.defaultView.getComputedStyle(panel)['display'] != 'none') OK
-EXPECTED (document.defaultView.getComputedStyle(panel)['height'] >= '20px') OK
-END OF TEST
-
Deleted: trunk/LayoutTests/media/video-fullscreeen-only-controls.html (252675 => 252676)
--- trunk/LayoutTests/media/video-fullscreeen-only-controls.html 2019-11-20 02:37:16 UTC (rev 252675)
+++ trunk/LayoutTests/media/video-fullscreeen-only-controls.html 2019-11-20 02:43:37 UTC (rev 252676)
@@ -1,33 +0,0 @@
-<!-- webkit-test-runner [ enableModernMediaControls=false ] -->
-<body>
- <p>This tests that when inline-playback is restricted, the video element's "controls" are always shown while inline.</p>
- <video id="video" width="300"></video>
- <script src=""
- <script src=""
- <script src=""
- <script>
-
- var shadowRoot;
- var panel;
-
- run("internals.settings.setAllowsInlineMediaPlayback(false)");
-
- var video = document.getElementById('video');
- video.src = "" "content/test");
-
- testExpected("video.hasAttribute('controls')", false);
- testExpected("video.controls", false);
-
- if (window.internals) {
- testExpected("shadowRoot = internals.shadowRoot(video)", null, "!=");
- testExpected("panel = mediaControlsElement(shadowRoot.firstChild, '-webkit-media-controls-panel')", null, "!=");
- testExpected("internals.shadowPseudoId(panel)", "-webkit-media-controls-panel");
- testExpected("document.defaultView.getComputedStyle(panel)['display']", 'none', "!=");
- testExpected("document.defaultView.getComputedStyle(panel)['height']", '20px', ">=");
- }
- else
- logResult(false, "window.internals == undefined");
-
- endTest();
- </script>
-</body>
Deleted: trunk/LayoutTests/media/video-fullscreeen-only-playback-expected.txt (252675 => 252676)
--- trunk/LayoutTests/media/video-fullscreeen-only-playback-expected.txt 2019-11-20 02:37:16 UTC (rev 252675)
+++ trunk/LayoutTests/media/video-fullscreeen-only-playback-expected.txt 2019-11-20 02:43:37 UTC (rev 252676)
@@ -1,19 +0,0 @@
-
-Test play() when <video> playback requires fullscreen.
-
-RUN(internals.settings.setAllowsInlineMediaPlayback(false))
-
-EVENT(canplaythrough)
-EXPECTED (video.webkitSupportsFullscreen == 'true') OK
-EXPECTED (video.webkitDisplayingFullscreen == 'false') OK
-
-** Clicking 'play' button...
-EVENT(playing)
-
-** Entered fullscreen
-EXPECTED (video.webkitDisplayingFullscreen == 'true') OK
-RUN(video.webkitExitFullScreen())
-
-** Exited fullscreen
-END OF TEST
-
Deleted: trunk/LayoutTests/media/video-fullscreeen-only-playback.html (252675 => 252676)
--- trunk/LayoutTests/media/video-fullscreeen-only-playback.html 2019-11-20 02:37:16 UTC (rev 252675)
+++ trunk/LayoutTests/media/video-fullscreeen-only-playback.html 2019-11-20 02:43:37 UTC (rev 252676)
@@ -1,70 +0,0 @@
-<!-- webkit-test-runner [ enableModernMediaControls=false ] -->
-<html>
- <head>
- <script src=""
- <script src=""
- <script src=""
- <script>
-
- function fullscreenchange()
- {
- if (!document.webkitIsFullScreen)
- endfullscreen();
- }
-
- function playing()
- {
- consoleWrite("<br>** Entered fullscreen");
- testExpected("video.webkitDisplayingFullscreen", true);
- run("video.webkitExitFullScreen()");
- }
-
- function endfullscreen()
- {
- consoleWrite("<br>** Exited fullscreen");
- endTest();
- }
-
- function canplaythrough()
- {
- testExpected("video.webkitSupportsFullscreen", true);
- testExpected("video.webkitDisplayingFullscreen", false);
-
- consoleWrite("<br>** Clicking \'play\' button...");
-
- try {
- clickPlayButton(video);
- } catch (exception) {
- failTest(exception.description);
- return;
- }
- }
-
-
- function start()
- {
- if (!window.internals) {
- failTest('This test requires window.internals.');
- return;
- }
-
- video = document.getElementsByTagName('video')[0];
- waitForEvent("canplaythrough", canplaythrough);
- waitForEvent('playing', playing);
-
- video.addEventListener('webkitendfullscreen', endfullscreen, true);
- video.addEventListener('webkitfullscreenchange', fullscreenchange, true);
-
- video.src = "" "content/test");
-
- run("internals.settings.setAllowsInlineMediaPlayback(false)");
- consoleWrite("");
- }
- </script>
- </head>
-
- <body _onload_="start()">
- <video controls></video>
- <p>Test play() when <video> playback requires fullscreen.</p>
- </body>
-</html>
Copied: trunk/LayoutTests/media/video-fullscreen-only-controls-expected.txt (from rev 252675, trunk/LayoutTests/media/video-fullscreeen-only-controls-expected.txt) (0 => 252676)
--- trunk/LayoutTests/media/video-fullscreen-only-controls-expected.txt (rev 0)
+++ trunk/LayoutTests/media/video-fullscreen-only-controls-expected.txt 2019-11-20 02:43:37 UTC (rev 252676)
@@ -0,0 +1,13 @@
+This tests that when inline-playback is restricted, the video element's "controls" are always shown while inline.
+
+
+RUN(internals.settings.setAllowsInlineMediaPlayback(false))
+EXPECTED (video.hasAttribute('controls') == 'false') OK
+EXPECTED (video.controls == 'false') OK
+EXPECTED (shadowRoot = internals.shadowRoot(video) != 'null') OK
+EXPECTED (panel = mediaControlsElement(shadowRoot.firstChild, '-webkit-media-controls-panel') != 'null') OK
+EXPECTED (internals.shadowPseudoId(panel) == '-webkit-media-controls-panel') OK
+EXPECTED (document.defaultView.getComputedStyle(panel)['display'] != 'none') OK
+EXPECTED (document.defaultView.getComputedStyle(panel)['height'] >= '20px') OK
+END OF TEST
+
Copied: trunk/LayoutTests/media/video-fullscreen-only-controls.html (from rev 252675, trunk/LayoutTests/media/video-fullscreeen-only-controls.html) (0 => 252676)
--- trunk/LayoutTests/media/video-fullscreen-only-controls.html (rev 0)
+++ trunk/LayoutTests/media/video-fullscreen-only-controls.html 2019-11-20 02:43:37 UTC (rev 252676)
@@ -0,0 +1,33 @@
+<!-- webkit-test-runner [ enableModernMediaControls=false ] -->
+<body>
+ <p>This tests that when inline-playback is restricted, the video element's "controls" are always shown while inline.</p>
+ <video id="video" width="300"></video>
+ <script src=""
+ <script src=""
+ <script src=""
+ <script>
+
+ var shadowRoot;
+ var panel;
+
+ run("internals.settings.setAllowsInlineMediaPlayback(false)");
+
+ var video = document.getElementById('video');
+ video.src = "" "content/test");
+
+ testExpected("video.hasAttribute('controls')", false);
+ testExpected("video.controls", false);
+
+ if (window.internals) {
+ testExpected("shadowRoot = internals.shadowRoot(video)", null, "!=");
+ testExpected("panel = mediaControlsElement(shadowRoot.firstChild, '-webkit-media-controls-panel')", null, "!=");
+ testExpected("internals.shadowPseudoId(panel)", "-webkit-media-controls-panel");
+ testExpected("document.defaultView.getComputedStyle(panel)['display']", 'none', "!=");
+ testExpected("document.defaultView.getComputedStyle(panel)['height']", '20px', ">=");
+ }
+ else
+ logResult(false, "window.internals == undefined");
+
+ endTest();
+ </script>
+</body>
Copied: trunk/LayoutTests/media/video-fullscreen-only-playback-expected.txt (from rev 252675, trunk/LayoutTests/media/video-fullscreeen-only-playback-expected.txt) (0 => 252676)
--- trunk/LayoutTests/media/video-fullscreen-only-playback-expected.txt (rev 0)
+++ trunk/LayoutTests/media/video-fullscreen-only-playback-expected.txt 2019-11-20 02:43:37 UTC (rev 252676)
@@ -0,0 +1,19 @@
+
+Test play() when <video> playback requires fullscreen.
+
+RUN(internals.settings.setAllowsInlineMediaPlayback(false))
+
+EVENT(canplaythrough)
+EXPECTED (video.webkitSupportsFullscreen == 'true') OK
+EXPECTED (video.webkitDisplayingFullscreen == 'false') OK
+
+** Clicking 'play' button...
+EVENT(playing)
+
+** Entered fullscreen
+EXPECTED (video.webkitDisplayingFullscreen == 'true') OK
+RUN(video.webkitExitFullScreen())
+
+** Exited fullscreen
+END OF TEST
+
Copied: trunk/LayoutTests/media/video-fullscreen-only-playback.html (from rev 252675, trunk/LayoutTests/media/video-fullscreeen-only-playback.html) (0 => 252676)
--- trunk/LayoutTests/media/video-fullscreen-only-playback.html (rev 0)
+++ trunk/LayoutTests/media/video-fullscreen-only-playback.html 2019-11-20 02:43:37 UTC (rev 252676)
@@ -0,0 +1,70 @@
+<!-- webkit-test-runner [ enableModernMediaControls=false ] -->
+<html>
+ <head>
+ <script src=""
+ <script src=""
+ <script src=""
+ <script>
+
+ function fullscreenchange()
+ {
+ if (!document.webkitIsFullScreen)
+ endfullscreen();
+ }
+
+ function playing()
+ {
+ consoleWrite("<br>** Entered fullscreen");
+ testExpected("video.webkitDisplayingFullscreen", true);
+ run("video.webkitExitFullScreen()");
+ }
+
+ function endfullscreen()
+ {
+ consoleWrite("<br>** Exited fullscreen");
+ endTest();
+ }
+
+ function canplaythrough()
+ {
+ testExpected("video.webkitSupportsFullscreen", true);
+ testExpected("video.webkitDisplayingFullscreen", false);
+
+ consoleWrite("<br>** Clicking \'play\' button...");
+
+ try {
+ clickPlayButton(video);
+ } catch (exception) {
+ failTest(exception.description);
+ return;
+ }
+ }
+
+
+ function start()
+ {
+ if (!window.internals) {
+ failTest('This test requires window.internals.');
+ return;
+ }
+
+ video = document.getElementsByTagName('video')[0];
+ waitForEvent("canplaythrough", canplaythrough);
+ waitForEvent('playing', playing);
+
+ video.addEventListener('webkitendfullscreen', endfullscreen, true);
+ video.addEventListener('webkitfullscreenchange', fullscreenchange, true);
+
+ video.src = "" "content/test");
+
+ run("internals.settings.setAllowsInlineMediaPlayback(false)");
+ consoleWrite("");
+ }
+ </script>
+ </head>
+
+ <body _onload_="start()">
+ <video controls></video>
+ <p>Test play() when <video> playback requires fullscreen.</p>
+ </body>
+</html>
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (252675 => 252676)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2019-11-20 02:37:16 UTC (rev 252675)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2019-11-20 02:43:37 UTC (rev 252676)
@@ -2500,7 +2500,7 @@
webkit.org/b/194629 http/tests/websocket/connection-refusal-in-frame-resource-load-statistics.html [ Timeout ]
-webkit.org/b/137311 media/video-fullscreeen-only-playback.html [ Timeout ]
+webkit.org/b/137311 media/video-fullscreen-only-playback.html [ Timeout ]
webkit.org/b/195135 storage/indexeddb/IDBObject-leak.html [ Timeout Failure Pass ]
Modified: trunk/LayoutTests/platform/ios/TestExpectations (252675 => 252676)
--- trunk/LayoutTests/platform/ios/TestExpectations 2019-11-20 02:37:16 UTC (rev 252675)
+++ trunk/LayoutTests/platform/ios/TestExpectations 2019-11-20 02:43:37 UTC (rev 252676)
@@ -2553,7 +2553,7 @@
media/video-controls-visible-exiting-fullscreen.html [ Failure ]
media/video-controls-zoomed.html [ Failure ]
media/video-frame-accurate-seek.html [ Failure ]
-media/video-fullscreeen-only-controls.html [ Failure ]
+media/video-fullscreen-only-controls.html [ Failure ]
media/video-initially-hidden-volume-slider-up.html [ Failure ]
media/video-trackmenu-selection.html [ Failure ]
media/video-volume.html [ Failure ]
@@ -2605,7 +2605,7 @@
webkit.org/b/163291 media/require-user-gesture-to-load-video.html
webkit.org/b/163291 media/video-controls-transformed.html [ Failure ]
webkit.org/b/163291 media/video-controls-visible-audio-only.html [ Failure ]
-webkit.org/b/163291 media/video-fullscreeen-only-playback.html [ Failure ]
+webkit.org/b/163291 media/video-fullscreen-only-playback.html [ Failure ]
webkit.org/b/163291 media/video-play-audio-require-user-gesture.html [ Failure ]
webkit.org/b/163291 media/video-play-require-user-gesture.html
Modified: trunk/LayoutTests/platform/mac/TestExpectations (252675 => 252676)
--- trunk/LayoutTests/platform/mac/TestExpectations 2019-11-20 02:37:16 UTC (rev 252675)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2019-11-20 02:43:37 UTC (rev 252676)
@@ -786,7 +786,7 @@
webkit.org/b/135071 media/video-seek-with-negative-playback.html [ Pass Timeout ]
webkit.org/b/135160 [ Sierra+ ] media/track/track-in-band-subtitles-too-large.html [ Failure ]
webkit.org/b/135160 media/track/track-long-word-container-sizing.html [ Failure ]
-webkit.org/b/137311 media/video-fullscreeen-only-playback.html [ Pass Timeout Crash ]
+webkit.org/b/137311 media/video-fullscreen-only-playback.html [ Pass Timeout Crash ]
webkit.org/b/139789 media/media-controls-timeline-updates.html [ Pass Failure ]
webkit.org/b/139825 media/video-seek-past-end-paused.html [ Pass Timeout ]
webkit.org/b/141084 http/tests/media/video-preload.html [ Pass Timeout ]
Modified: trunk/LayoutTests/platform/win/TestExpectations (252675 => 252676)
--- trunk/LayoutTests/platform/win/TestExpectations 2019-11-20 02:37:16 UTC (rev 252675)
+++ trunk/LayoutTests/platform/win/TestExpectations 2019-11-20 02:43:37 UTC (rev 252676)
@@ -1023,8 +1023,8 @@
media/video-autoplay.html [ Skip ] # Crashing
media/video-controls-transformed.html [ Skip ] # Crashing
media/video-display-aspect-ratio.html [ Skip ] # Crashing
-media/video-fullscreeen-only-controls.html [ Skip ] # Crashing
-media/video-fullscreeen-only-playback.html [ Skip ] # Crashing
+media/video-fullscreen-only-controls.html [ Skip ] # Crashing
+media/video-fullscreen-only-playback.html [ Skip ] # Crashing
media/video-load-networkState.html [ Skip ] # Crashing
media/video-object-fit.html [ Skip ] # Crashing
media/video-object-fit-change.html [ Skip ] # Crashing
