Diff
Modified: trunk/Tools/ChangeLog (252718 => 252719)
--- trunk/Tools/ChangeLog 2019-11-21 00:28:22 UTC (rev 252718)
+++ trunk/Tools/ChangeLog 2019-11-21 01:08:30 UTC (rev 252719)
@@ -1,3 +1,24 @@
+2019-11-20 Wenson Hsieh <[email protected]>
+
+ Correct argument types in UIScriptController::activateDataListSuggestion after r252062
+ https://bugs.webkit.org/show_bug.cgi?id=203116
+
+ Reviewed by Tim Horton.
+
+ Use `unsigned` to represent `unsigned long` arguments declared in the IDL.
+
+ * DumpRenderTree/mac/UIScriptControllerMac.h:
+ * DumpRenderTree/mac/UIScriptControllerMac.mm:
+ (WTR::UIScriptControllerMac::activateDataListSuggestion):
+ * TestRunnerShared/UIScriptContext/UIScriptController.h:
+ (WTR::UIScriptController::activateDataListSuggestion):
+ * WebKitTestRunner/ios/UIScriptControllerIOS.h:
+ * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
+ (WTR::UIScriptControllerIOS::activateDataListSuggestion):
+ * WebKitTestRunner/mac/UIScriptControllerMac.h:
+ * WebKitTestRunner/mac/UIScriptControllerMac.mm:
+ (WTR::UIScriptControllerMac::activateDataListSuggestion):
+
2019-11-20 Fujii Hironori <[email protected]>
run-api-tests reports AssertionError os.pathsep not in value in _append_value_colon_separated in Cygwin Python
Modified: trunk/Tools/DumpRenderTree/mac/UIScriptControllerMac.h (252718 => 252719)
--- trunk/Tools/DumpRenderTree/mac/UIScriptControllerMac.h 2019-11-21 00:28:22 UTC (rev 252718)
+++ trunk/Tools/DumpRenderTree/mac/UIScriptControllerMac.h 2019-11-21 01:08:30 UTC (rev 252719)
@@ -50,7 +50,7 @@
void simulateAccessibilitySettingsChangeNotification(JSValueRef) override;
NSUndoManager *platformUndoManager() const override;
void copyText(JSStringRef) override;
- void activateDataListSuggestion(long, JSValueRef) override;
+ void activateDataListSuggestion(unsigned, JSValueRef) override;
};
}
Modified: trunk/Tools/DumpRenderTree/mac/UIScriptControllerMac.mm (252718 => 252719)
--- trunk/Tools/DumpRenderTree/mac/UIScriptControllerMac.mm 2019-11-21 00:28:22 UTC (rev 252718)
+++ trunk/Tools/DumpRenderTree/mac/UIScriptControllerMac.mm 2019-11-21 01:08:30 UTC (rev 252719)
@@ -100,7 +100,7 @@
#endif
}
-void UIScriptControllerMac::activateDataListSuggestion(long index, JSValueRef callback)
+void UIScriptControllerMac::activateDataListSuggestion(unsigned index, JSValueRef callback)
{
// FIXME: Not implemented.
UNUSED_PARAM(index);
Modified: trunk/Tools/TestRunnerShared/UIScriptContext/UIScriptController.h (252718 => 252719)
--- trunk/Tools/TestRunnerShared/UIScriptContext/UIScriptController.h 2019-11-21 00:28:22 UTC (rev 252718)
+++ trunk/Tools/TestRunnerShared/UIScriptContext/UIScriptController.h 2019-11-21 01:08:30 UTC (rev 252719)
@@ -202,7 +202,7 @@
virtual JSObjectRef calendarType() const { notImplemented(); return nullptr; }
virtual void setDefaultCalendarType(JSStringRef calendarIdentifier) { notImplemented(); }
virtual JSObjectRef inputViewBounds() const { notImplemented(); return nullptr; }
- virtual void activateDataListSuggestion(long, JSValueRef) { notImplemented(); }
+ virtual void activateDataListSuggestion(unsigned, JSValueRef) { notImplemented(); }
// Share Sheet
Modified: trunk/Tools/WebKitTestRunner/ios/UIScriptControllerIOS.h (252718 => 252719)
--- trunk/Tools/WebKitTestRunner/ios/UIScriptControllerIOS.h 2019-11-21 00:28:22 UTC (rev 252718)
+++ trunk/Tools/WebKitTestRunner/ios/UIScriptControllerIOS.h 2019-11-21 01:08:30 UTC (rev 252719)
@@ -129,7 +129,7 @@
void beginBackSwipe(JSValueRef) override;
void completeBackSwipe(JSValueRef) override;
bool isShowingDataListSuggestions() const override;
- void activateDataListSuggestion(long, JSValueRef) override;
+ void activateDataListSuggestion(unsigned, JSValueRef) override;
void drawSquareInEditableImage() override;
long numberOfStrokesInEditableImage() override;
void setKeyboardInputModeIdentifier(JSStringRef) override;
Modified: trunk/Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm (252718 => 252719)
--- trunk/Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm 2019-11-21 00:28:22 UTC (rev 252718)
+++ trunk/Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm 2019-11-21 01:08:30 UTC (rev 252719)
@@ -1032,7 +1032,7 @@
[webView() _completeBackSwipeForTesting];
}
-void UIScriptControllerIOS::activateDataListSuggestion(long index, JSValueRef callback)
+void UIScriptControllerIOS::activateDataListSuggestion(unsigned index, JSValueRef callback)
{
// FIXME: Not implemented.
UNUSED_PARAM(index);
Modified: trunk/Tools/WebKitTestRunner/mac/UIScriptControllerMac.h (252718 => 252719)
--- trunk/Tools/WebKitTestRunner/mac/UIScriptControllerMac.h 2019-11-21 00:28:22 UTC (rev 252718)
+++ trunk/Tools/WebKitTestRunner/mac/UIScriptControllerMac.h 2019-11-21 01:08:30 UTC (rev 252719)
@@ -43,7 +43,7 @@
double zoomScale() const override;
void simulateAccessibilitySettingsChangeNotification(JSValueRef) override;
bool isShowingDataListSuggestions() const override;
- void activateDataListSuggestion(long index, JSValueRef callback) override;
+ void activateDataListSuggestion(unsigned index, JSValueRef callback) override;
void beginBackSwipe(JSValueRef) override;
void completeBackSwipe(JSValueRef) override;
void playBackEventStream(JSStringRef, JSValueRef) override;
Modified: trunk/Tools/WebKitTestRunner/mac/UIScriptControllerMac.mm (252718 => 252719)
--- trunk/Tools/WebKitTestRunner/mac/UIScriptControllerMac.mm 2019-11-21 00:28:22 UTC (rev 252718)
+++ trunk/Tools/WebKitTestRunner/mac/UIScriptControllerMac.mm 2019-11-21 01:08:30 UTC (rev 252719)
@@ -100,7 +100,7 @@
return dataListSuggestionsTableView();
}
-void UIScriptControllerMac::activateDataListSuggestion(long index, JSValueRef callback)
+void UIScriptControllerMac::activateDataListSuggestion(unsigned index, JSValueRef callback)
{
unsigned callbackID = m_context->prepareForAsyncTask(callback, CallbackTypeNonPersistent);
