Title: [252772] trunk/Source
- Revision
- 252772
- Author
- [email protected]
- Date
- 2019-11-22 06:51:25 -0800 (Fri, 22 Nov 2019)
Log Message
Unreviewed. Fix GTK/WPE debug build after r252770
Just remove the ASSERT instead, since it now always receive a newly created Ref.
Source/_javascript_Core:
* inspector/remote/glib/RemoteInspectorGlib.cpp:
(Inspector::RemoteInspector::setupConnection):
Source/WebDriver:
* glib/SessionHostGlib.cpp:
(WebDriver::SessionHost::setupConnection):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (252771 => 252772)
--- trunk/Source/_javascript_Core/ChangeLog 2019-11-22 14:42:11 UTC (rev 252771)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-11-22 14:51:25 UTC (rev 252772)
@@ -2,11 +2,20 @@
Unreviewed. Fix GTK/WPE debug build after r252770
+ Just remove the ASSERT instead, since it now always receive a newly created Ref.
+
* inspector/remote/glib/RemoteInspectorGlib.cpp:
(Inspector::RemoteInspector::setupConnection):
2019-11-22 Carlos Garcia Campos <[email protected]>
+ Unreviewed. Fix GTK/WPE debug build after r252770
+
+ * inspector/remote/glib/RemoteInspectorGlib.cpp:
+ (Inspector::RemoteInspector::setupConnection):
+
+2019-11-22 Carlos Garcia Campos <[email protected]>
+
[GTK][WPE] RemoteInspector: use sockets instead of DBus
https://bugs.webkit.org/show_bug.cgi?id=204503
Modified: trunk/Source/_javascript_Core/inspector/remote/glib/RemoteInspectorGlib.cpp (252771 => 252772)
--- trunk/Source/_javascript_Core/inspector/remote/glib/RemoteInspectorGlib.cpp 2019-11-22 14:42:11 UTC (rev 252771)
+++ trunk/Source/_javascript_Core/inspector/remote/glib/RemoteInspectorGlib.cpp 2019-11-22 14:51:25 UTC (rev 252772)
@@ -136,9 +136,7 @@
{
LockHolder lock(m_mutex);
- ASSERT(connection.ptr());
ASSERT(!m_socketConnection);
-
m_socketConnection = WTFMove(connection);
if (!m_targetMap.isEmpty())
pushListingsSoon();
Modified: trunk/Source/WebDriver/ChangeLog (252771 => 252772)
--- trunk/Source/WebDriver/ChangeLog 2019-11-22 14:42:11 UTC (rev 252771)
+++ trunk/Source/WebDriver/ChangeLog 2019-11-22 14:51:25 UTC (rev 252772)
@@ -2,11 +2,20 @@
Unreviewed. Fix GTK/WPE debug build after r252770
+ Just remove the ASSERT instead, since it now always receive a newly created Ref.
+
* glib/SessionHostGlib.cpp:
(WebDriver::SessionHost::setupConnection):
2019-11-22 Carlos Garcia Campos <[email protected]>
+ Unreviewed. Fix GTK/WPE debug build after r252770
+
+ * glib/SessionHostGlib.cpp:
+ (WebDriver::SessionHost::setupConnection):
+
+2019-11-22 Carlos Garcia Campos <[email protected]>
+
[GTK][WPE] RemoteInspector: use sockets instead of DBus
https://bugs.webkit.org/show_bug.cgi?id=204503
Modified: trunk/Source/WebDriver/glib/SessionHostGlib.cpp (252771 => 252772)
--- trunk/Source/WebDriver/glib/SessionHostGlib.cpp 2019-11-22 14:42:11 UTC (rev 252771)
+++ trunk/Source/WebDriver/glib/SessionHostGlib.cpp 2019-11-22 14:51:25 UTC (rev 252772)
@@ -207,7 +207,6 @@
void SessionHost::setupConnection(Ref<SocketConnection>&& connection)
{
ASSERT(!m_socketConnection);
- ASSERT(connection.ptr());
m_socketConnection = WTFMove(connection);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
