Title: [252881] trunk/Source/WebCore
- Revision
- 252881
- Author
- [email protected]
- Date
- 2019-11-26 02:37:43 -0800 (Tue, 26 Nov 2019)
Log Message
Document::needsStyleRecalc() shouldn't return true for fragment scrolling (m_gotoAnchorNeededAfterStylesheetsLoad)
https://bugs.webkit.org/show_bug.cgi?id=204593
Reviewed by Antti Koivisto.
After r252761, we no longer triggers a fragment scrolling as a part of style resolution.
Consequently, there is no need for Document::needsStyleRecalc() to return true
even when m_gotoAnchorNeededAfterStylesheetsLoad is set and there are no more pending stylesheets.
No new tests since there shouldn't really be any observable behavior difference.
* dom/Document.cpp:
(WebCore::Document::needsStyleRecalc const):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (252880 => 252881)
--- trunk/Source/WebCore/ChangeLog 2019-11-26 10:28:09 UTC (rev 252880)
+++ trunk/Source/WebCore/ChangeLog 2019-11-26 10:37:43 UTC (rev 252881)
@@ -1,3 +1,19 @@
+2019-11-26 Ryosuke Niwa <[email protected]>
+
+ Document::needsStyleRecalc() shouldn't return true for fragment scrolling (m_gotoAnchorNeededAfterStylesheetsLoad)
+ https://bugs.webkit.org/show_bug.cgi?id=204593
+
+ Reviewed by Antti Koivisto.
+
+ After r252761, we no longer triggers a fragment scrolling as a part of style resolution.
+ Consequently, there is no need for Document::needsStyleRecalc() to return true
+ even when m_gotoAnchorNeededAfterStylesheetsLoad is set and there are no more pending stylesheets.
+
+ No new tests since there shouldn't really be any observable behavior difference.
+
+ * dom/Document.cpp:
+ (WebCore::Document::needsStyleRecalc const):
+
2019-11-26 Antoine Quint <[email protected]>
[Web Animations] Layout of children of element with forwards-filling opacity animation may be incorrect after removal
Modified: trunk/Source/WebCore/dom/Document.cpp (252880 => 252881)
--- trunk/Source/WebCore/dom/Document.cpp 2019-11-26 10:28:09 UTC (rev 252880)
+++ trunk/Source/WebCore/dom/Document.cpp 2019-11-26 10:37:43 UTC (rev 252881)
@@ -2032,10 +2032,6 @@
if (styleScope().hasPendingUpdate())
return true;
- // Ensure this happens eventually as it is currently in resolveStyle. This can be removed if the code moves.
- if (m_gotoAnchorNeededAfterStylesheetsLoad && !styleScope().hasPendingSheets())
- return true;
-
return false;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
