Log Message
Attempting to enable more than one FuzzerAgent should result in an error https://bugs.webkit.org/show_bug.cgi?id=204607
Patch by Tuomas Karkkainen <[email protected]> on 2019-11-26 Reviewed by Antti Koivisto. * runtime/VM.cpp: * runtime/VM.h:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (252884 => 252885)
--- trunk/Source/_javascript_Core/ChangeLog 2019-11-26 12:17:56 UTC (rev 252884)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-11-26 12:21:13 UTC (rev 252885)
@@ -1,3 +1,13 @@
+2019-11-26 Tuomas Karkkainen <[email protected]>
+
+ Attempting to enable more than one FuzzerAgent should result in an error
+ https://bugs.webkit.org/show_bug.cgi?id=204607
+
+ Reviewed by Antti Koivisto.
+
+ * runtime/VM.cpp:
+ * runtime/VM.h:
+
2019-11-26 Carlos Garcia Campos <[email protected]>
[GLIB] The API lock should be held before calling JSC::createTypeError
Modified: trunk/Source/_javascript_Core/runtime/VM.cpp (252884 => 252885)
--- trunk/Source/_javascript_Core/runtime/VM.cpp 2019-11-26 12:17:56 UTC (rev 252884)
+++ trunk/Source/_javascript_Core/runtime/VM.cpp 2019-11-26 12:21:13 UTC (rev 252885)
@@ -461,7 +461,7 @@
if (Options::useRandomizingFuzzerAgent())
setFuzzerAgent(makeUnique<RandomizingFuzzerAgent>(*this));
- else if (Options::useDoublePredictionFuzzerAgent())
+ if (Options::useDoublePredictionFuzzerAgent())
setFuzzerAgent(makeUnique<DoublePredictionFuzzerAgent>(*this));
if (Options::alwaysGeneratePCToCodeOriginMap())
Modified: trunk/Source/_javascript_Core/runtime/VM.h (252884 => 252885)
--- trunk/Source/_javascript_Core/runtime/VM.h 2019-11-26 12:17:56 UTC (rev 252884)
+++ trunk/Source/_javascript_Core/runtime/VM.h 2019-11-26 12:21:13 UTC (rev 252885)
@@ -303,6 +303,7 @@
FuzzerAgent* fuzzerAgent() const { return m_fuzzerAgent.get(); }
void setFuzzerAgent(std::unique_ptr<FuzzerAgent>&& fuzzerAgent)
{
+ RELEASE_ASSERT_WITH_MESSAGE(!m_fuzzerAgent, "Only one FuzzerAgent can be specified at a time.");
m_fuzzerAgent = WTFMove(fuzzerAgent);
}
_______________________________________________ webkit-changes mailing list [email protected] https://lists.webkit.org/mailman/listinfo/webkit-changes
