Title: [253354] trunk/Source/WebKit
- Revision
- 253354
- Author
- [email protected]
- Date
- 2019-12-10 15:59:25 -0800 (Tue, 10 Dec 2019)
Log Message
Unreviewed, drop debug assertion in InspectorTargetProxy::didCommitProvisionalTarget() that is hitting after r253337
r253337 causes the ProvisionalPageProxy to get destroyed a little bit early, before didCommitProvisionalTarget()
is called. didCommitProvisionalTarget() had an assertion that isProvisional() returns true, which merely checked
that the ProvisionalPageProxy is still alive before nulling out its WeakPtr.
* UIProcess/InspectorTargetProxy.cpp:
(WebKit::InspectorTargetProxy::didCommitProvisionalTarget):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (253353 => 253354)
--- trunk/Source/WebKit/ChangeLog 2019-12-10 23:39:13 UTC (rev 253353)
+++ trunk/Source/WebKit/ChangeLog 2019-12-10 23:59:25 UTC (rev 253354)
@@ -1,3 +1,14 @@
+2019-12-10 Chris Dumez <[email protected]>
+
+ Unreviewed, drop debug assertion in InspectorTargetProxy::didCommitProvisionalTarget() that is hitting after r253337
+
+ r253337 causes the ProvisionalPageProxy to get destroyed a little bit early, before didCommitProvisionalTarget()
+ is called. didCommitProvisionalTarget() had an assertion that isProvisional() returns true, which merely checked
+ that the ProvisionalPageProxy is still alive before nulling out its WeakPtr.
+
+ * UIProcess/InspectorTargetProxy.cpp:
+ (WebKit::InspectorTargetProxy::didCommitProvisionalTarget):
+
2019-12-10 Per Arne Vollan <[email protected]>
[iOS] Deny mach lookup access to network extension services in the WebContent sandbox
Modified: trunk/Source/WebKit/UIProcess/InspectorTargetProxy.cpp (253353 => 253354)
--- trunk/Source/WebKit/UIProcess/InspectorTargetProxy.cpp 2019-12-10 23:39:13 UTC (rev 253353)
+++ trunk/Source/WebKit/UIProcess/InspectorTargetProxy.cpp 2019-12-10 23:59:25 UTC (rev 253354)
@@ -94,7 +94,6 @@
void InspectorTargetProxy::didCommitProvisionalTarget()
{
- ASSERT(isProvisional());
m_provisionalPage = nullptr;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
