Diff
Modified: trunk/Source/WebCore/ChangeLog (253358 => 253359)
--- trunk/Source/WebCore/ChangeLog 2019-12-11 01:45:00 UTC (rev 253358)
+++ trunk/Source/WebCore/ChangeLog 2019-12-11 01:52:02 UTC (rev 253359)
@@ -1,3 +1,17 @@
+2019-12-10 Fujii Hironori <[email protected]>
+
+ [Win] Fix MSVC warning C4701: potentially uninitialized local variable 'x' used
+ https://bugs.webkit.org/show_bug.cgi?id=205052
+
+ Reviewed by Don Olmstead.
+
+ * platform/graphics/cairo/CairoOperations.cpp:
+ (WebCore::Cairo::setLineCap): Zero-initialize a local variable cairoCap.
+ (WebCore::Cairo::setLineJoin): Zero-initialize a local variable cairoJoin
+ * platform/network/NetworkStorageSession.cpp:
+ (WebCore::NetworkStorageSession::shouldBlockCookies const): Added
+ ASSERT_NOT_REACHED() and return false at the end of the function.
+
2019-12-10 Per Arne Vollan <[email protected]>
[iOS] Calls to the device motion API should be done in the UI process
Modified: trunk/Source/WebCore/platform/graphics/cairo/CairoOperations.cpp (253358 => 253359)
--- trunk/Source/WebCore/platform/graphics/cairo/CairoOperations.cpp 2019-12-11 01:45:00 UTC (rev 253358)
+++ trunk/Source/WebCore/platform/graphics/cairo/CairoOperations.cpp 2019-12-11 01:52:02 UTC (rev 253359)
@@ -632,7 +632,7 @@
void setLineCap(PlatformContextCairo& platformContext, LineCap lineCap)
{
- cairo_line_cap_t cairoCap;
+ cairo_line_cap_t cairoCap { };
switch (lineCap) {
case ButtCap:
cairoCap = CAIRO_LINE_CAP_BUTT;
@@ -657,7 +657,7 @@
void setLineJoin(PlatformContextCairo& platformContext, LineJoin lineJoin)
{
- cairo_line_join_t cairoJoin;
+ cairo_line_join_t cairoJoin { };
switch (lineJoin) {
case MiterJoin:
cairoJoin = CAIRO_LINE_JOIN_MITER;
Modified: trunk/Source/WebCore/platform/network/NetworkStorageSession.cpp (253358 => 253359)
--- trunk/Source/WebCore/platform/network/NetworkStorageSession.cpp 2019-12-11 01:45:00 UTC (rev 253358)
+++ trunk/Source/WebCore/platform/network/NetworkStorageSession.cpp 2019-12-11 01:52:02 UTC (rev 253359)
@@ -123,6 +123,8 @@
case ThirdPartyCookieBlockingMode::OnlyAccordingToPerDomainPolicy:
return shouldBlockThirdPartyCookies(resourceDomain);
}
+ ASSERT_NOT_REACHED();
+ return false;
}
Optional<Seconds> NetworkStorageSession::maxAgeCacheCap(const ResourceRequest& request)
Modified: trunk/Source/WebDriver/ChangeLog (253358 => 253359)
--- trunk/Source/WebDriver/ChangeLog 2019-12-11 01:45:00 UTC (rev 253358)
+++ trunk/Source/WebDriver/ChangeLog 2019-12-11 01:52:02 UTC (rev 253359)
@@ -1,3 +1,15 @@
+2019-12-10 Fujii Hironori <[email protected]>
+
+ [Win] Fix MSVC warning C4701: potentially uninitialized local variable 'x' used
+ https://bugs.webkit.org/show_bug.cgi?id=205052
+
+ Reviewed by Don Olmstead.
+
+ * Session.cpp:
+ (WebDriver::Session::getToplevelBrowsingContextRect):
+ (WebDriver::Session::computeElementLayout):
+ Zero-initialized local variables.
+
2019-12-03 Carlos Garcia Campos <[email protected]>
WebDriver: handle elements of type file in send keys command
Modified: trunk/Source/WebDriver/Session.cpp (253358 => 253359)
--- trunk/Source/WebDriver/Session.cpp 2019-12-11 01:45:00 UTC (rev 253358)
+++ trunk/Source/WebDriver/Session.cpp 2019-12-11 01:52:02 UTC (rev 253359)
@@ -728,7 +728,7 @@
return;
}
RefPtr<JSON::Object> windowOrigin;
- double x, y;
+ double x = 0, y = 0;
if (!browsingContext->getObject("windowOrigin"_s, windowOrigin)
|| !windowOrigin->getDouble("x"_s, x)
|| !windowOrigin->getDouble("y"_s, y)) {
@@ -736,7 +736,7 @@
return;
}
RefPtr<JSON::Object> windowSize;
- double width, height;
+ double width = 0, height = 0;
if (!browsingContext->getObject("windowSize"_s, windowSize)
|| !windowSize->getDouble("width"_s, width)
|| !windowSize->getDouble("height"_s, height)) {
@@ -996,7 +996,7 @@
completionHandler(rect, WTF::nullopt, isObscured, nullptr);
return;
}
- int inViewCenterPointX, inViewCenterPointY;
+ int inViewCenterPointX = 0, inViewCenterPointY = 0;
if (!inViewCenterPointObject->getInteger("x"_s, inViewCenterPointX)
|| !inViewCenterPointObject->getInteger("y"_s, inViewCenterPointY)) {
completionHandler(WTF::nullopt, WTF::nullopt, isObscured, nullptr);
Modified: trunk/Source/WebKit/ChangeLog (253358 => 253359)
--- trunk/Source/WebKit/ChangeLog 2019-12-11 01:45:00 UTC (rev 253358)
+++ trunk/Source/WebKit/ChangeLog 2019-12-11 01:52:02 UTC (rev 253359)
@@ -1,3 +1,17 @@
+2019-12-10 Fujii Hironori <[email protected]>
+
+ [Win] Fix MSVC warning C4701: potentially uninitialized local variable 'x' used
+ https://bugs.webkit.org/show_bug.cgi?id=205052
+
+ Reviewed by Don Olmstead.
+
+ * NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:
+ * NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp:
+ (WebKit::ResourceLoadStatisticsMemoryStore::shouldRemoveAllButCookiesFor const):
+ * NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp:
+ (WebKit::ResourceLoadStatisticsStore::hasStatisticsExpired const):
+ Zero-initialized local variables.
+
2019-12-10 Per Arne Vollan <[email protected]>
[iOS] Calls to the device motion API should be done in the UI process
Modified: trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp (253358 => 253359)
--- trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp 2019-12-11 01:45:00 UTC (rev 253358)
+++ trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp 2019-12-11 01:52:02 UTC (rev 253359)
@@ -2167,7 +2167,7 @@
bool isRemovalEnabled = firstPartyWebsiteDataRemovalMode() != FirstPartyWebsiteDataRemovalMode::None || resourceStatistic.isScheduledForAllButCookieDataRemoval;
bool isResourceGrandfathered = shouldCheckForGrandfathering && resourceStatistic.grandfathered;
- OperatingDatesWindow window;
+ OperatingDatesWindow window { };
switch (firstPartyWebsiteDataRemovalMode()) {
case FirstPartyWebsiteDataRemovalMode::AllButCookies:
FALLTHROUGH;
Modified: trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp (253358 => 253359)
--- trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp 2019-12-11 01:45:00 UTC (rev 253358)
+++ trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp 2019-12-11 01:52:02 UTC (rev 253359)
@@ -888,7 +888,7 @@
bool isRemovalEnabled = firstPartyWebsiteDataRemovalMode() != FirstPartyWebsiteDataRemovalMode::None || resourceStatistic.gotLinkDecorationFromPrevalentResource;
bool isResourceGrandfathered = shouldCheckForGrandfathering && resourceStatistic.grandfathered;
- OperatingDatesWindow window;
+ OperatingDatesWindow window { };
switch (firstPartyWebsiteDataRemovalMode()) {
case FirstPartyWebsiteDataRemovalMode::AllButCookies:
FALLTHROUGH;
Modified: trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp (253358 => 253359)
--- trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp 2019-12-11 01:45:00 UTC (rev 253358)
+++ trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp 2019-12-11 01:52:02 UTC (rev 253359)
@@ -504,7 +504,7 @@
{
ASSERT(!RunLoop::isMain());
- unsigned operatingDatesWindowInDays;
+ unsigned operatingDatesWindowInDays = 0;
switch (operatingDatesWindow) {
case OperatingDatesWindow::Long:
operatingDatesWindowInDays = operatingDatesWindowLong;
