Title: [253459] trunk/Tools
- Revision
- 253459
- Author
- [email protected]
- Date
- 2019-12-12 17:49:54 -0800 (Thu, 12 Dec 2019)
Log Message
webkit-patch print-expectations fails to format TestExpectationLine with DumpJSConsoleLogInStdErr
https://bugs.webkit.org/show_bug.cgi?id=194283
Reviewed by Youenn Fablet.
* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser): Add DumpJSConsoleLogInStdErr to TestExpectationParser._expectation_tokens.
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
Added a tokenize test and round tip test for DumpJSConsoleLogInStdErr.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (253458 => 253459)
--- trunk/Tools/ChangeLog 2019-12-13 01:11:15 UTC (rev 253458)
+++ trunk/Tools/ChangeLog 2019-12-13 01:49:54 UTC (rev 253459)
@@ -1,3 +1,15 @@
+2019-12-12 Fujii Hironori <[email protected]>
+
+ webkit-patch print-expectations fails to format TestExpectationLine with DumpJSConsoleLogInStdErr
+ https://bugs.webkit.org/show_bug.cgi?id=194283
+
+ Reviewed by Youenn Fablet.
+
+ * Scripts/webkitpy/layout_tests/models/test_expectations.py:
+ (TestExpectationParser): Add DumpJSConsoleLogInStdErr to TestExpectationParser._expectation_tokens.
+ * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
+ Added a tokenize test and round tip test for DumpJSConsoleLogInStdErr.
+
2019-12-12 Alex Christensen <[email protected]>
Don't assert in HTTPServer::respondToRequests when connections fail
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py (253458 => 253459)
--- trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py 2019-12-13 01:11:15 UTC (rev 253458)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py 2019-12-13 01:49:54 UTC (rev 253459)
@@ -242,6 +242,7 @@
# FIXME: Update the original modifiers list and remove this once the old syntax is gone.
_expectation_tokens = {
'Crash': 'CRASH',
+ 'DumpJSConsoleLogInStdErr': 'DUMPJSCONSOLELOGINSTDERR',
'Failure': 'FAIL',
'ImageOnlyFailure': 'IMAGE',
'Leak': 'LEAK',
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py (253458 => 253459)
--- trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py 2019-12-13 01:11:15 UTC (rev 253458)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py 2019-12-13 01:49:54 UTC (rev 253459)
@@ -401,6 +401,9 @@
self.assert_tokenize_exp('foo.html [ WontFix ImageOnlyFailure ]', modifiers=['WONTFIX'], expectations=['IMAGE'])
self.assert_tokenize_exp('foo.html [ WontFix Pass Failure ]', modifiers=['WONTFIX'], expectations=['PASS', 'FAIL'])
+ def test_dump_js_console_log_in_stderr(self):
+ self.assert_tokenize_exp('foo.html [ DumpJSConsoleLogInStdErr ]', modifiers=['DUMPJSCONSOLELOGINSTDERR'], expectations=['PASS'])
+
def test_blank_line(self):
self.assert_tokenize_exp('', name=None)
@@ -710,6 +713,8 @@
self.assert_round_trip('# Foo')
self.assert_round_trip('# Foo :')
self.assert_round_trip('# Foo : =')
+ self.assert_round_trip('foo [ Crash Skip WontFix ]')
+ self.assert_round_trip('foo [ DumpJSConsoleLogInStdErr Image ]')
def test_list_roundtrip(self):
self.assert_list_round_trip('')
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
